From nobody Tue Sep 06 15:22:25 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MMTdv68f1z4c2KV; Tue, 6 Sep 2022 15:22:27 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MMTdv5jsMz47xx; Tue, 6 Sep 2022 15:22:27 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662477747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xz+efB+g5aRtnfPoeQhdynr3ZDlQklz0Qh6FEg/WzZg=; b=lybvYN2dDl4YWS/l/2KbgY/WtFEyjf+plTz5gP12/VnOmx8mTU/tyDLCB+oV0hM36Ubx+U 145FMxbqEiRLXiZVnPAZ0Uv4facx5k/51D8YT6CsxrNpXR30R3o2UH6LVmyMF3KCz8Ldyj eWSRgpngMkrJARF93nTGAZdHFsq8sWKlxFmzAzzbKNAJzu0879xpp11EUAO54Iv8eBXSE7 SJyOLGGFeb7tLBecU6BqAbNRW5alB4U28/rSgOKwgsViu+Z30nycqijzDhyOUI0P5G8ipI qwlFgwokbBlRLf9uTRGgDzXol0ZEiPc1aRW8m9F7IejDcf6kYFEhPXIIesb8XA== Received: from localhost (unknown [IPv6:2a02:a03f:894b:4700:20a7:3046:629d:6c01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MMTdv0mqfz10FV; Tue, 6 Sep 2022 15:22:27 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Tue, 6 Sep 2022 17:22:25 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Colin Percival Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: 5d45f99a1ed8 - stable/13 - i386 doreti: Fix calculation of stack frame size Message-ID: <20220906172225.1a4d1064@FreeBSD.org> In-Reply-To: <01000182feec990a-943b1465-055b-4cb8-984c-225a4feabf7d-000000@email.amazonses.com> References: <202209021506.282F6Jhx029847@gitrepo.freebsd.org> <01000182feec990a-943b1465-055b-4cb8-984c-225a4feabf7d-000000@email.amazonses.com> List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662477747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xz+efB+g5aRtnfPoeQhdynr3ZDlQklz0Qh6FEg/WzZg=; b=w+EO72/hpVgkaiH7lpJyJZpRQGqtvqpPayU4JBXcpzoVeLkQE61wn0e8tjyvqCLQbdy2KL GIb58bdmqpUDK248PSh5Nw0u4fppM6buX6aytHBV/Br0tZf6D0jC7hHAeXvoG+A0vu+IOC b0dWpnvCZvMz0ZQFwQfPv5VYJMQu/nNC9gVplldA6UEbAPjZyuqLvzpY9ybB0CDMLyxO5C ITRiX4R9c3HKLLp8BqavZsLotXpAQQv6vzXwYXHXsEi0JaroXcIAz+3Twwj2UUEzdjpCM+ 1rvNGtItW/0PGwA8aObKSAQB/1hmYqcN9eqM4GLIW5f36DlqQhhQQKZs9LAkhg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662477747; a=rsa-sha256; cv=none; b=pQHzhbzx42IKa91V6XTjyaLnx8co2lVauTt+IykYdP1wi3iZEmgGOuQaTUohX+ahL3m//u MMzTQw/QgZbqrP5frCO4PHQGOo+OkFsAhXSfHEJ/axYm0pCaF7JRUVlxrDWFgKdLQOf7xd 9MtPm2BMTC4g7TvF8oqptvJ+KzLrfnIlaXX12oRZwXc1rrOjZ5yWZM66q/oZ8USmBt3aiX Tk2gStUeu268i4JEZsxd6XF5jD4EOrfjw5nRGwHAbi7rinJ26dO31DEJ1M5tc1v/kiK3qc +rRx/MaWRkIkWv0ZRvE6DUcs7bk2S68jsnOCmRivS6L/pqJQdAKCDAPNCObQbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Fri, 2 Sep 2022 15:58:14 +0000 Colin Percival wrote: > On 9/2/22 08:06, Tijl Coosemans wrote: >> The branch stable/13 has been updated by tijl: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=5d45f99a1ed861618d5c4d5b4252d5eba001ad35 >> >> commit 5d45f99a1ed861618d5c4d5b4252d5eba001ad35 >> Author: Tijl Coosemans >> AuthorDate: 2022-09-02 14:16:35 +0000 >> Commit: Tijl Coosemans >> CommitDate: 2022-09-02 15:02:00 +0000 >> >> i386 doreti: Fix calculation of stack frame size >> >> Reviewed by: kib >> Fixes: e8b2980e4a12 - i386 doreti: stop saving/restoring %ecx >> >> (cherry picked from commit cfdc649e455bc0d37d42c46b59360462e93b4300) > I assume this MFC took place 23 minutes after the original commit because it > was an urgent fix; to avoid the need for assumptions, please indicate the > reason for an accelerated MFC in the commit message when you skip the normal > 3 day waiting period. Will do. In this case it was a trivial fixup in a critical path. At the time I also thought it fixed a panic I was seeing but this turned out to be caused by another commit.