From nobody Tue Nov 29 23:18:15 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NMJD81k7Rz4hqBl; Tue, 29 Nov 2022 23:18:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NMJD811gkz40GC; Tue, 29 Nov 2022 23:18:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669763896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RZNPLGNW0E9khPclUvqJYt/pLTwQgsKa6zk4v98frWA=; b=pycPf/aGdOHk9UPAf3QAsvLMoWkLGfxPYZqbmdyUElBgjbVtmbbugsW7dSgFGGBH6ownJC Xi7ziRZUbfm6YEDQNtbA76uNPmB0BjFKYB3a4DQsy2U28rXKjfjB9Kgn0Ty9c2iyuzh6zX GBunvIG0sYE6aDswscF4aW6bUwuQkthmU7r4CyJ4TdStsxbKRy9fmpZPXaM7I2ehQzxHqw wA5K2/iokndXZNk0PQEPjrcCjV822cxDIluYMwHVbuEmDHFT6LrY9T5c86tIl5DTXutblP 9QG2E1GYM/NqI1UGBf572v0DQ1O8ruuGlKxID+EcHijjvBfRUUDBtCx02cqgjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669763896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RZNPLGNW0E9khPclUvqJYt/pLTwQgsKa6zk4v98frWA=; b=EPM3PzNnEN5l8/pcDOHaLr6er98u8TtxgOji/+iG65SDZ44+wcyoYXm2ly6aV6aViq14Ky rDdWQxPWS5WRsjeuGLwUV8eG0xMd+pcLuiCb2tI4uSzSMMIKGgvHVcSR/jmJW5Z27CmaRl vhLYxDAZy88T7PSWh7qK1kn9YJ6q9PL34GXeIgdLJq1rypsa6Du5HYlvLeum6GeMz7eevH ubMACD1GEn+mr+GTf3xFUjWrcuEbOohelvaUePPJAcmH97t5nuoy4H4vm4UJ0PZaipyvDC ajNoOBBeU0BArJRWDtS5KLNZeR6dnmC9TbSI/9yAJpJaGen/I0GfwKaW26oQqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669763896; a=rsa-sha256; cv=none; b=ogBtNlL3kR+XQkgx5ViGC3rkaq1DdxixoA/mnXQJLAWzLARCWeWXapcvUrqtMjwli2zDaw aCKi7q/s/Qsnqe3rYe1Hy4hbgW2uhhpB+cQ01rHGs3h/2suRS83tE2y/CdTSRfKiPoPItA cHf1bV8s28V+ZQGLYyUzzesi8eYL2JDj/pR8PCaezXJ2NfWYSgFsz4F6eBw/Nse40L2CwX MjpFTA8VtFB2E4Dta0yeeR2SzUeh3LTjgsnZ9H8gpi+4adIz/5aptcjNSakqVivODIG/y2 3q1+HnfVW8f6WrGLPlOhrDCRQFMRrMeiVzIc4GkXwYYF4KTabNeA5uwJpTZv4g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NMJD76ZzmzbHd; Tue, 29 Nov 2022 23:18:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2ATNIFig028649; Tue, 29 Nov 2022 23:18:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2ATNIFDm028648; Tue, 29 Nov 2022 23:18:15 GMT (envelope-from git) Date: Tue, 29 Nov 2022 23:18:15 GMT Message-Id: <202211292318.2ATNIFDm028648@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: 4ff214b2f271 - releng/12.4 - heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/12.4 X-Git-Reftype: branch X-Git-Commit: 4ff214b2f2719d001d6497c675b5a0e6776ece23 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/12.4 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=4ff214b2f2719d001d6497c675b5a0e6776ece23 commit 4ff214b2f2719d001d6497c675b5a0e6776ece23 Author: Cy Schubert AuthorDate: 2022-11-17 15:43:29 +0000 Commit: Gordon Tetlow CommitDate: 2022-11-29 23:17:39 +0000 heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 Part of ed549cb0c53f zeroed out a data structure in the resulting code-file when a TUTCTime type was freed. This part of the patch applies to Heimdal 7.1+ and not our Heimdal 1.5.2. PR: 267827 Reported by: Peter Much Tested by: Peter Much Approved by: so, re (implicit) Security: FreeBSD-EN-22:28.heimdal Fixes: ed549cb0c53f (cherry picked from commit f556a05c49261af3d373c599d05fa250f3563b59) (cherry picked from commit 5afe36c8b79547cda2bdd7297e5e2507a9135945) --- crypto/heimdal/lib/asn1/gen_free.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/crypto/heimdal/lib/asn1/gen_free.c b/crypto/heimdal/lib/asn1/gen_free.c index 74449fe6ca82..b9cae7533b17 100644 --- a/crypto/heimdal/lib/asn1/gen_free.c +++ b/crypto/heimdal/lib/asn1/gen_free.c @@ -61,13 +61,6 @@ free_type (const char *name, const Type *t, int preserve) case TNull: case TGeneralizedTime: case TUTCTime: - /* - * This doesn't do much, but it leaves zeros where garbage might - * otherwise have been found. Gets us closer to having the equivalent - * of a memset()-to-zero data structure after calling the free - * functions. - */ - fprintf(codefile, "*%s = 0;\n", name); break; case TBitString: if (ASN1_TAILQ_EMPTY(t->members))