From nobody Tue Nov 29 23:15:42 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NMJ9C0ZdXz4hpx1; Tue, 29 Nov 2022 23:15:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NMJ9B6XJbz3xNR; Tue, 29 Nov 2022 23:15:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669763742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JPHdXmJcMW6Z4B6BQrx//MMDvze+WWMlvmsecscsAKk=; b=WfwzxfkOzkNJNYqLhnMFL3gwaPc1nw2S+9qOuS5izchSi4H2hBkVlG6Ft9ECD8ZqLrR7mj Tw5o6WeDeE/Wz6qTBxhF8sELu4BinCoRBbdxtYxQlnZSuIF8lu6VVCmt6zEK08U0jIgmjV 0/opfENs03ZViCZ1ssbFtHgzMBmi208xBuxNMZtdRRtmtDj1tI9jixxFw8npOB/fmjUWMj b6fMpqNvubzrWjnEEec3gR8ToTgpdDjFOlavPkJGK7z1FspdYx8vPkUD/i8b6i/evuQqp6 O3kLsBF/tm38UB6UVyGn4097Sk8ZQ/x7Fi/FFAZ3NkLsPcLv/cPyfGu4THSqpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1669763742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JPHdXmJcMW6Z4B6BQrx//MMDvze+WWMlvmsecscsAKk=; b=GACzwqGZC2u8wCn7rDSL2RbB0nEJvQ83EuGbZbWYYdNeqd133CNgMg0Uy9kaB+HAfDzEfn ZvdcQtbJ5EthBFbX3+ZcxbRHErH4MLI26j3+kIikwfIGROV5YzZfrux6xD9rNZ1ShJp2xh 0gaxS+lRVjHv5ZanfHsFDJ6Wax98QtOdWltsfpneOvC1VTbpfPwOGcB8PaYyR3/EBk60rT mpCUZwoocoqe2mX2NdXoTTCYoV0J2pdPMDE45EMfa1TojXb2k1tY0zi1DBvxxq0NJiUkXk WclL1adrhh2L6cVrRaaeBFWJRW175EDsNArsyAA7uiaDL+i+QP65MIQDxzPgkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1669763742; a=rsa-sha256; cv=none; b=n/bQjtWbQ7LTc8m5YzBsjuiww/vOlek88DfiwJjZK7C3f2Yh/QgRen8o26Pvt5ZCUVYV1E Bxr6BL+lyfJLWDhENwXLbbV6hVYxAy4105iEjKG/AHsassYEpsRFilCvm75ET6MHPoM7yL 5J1DFGf2tzYLmAcoB6EHVqvHI/PbelWaxLqfHmQ3S59Zxee7MHHphyP+JBQYvqS3ps28Qa 3jgjGDdLeCUJJEmuR+bcNwjoM1OgzwvUtJkA64yAODSngKFqRzCm96Nf0TY8UDPyL1lZqm JinarDhNhY29ffaYK0xeXtL5kw7aYkfhIEtHRn6DvBRHvnEwnL9UAdLfBV8mag== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NMJ9B5dqQzZFG; Tue, 29 Nov 2022 23:15:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2ATNFg9V028052; Tue, 29 Nov 2022 23:15:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2ATNFgwF028051; Tue, 29 Nov 2022 23:15:42 GMT (envelope-from git) Date: Tue, 29 Nov 2022 23:15:42 GMT Message-Id: <202211292315.2ATNFgwF028051@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: 62b8c69d298c - releng/12.3 - heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/12.3 X-Git-Reftype: branch X-Git-Commit: 62b8c69d298c08bb443e9e27d26bd5b1ebcd7175 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/12.3 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=62b8c69d298c08bb443e9e27d26bd5b1ebcd7175 commit 62b8c69d298c08bb443e9e27d26bd5b1ebcd7175 Author: Cy Schubert AuthorDate: 2022-11-17 15:43:29 +0000 Commit: Gordon Tetlow CommitDate: 2022-11-29 23:04:04 +0000 heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 Part of ed549cb0c53f zeroed out a data structure in the resulting code-file when a TUTCTime type was freed. This part of the patch applies to Heimdal 7.1+ and not our Heimdal 1.5.2. PR: 267827 Reported by: Peter Much Tested by: Peter Much Approved by: so Security: FreeBSD-EN-22:28.heimdal Fixes: ed549cb0c53f (cherry picked from commit f556a05c49261af3d373c599d05fa250f3563b59) (cherry picked from commit 5afe36c8b79547cda2bdd7297e5e2507a9135945) --- crypto/heimdal/lib/asn1/gen_free.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/crypto/heimdal/lib/asn1/gen_free.c b/crypto/heimdal/lib/asn1/gen_free.c index 74449fe6ca82..b9cae7533b17 100644 --- a/crypto/heimdal/lib/asn1/gen_free.c +++ b/crypto/heimdal/lib/asn1/gen_free.c @@ -61,13 +61,6 @@ free_type (const char *name, const Type *t, int preserve) case TNull: case TGeneralizedTime: case TUTCTime: - /* - * This doesn't do much, but it leaves zeros where garbage might - * otherwise have been found. Gets us closer to having the equivalent - * of a memset()-to-zero data structure after calling the free - * functions. - */ - fprintf(codefile, "*%s = 0;\n", name); break; case TBitString: if (ASN1_TAILQ_EMPTY(t->members))