From nobody Fri Nov 18 01:11:10 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NCzHy6X3fz4hk6N; Fri, 18 Nov 2022 01:11:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NCzHy5zF3z3q6c; Fri, 18 Nov 2022 01:11:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668733870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B90IcQYF5ZljLpAsuitBoRZPR7cWvkWvL2mztqcNadM=; b=V2xjfaPCylwk/fd7n8WoQL2bWWBPQKvzF6p/c6xE1XDD2SX7pd2UA2w25wKiEc3NwELmUV QApOMgOi+3rG+AFMwmQrkDMSo4IAqZMuKtm1St4n8/9mLgjnLEu5DKBZweMOxiPO1/1G07 IprZ032ErO6idV7tlXPcKvmF4y7gGgcbmetS3UdiXZX8rtLRvDfrpWS2DW+brwvMeEKjah Um6jFgbeovEjd//Y+R0y6YkuEGOyHltir8Bv6avTn29pAfivPMKPuxRuAmsRsayRP+ibdr dU5N0eJGGdLzzkMlp0PyhEHndO67cIjzJQMIJwgVO8aHNFX3fTiwrpOHlvzt6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668733870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B90IcQYF5ZljLpAsuitBoRZPR7cWvkWvL2mztqcNadM=; b=s2pBZtZQiEuc3pTmad+DdkWObO7P8hpMIlgzIgJgwvSb2FC430SIxgV9I5vbaS5Caaij5o LndoVX+pYu+ZFKnriWYvs7/FXTgbrQJit6fWOYptxvuxmATXnsJmhfIsMDAg+O00epr7aE ax0B7up1gOPOU7GIAX+gA9AV2w6fSxrpNKQu4CBbYiweo39Xj9qtO3w91A23gBnn6V+MH6 DAFn328DKOQlfVHQKoH2mwAJGPQ27R+ZZbH2STj8+cCs1qhD39A//ET8txaK9GYQtCgzsK jIR6Pgv3eDUjIh69YFgckUkZ0XMibQdDwvObrvePFQeXNfBC/hHTYkeJu+mVMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668733870; a=rsa-sha256; cv=none; b=Dn0AwX/HKJ8YAJpLl4aCwWsRvZm4IdakTvjMDfMJvCKZr20eN8IDz1sE6LrMREvP2ftSI4 hMBO6omeZT6+8oxHJ7J8y6YIXxsFigEL/LYZBegsE3cJJuzc3WOarYHeUsTYOTbGnoPa6C lk+BN64GGyNi37Cnwr/QEkFgEg0nt7OL/59OQyu9glD1+1gGcyUQAaiblJlvnRy4w2MU4N 437r6yJR2LIGyWU0ZhYKqpnhTh1AYgSBxyq1WxxTqupfPThX84MblUCAYpWJkvikKGryu5 EEez5O+Is3uMMhWNRR05jNjY73wxZKT5ZFnTQUMBXHzIQZfylQnutv6Z73Fm9A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NCzHy4yVcz12W9; Fri, 18 Nov 2022 01:11:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AI1BAnU061681; Fri, 18 Nov 2022 01:11:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AI1BAOu061680; Fri, 18 Nov 2022 01:11:10 GMT (envelope-from git) Date: Fri, 18 Nov 2022 01:11:10 GMT Message-Id: <202211180111.2AI1BAOu061680@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 5afe36c8b795 - stable/12 - heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 5afe36c8b79547cda2bdd7297e5e2507a9135945 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=5afe36c8b79547cda2bdd7297e5e2507a9135945 commit 5afe36c8b79547cda2bdd7297e5e2507a9135945 Author: Cy Schubert AuthorDate: 2022-11-17 15:43:29 +0000 Commit: Cy Schubert CommitDate: 2022-11-18 01:10:53 +0000 heimdal: Fix: Too large time skew, client time 1970-01-01T01:00:00 Part of ed549cb0c53f zeroed out a data structure in the resulting code-file when a TUTCTime type was freed. This part of the patch applies to Heimdal 7.1+ and not our Heimdal 1.5.2. PR: 267827 Reported by: Peter Much Tested by: Peter Much Fixes: ed549cb0c53f (cherry picked from commit f556a05c49261af3d373c599d05fa250f3563b59) --- crypto/heimdal/lib/asn1/gen_free.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/crypto/heimdal/lib/asn1/gen_free.c b/crypto/heimdal/lib/asn1/gen_free.c index 74449fe6ca82..b9cae7533b17 100644 --- a/crypto/heimdal/lib/asn1/gen_free.c +++ b/crypto/heimdal/lib/asn1/gen_free.c @@ -61,13 +61,6 @@ free_type (const char *name, const Type *t, int preserve) case TNull: case TGeneralizedTime: case TUTCTime: - /* - * This doesn't do much, but it leaves zeros where garbage might - * otherwise have been found. Gets us closer to having the equivalent - * of a memset()-to-zero data structure after calling the free - * functions. - */ - fprintf(codefile, "*%s = 0;\n", name); break; case TBitString: if (ASN1_TAILQ_EMPTY(t->members))