From nobody Fri Jul 29 18:48:20 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lvc3T6tP6z4Y219; Fri, 29 Jul 2022 18:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lvc3S6DVTz3sVj; Fri, 29 Jul 2022 18:48:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7u+dsQ0t6U7HyBLAnJHOBHcFDFuNtI3Fo3SGbb91mvM=; b=F1dCKpJ5WR+yJDzhhxSrk/PdxVuYN4WF7umjjIb/8vywkGF3fwbDEO+29jn5B21k8xW6g6 L2Xgbm59gJV5V05X0MzW4H4dnirXz61uOfq6SVXfb1alO7M7WLNqUSZl12BTaUmJ2hVyxw gzRRvnFg0s3qYWVVPGEdHHN8OuNNpE3oRB3qXkBMViydLlHzxZPSpEwFwG9parJWoasxJi iFnLgVAxzctHuGWucmfuQfecbJJLd2f0D8I5WLnniB+/AkXIJLe6KT9RJPr0B1+lduIsRM UUrJaHruCkpEsni1VHjUsutnC2DLN8O/7nrCY71faMkQCD+rkw+ATx85cQ0r7A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lvc3S5FrZzlvn; Fri, 29 Jul 2022 18:48:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26TImKe5025250; Fri, 29 Jul 2022 18:48:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26TImKv5025249; Fri, 29 Jul 2022 18:48:20 GMT (envelope-from git) Date: Fri, 29 Jul 2022 18:48:20 GMT Message-Id: <202207291848.26TImKv5025249@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: a9aa00437bd8 - stable/12 - Adjust function definitions in if_pfsync.c to avoid clang 15 warnings List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: a9aa00437bd89b8d4e8d24afdd32f8553b5e38ed Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7u+dsQ0t6U7HyBLAnJHOBHcFDFuNtI3Fo3SGbb91mvM=; b=I2qZuvEpOpuj8HyVZi7PGp/FQeg19DhzS7/BgiC9V/Kw/NAWt1c4AeRLbVSRLHEYvOsEtK lpDwPM2xjTnEs0PhjpzZjMyWfv7yxQ75/0Iz6Jd7onaSr05D6cNlhvLhucx6S7OqxPXBuH 9FGQOQGqQs90P8mO2U8RaYd4wsj743SRzfrhBmvIbiOH1kr8ZSKpNfeDsO2olpsJkcwr4D cEaA4oHuQMG1mHltFkbTqVe4HPQ0vnTRjGvfJf7M3OfYJbgsIh2ei5AsoOTYC5DoACfqeQ 6vHJHTB2B83dXGwFn072D8fyfnWJ2mhmT4zuymfT0Iuv7Eu8GHoFTKxzXkCVBQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659120500; a=rsa-sha256; cv=none; b=NAqcg1whmG3wyacC6phXN2wN/l3dWpbJ9yL58ZcWIj4CIHuBnpdlssyclsWudSXg0ppQ+S +95jwoKIfZp0FPod+CKxiMdaWGko+z9vuOzJzSMqpIjq3voGId8GT172C/tKH2yYf2HS77 UYnll+he6vnMtpWMmSL2q6HIqYhAJb6OFWo1Uztw6vXwn2ZwbIvpEpnaxNi4qyZRkogzu3 mEKai4eOT19S25bHwnaaAG7NnEHhzDVKmgHoLbG52DE55TnvVpcjFXsAtQDdds6USRlkSz d+AaXPmm0rETlWNYMQEF9MokN5Gpg9EoI9nZNbYF42U/92P4LwehquGG2DjkNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=a9aa00437bd89b8d4e8d24afdd32f8553b5e38ed commit a9aa00437bd89b8d4e8d24afdd32f8553b5e38ed Author: Dimitry Andric AuthorDate: 2022-07-25 18:53:32 +0000 Commit: Dimitry Andric CommitDate: 2022-07-29 18:35:36 +0000 Adjust function definitions in if_pfsync.c to avoid clang 15 warnings With clang 15, the following -Werror warnings are produced: sys/netpfil/pf/if_pfsync.c:2439:21: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_pointers_init() ^ void sys/netpfil/pf/if_pfsync.c:2453:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_pointers_uninit() ^ void sys/netpfil/pf/if_pfsync.c:2503:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_init() ^ void sys/netpfil/pf/if_pfsync.c:2524:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_uninit() ^ void This is because pfsync_pointers_init(), pfsync_pointers_uninit(), pfsync_init(), and pfsync_uninit() are declared with (void) argument lists, but defined with empty argument lists. Make the definitions match the declarations. MFC after: 3 days (cherry picked from commit 766f3c8032a95f344823bea70bb7f794f9939d33) --- sys/netpfil/pf/if_pfsync.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index da1d17452cb0..88b85398db58 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2433,7 +2433,7 @@ static struct protosw in_pfsync_protosw = { #endif static void -pfsync_pointers_init() +pfsync_pointers_init(void) { PF_RULES_WLOCK(); @@ -2447,7 +2447,7 @@ pfsync_pointers_init() } static void -pfsync_pointers_uninit() +pfsync_pointers_uninit(void) { PF_RULES_WLOCK(); @@ -2497,7 +2497,7 @@ VNET_SYSUNINIT(vnet_pfsync_uninit, SI_SUB_PROTO_FIREWALL, SI_ORDER_FOURTH, vnet_pfsync_uninit, NULL); static int -pfsync_init() +pfsync_init(void) { #ifdef INET int error; @@ -2518,7 +2518,7 @@ pfsync_init() } static void -pfsync_uninit() +pfsync_uninit(void) { pfsync_detach_ifnet_ptr = NULL;