From nobody Fri Jul 29 18:47:50 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lvc2t4S4Lz4Y1tL; Fri, 29 Jul 2022 18:47:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lvc2t2TNmz3qNB; Fri, 29 Jul 2022 18:47:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CBMGKQZalM05VWqVUgL6c9uU5pfOzrLadaf+PpYzB6I=; b=tUUzWsLr7Nodc6k/rN7x/uW9oWBNsi6T53af47QKW99xjoOYfpfU/noHmQpCtdlgKEnsQq cmdeYTZE5JKxJ7Wr7PastHromnrADCKqit09H/cowoxDSkVRVoW6S7yVNNn5m4uERuteg1 ga80VDX9SxbosT34bOHNZ7gZqeVV9DJgG0wSwOrzI8eCGVDBaOWoJGbb9jw65itx6QztZl YvaRCmcHVxa+mretij06piptr/lVLVtDAz9uY8IAuYhK40daoJldsAoDh0cxqKHj1nWsdA XQ+4ITURIUaHDjelPzMiysi52wvX84d94ciXOucjpbaaZLqQLQUdNCO3zVVfKg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lvc2t1X5KzmB5; Fri, 29 Jul 2022 18:47:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26TIloAM024632; Fri, 29 Jul 2022 18:47:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26TIlouJ024631; Fri, 29 Jul 2022 18:47:50 GMT (envelope-from git) Date: Fri, 29 Jul 2022 18:47:50 GMT Message-Id: <202207291847.26TIlouJ024631@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: d0917822a28b - stable/13 - Fix unused variable warning in xen's blkfront.c List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d0917822a28b2f49a40d5145993c5870d8a056ca Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CBMGKQZalM05VWqVUgL6c9uU5pfOzrLadaf+PpYzB6I=; b=tRNuMFzjoFIyFAPsDWRpmMn9kmuc27FPpwUTiT0ZUvui5ZDHaJ+MJn0WqrGaWYH3tRrD/G YyDfGfKYoed6ZTD7Qei0irWEvcip9amPWdiXtjVsk1IOn5KdG62l1mugvkY8LD9VAmM7ZP kbT5MidD0w9Qaq+B4wHl5VImkMNm1/JzbCmNq2RzAZJiFktOuF+meYuQWuFZEyAON8d78n rEx2Mv8eVdo4qa6z/8LHi/9YRoKrUoikPbI53SRqojt8z6Ot/nBHFI32513UmjAM6jnHJ5 J7PKi/toRN9WM8YtX2+gItZ3GdmWdMATGoU8MWz+3QawjpTXRxhrDmiXGALEmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659120470; a=rsa-sha256; cv=none; b=wu02I7vQ6gT+mU6awUOyLXBPNEkQr2mkejU7WdhiBsIQAhkmBNMN/q7cQrGVxLuJ+i+8kp 6kryyIsFodCG7RjdtjX31kP/W95GO7H67NUfDKiYZ/i5o/v9ZiPbh3X2urypfUwgsmYOyt 3WdiweuTJoHZuUMfWdIG6MbG0rcnwL/VNZO8sD5VqZAqwqyoFSgtsC4dS1dhKX8UWIjitb B1UQWaFQDPSJoe78mKtcioPxlvlW4L4iPrX7nOALBzZf0g8+XU4DjVsen+tcm/WkA6ybgG 1OE2baHAuuPZdWok6HUF61NHhFmf4Ynwx2k92aUKulRAJI7GbpcOI2RuxBlm7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=d0917822a28b2f49a40d5145993c5870d8a056ca commit d0917822a28b2f49a40d5145993c5870d8a056ca Author: Dimitry Andric AuthorDate: 2022-07-26 12:01:26 +0000 Commit: Dimitry Andric CommitDate: 2022-07-29 18:32:08 +0000 Fix unused variable warning in xen's blkfront.c With clang 15, the following -Werror warning is produced: sys/dev/xen/blkfront/blkfront.c:602:6: error: variable 'sbp' set but not used [-Werror,-Wunused-but-set-variable] int sbp; ^ The 'sbp' variable was used in the for loop later in the xb_dump() function, but refactoring in e4808c4b2dba got rid of it. Remove the variable since it no longer serves any purpose. MFC after: 3 days (cherry picked from commit e635220e1a330560ee547069054d81c4cf0b7839) --- sys/dev/xen/blkfront/blkfront.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/xen/blkfront/blkfront.c b/sys/dev/xen/blkfront/blkfront.c index 6292dbaf7a1b..88f4f82b4bce 100644 --- a/sys/dev/xen/blkfront/blkfront.c +++ b/sys/dev/xen/blkfront/blkfront.c @@ -600,7 +600,6 @@ xbd_dump(void *arg, void *virtual, off_t offset, size_t length) struct xbd_softc *sc = dp->d_drv1; struct xbd_command *cm; size_t chunk; - int sbp; int rc = 0; if (length == 0) @@ -615,7 +614,7 @@ xbd_dump(void *arg, void *virtual, off_t offset, size_t length) mtx_lock(&sc->xbd_io_lock); /* Split the 64KB block as needed */ - for (sbp=0; length > 0; sbp++) { + while (length > 0) { cm = xbd_dequeue_cm(sc, XBD_Q_FREE); if (cm == NULL) { mtx_unlock(&sc->xbd_io_lock);