From nobody Wed Feb 16 18:33:38 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C63A919D08DE; Wed, 16 Feb 2022 18:33:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JzRRp4fDmz4qvf; Wed, 16 Feb 2022 18:33:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf36.google.com with SMTP id f19so3581438qvb.6; Wed, 16 Feb 2022 10:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=hmAS7ktkLIoN6eEUE89iTAA918sE0vedGYyc5vEmkeE=; b=Mfa2nbObD4/MzMVpsBq2gjoTcYpvEpbcSFcgeeNhru0emdjPGzuztM/tp+VtuAQiNm AJOdzHqK9gYE3gP/eHtJlYjBMBWT+F+koRgfzmIiMIchOspSbJu7AK6W8d/W7nKCsLCi 4PjQrARxCmzCCIiV7AH4s58+UqwCYuiiGRSypCah1XXvqsBihKJrYwvcV6UVuHzzeuoz bBh7lSB65gazEK3V9m9OZP+MrIf0yg/LXHVB9SQF2A7mg7WqfK1ATsw/Qdfe0vEUpsmq vv2lNXPL3NA0GQfuNdRjVlk13AkIeJxA81QllmnS4E/weFOLXOx55m+Ro3zlHz8p5/RX rmvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=hmAS7ktkLIoN6eEUE89iTAA918sE0vedGYyc5vEmkeE=; b=RYWc8wngcTkfgtcNS5Hsqcke4ajjixn7BO/fCKVwo5dEwjG6R+RwGUt3YLR2j6bSEo 8WxU+fe7ldwBjBl3xnWVG8Whj0LIhTwPH4MA+b3FXxo6GZN/wD+MuW22qjaev3W64AM9 VeqsIbtYzvRQxGqEK9wGtg4V5MOfWju4YxlAt+D99isw+ZQ6XdgFJzjetEdJCuyvkSW2 EhSDctZYE6vV8p3VMluLkFyROCd6J+bfXpIuFW8Tl/8R3Q5uKwzdWahDzf6atOe4sDo8 XGGY/Q1Kfnbk2fFszO0NYdmwQpLrK68qZEhPmoM05VoUe2AK/dzhdBxw221E3rvyTguy etcw== X-Gm-Message-State: AOAM533TiLXndAWnZbaqu5ZU/uvw12oCRd/AuLNhel9Llydqu31kR4Q+ 7lgEb6rwabmpXt7mjiph4jHUssk9wfk= X-Google-Smtp-Source: ABdhPJyYmhnjpT+CWCmUXSS9W+0T0If1AumBXtugyL1zdEXM+SyWxSmb5DjdqGFHNVQ/I47Qm0VuGw== X-Received: by 2002:a05:622a:15c4:b0:2d1:8efd:5cb3 with SMTP id d4-20020a05622a15c400b002d18efd5cb3mr3034350qty.530.1645036422144; Wed, 16 Feb 2022 10:33:42 -0800 (PST) Received: from nuc (198-84-189-58.cpe.teksavvy.com. [198.84.189.58]) by smtp.gmail.com with ESMTPSA id m22sm19691167qkn.35.2022.02.16.10.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 10:33:41 -0800 (PST) Date: Wed, 16 Feb 2022 13:33:38 -0500 From: Mark Johnston To: Helge Oldach Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 5fa005e91560 - stable/13 - exec: Reimplement stack address randomization Message-ID: References: <202202161759.21GHxF5W050008@gitrepo.freebsd.org> <202202161830.21GIUNIf004834@nuc.oldach.net> List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <202202161830.21GIUNIf004834@nuc.oldach.net> X-Rspamd-Queue-Id: 4JzRRp4fDmz4qvf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, Feb 16, 2022 at 07:30:23PM +0100, Helge Oldach wrote: > Mark Johnston wrote on Wed, 16 Feb 2022 18:59:15 +0100 (CET): > > The branch stable/13 has been updated by markj: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D5fa005e91560785dad5183db= 080209447afde3c2 > >=20 > > commit 5fa005e91560785dad5183db080209447afde3c2 > > Author: Mark Johnston > > AuthorDate: 2022-01-17 16:42:56 +0000 > > Commit: Mark Johnston > > CommitDate: 2022-02-16 16:55:03 +0000 > >=20 > > exec: Reimplement stack address randomization > > =20 >=20 > --- kern_exec.o --- > cc -target x86_64-unknown-freebsd13.0 --sysroot=3D/usr/obj/usr/src/amd64.= amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe -fno-str= ict-aliasing -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/in= clude -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS = -include opt_global.h -fno-common -fno-omit-frame-pointer -mno-omit-leaf= -frame-pointer -MD -MF.depend.kern_exec.o -MTkern_exec.o -fdebug-prefix-ma= p=3D./machine=3D/usr/src/sys/amd64/include -fdebug-prefix-map=3D./x86=3D/us= r/src/sys/x86/include -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -ms= oft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-p= rotector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmis= sing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__p= rintf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-opt= ion -Wno-unknown-pragmas -Wno-error=3Dtautological-compare -Wno-error=3Demp= ty-body -Wno-error=3Dparentheses-equality -Wno-error=3Dunused-function -Wno= -error=3Dpointer-sign -Wno-error=3Dshift-negative-value -Wno-address-of-pac= ked-member -Wno-error=3Dunused-but-set-variable -Wno-format-zero-length -= mno-aes -mno-avx -std=3Diso9899:1999 -Werror /usr/src/sys/kern/kern_exec.c > /usr/src/sys/kern/kern_exec.c:1197:9: error: returning 'void' from a func= tion with incompatible result type 'int' > return (sv->sv_onexec !=3D NULL ? sv->sv_onexec(p, imgp) : 0); Thanks, fixed now. I hit this when testing but failed to commit the fixups before pushing.