git: 9ea38ca4a8e6 - main - umass/quirk: Remove useless quirk for Transcend flash
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 16 Mar 2025 03:54:21 UTC
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=9ea38ca4a8e650a2eafa07cf0862553718b7f266 commit 9ea38ca4a8e650a2eafa07cf0862553718b7f266 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2025-03-16 03:47:44 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-03-16 03:47:44 +0000 umass/quirk: Remove useless quirk for Transcend flash I have several of these. They all work without these quirks (either the auto quirk mechanism does the right thing, or a likely soon-to-be-removed vendor catch-all does the right thing, or no probing at all does the right hting). Both PREVENT ALLOW and SYNCHRONIZE CACHE are (a) unimplemented but (b) return the proper asc/ascq code so da just does the right thing, quirk or no. This was a left-over from the days where you'd get scary error messages, but we'd work just fine. Now that the scary error messages are gone (and only a calm one under bootverbose), this can be deleted. Sponsored by: Netflix --- sys/dev/usb/quirk/usb_quirk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c index c0343f2b2ae0..653395bbdac9 100644 --- a/sys/dev/usb/quirk/usb_quirk.c +++ b/sys/dev/usb/quirk/usb_quirk.c @@ -214,8 +214,6 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS_MAX] = { UQ_MSC_FORCE_PROTO_SCSI), USB_QUIRK(ALCOR, UMCR_9361, UQ_MSC_FORCE_WIRE_BBB, UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_GETMAXLUN), - USB_QUIRK(ALCOR, TRANSCEND, UQ_MSC_NO_GETMAXLUN, UQ_MSC_NO_SYNC_CACHE, - UQ_MSC_NO_TEST_UNIT_READY), USB_QUIRK(APACER, HT202, UQ_MSC_NO_TEST_UNIT_READY, UQ_MSC_NO_SYNC_CACHE), USB_QUIRK(ASAHIOPTICAL, OPTIO230, UQ_MSC_FORCE_WIRE_BBB, UQ_MSC_FORCE_PROTO_SCSI, UQ_MSC_NO_INQUIRY),