git: 47f4137e44b8 - main - mana: remove redundant doorbell in mana_poll_rx_cq()
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 14 Mar 2025 05:51:52 UTC
The branch main has been updated by whu: URL: https://cgit.FreeBSD.org/src/commit/?id=47f4137e44b8079c7784604d220a298db07a19a1 commit 47f4137e44b8079c7784604d220a298db07a19a1 Author: Wei Hu <whu@FreeBSD.org> AuthorDate: 2025-03-14 05:26:45 +0000 Commit: Wei Hu <whu@FreeBSD.org> CommitDate: 2025-03-14 05:51:34 +0000 mana: remove redundant doorbell in mana_poll_rx_cq() With the last commit to refill the rx mbuf in batch, the doorbell in mana_poll_rx_cq() becomes redundant. Remove it to save a few microseconds spent in mmio call. Reported by: NetApp Reviewed by: Tallamraju, Sai Tested by: whu Fixes: 9b8701b8 ("mana: refill the rx mbuf in batch") MFC after: 3 days Sponsored by: Microsoft --- sys/dev/mana/mana_en.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/mana/mana_en.c b/sys/dev/mana/mana_en.c index 94cca4fa50c7..949b498ceadc 100644 --- a/sys/dev/mana/mana_en.c +++ b/sys/dev/mana/mana_en.c @@ -1890,13 +1890,6 @@ mana_poll_rx_cq(struct mana_cq *cq) mana_process_rx_cqe(cq->rxq, cq, &comp[i]); } - if (comp_read > 0) { - struct gdma_context *gc = - cq->rxq->gdma_rq->gdma_dev->gdma_context; - - mana_gd_wq_ring_doorbell(gc, cq->rxq->gdma_rq); - } - tcp_lro_flush_all(&cq->rxq->lro); }