From nobody Fri Jan 24 14:36:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YfgNS05KLz5lV42; Fri, 24 Jan 2025 14:36:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YfgNR5m4Rz3VJb; Fri, 24 Jan 2025 14:36:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737729367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4rBATG9HY5YGtYU7lCyuZfIfDXdkxhjjnhM+uQnoOkk=; b=QRaVS7JFq4UezlJ4BVxBE9FpF9a/tGvzTxlChNWdiYzGSq0HrmvaqH6A6sqkpoIJYAhESa M04fbEeu6E024EhR31gBk3/zX7Z4Y3JpR7KL4F9INRygmJvQSh+1q50uBuNnOD54Eb5WM3 FkN4wuxdF9HM3DsHG7co9LrRlwaxnx4ldD8wrDsJxPoGDz9b8tpR7fiMuFDaWGF1RoHqMI BEI84PVlE5LggJwO+esUWsgz4nslgmscxBOqAFkYRX0e/Be0LLeHE3cffpcDDw83sqRwby TDG+8rDR0tXhwqEhWFJ1wVoMk7H4Np90YTvpBA2kjwgq0S0QYwPE9hEa7THuMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737729367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4rBATG9HY5YGtYU7lCyuZfIfDXdkxhjjnhM+uQnoOkk=; b=uKo+zYxaj7B0qREoO11P4/c+65c0jjjmubxroM/wR9jPO9ZFy6ZaJwixj6K6Ma9u4C8lmD hhsHR8niKWOoE8lYcC343IwD901CQx6o5VGEhrLCZNUdIBj3RZ1LnB9nEq3bwGVW07o0+t xtkn0aEdV49CLgULxJkFbcBKou8eo4kwOlQyR4/bPRQ0wcwwYUFtC7EGQd6NVGxGUMShGD NOP++0T3ongRFnJIk50onEGXRAWqym+jcId/syNvZP518RTMwdF3+D18EZ2wbR8l4XnmM5 hGGDnRhFeOa0sL6LM46LgpZ1lr6NmkqToYH0xjh0mTC27hFvfTU5oiSlVJXeDQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737729367; a=rsa-sha256; cv=none; b=Y2WqZI4AMZQu9lDr1CG1IpX5/cnK6XXlbtYIPFJTtKVYsDCD+YMkBkaiT7y1DAErwyrTsM EsDAlqqS20Xwfy1sSiN7Q4Q/CHYPC+Sxwx3XNWhyIzMOzH++B/fnclFjzK/BsAL6BtvAm5 0JLk/5npJ/VKrwNEtskU8F6jMH3rxtbwocm4jUUTV9j2PtPBu0/a8ZgNkUvWtdNdumP7wI T9oY9I4ObkrgCFCnkQRbtAMfanXPX9f1VKQyXCs6Cn1EQDguhNyMcXSTDabHBncA6quNhS Zb6UsgtFs2NlCjsj544H4FECfbBEA3OlMn7lmQktRjniWMwwSXnTPu1t5pdoMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YfgNR5B2lzD9M; Fri, 24 Jan 2025 14:36:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50OEa7Zo006649; Fri, 24 Jan 2025 14:36:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50OEa7DC006646; Fri, 24 Jan 2025 14:36:07 GMT (envelope-from git) Date: Fri, 24 Jan 2025 14:36:07 GMT Message-Id: <202501241436.50OEa7DC006646@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 16369f33c5d9 - main - inpcb: Remove an incorrect assertion in in_pcblbgroup_find() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 16369f33c5d920c614d0778642364ee1213e6069 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=16369f33c5d920c614d0778642364ee1213e6069 commit 16369f33c5d920c614d0778642364ee1213e6069 Author: Mark Johnston AuthorDate: 2025-01-24 14:22:54 +0000 Commit: Mark Johnston CommitDate: 2025-01-24 14:22:54 +0000 inpcb: Remove an incorrect assertion in in_pcblbgroup_find() The inpcb might indeed not belong to a load-balancing group when passed from in_pcblbgroup_numa(). Reported by: syzbot+58bb60fe7a452df78835@syzkaller.appspotmail.com Fixes: 7cbb6b6e28db ("inpcb: Close some SO_REUSEPORT_LB races, part 2") --- sys/netinet/in_pcb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index c50e39f20c16..f9eac96acd5b 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -304,8 +304,6 @@ in_pcblbgroup_find(struct inpcb *inp) pcbinfo = inp->inp_pcbinfo; INP_HASH_LOCK_ASSERT(pcbinfo); - KASSERT((inp->inp_flags & INP_INLBGROUP) != 0, - ("inpcb %p is not in a load balance group", inp)); hdr = &pcbinfo->ipi_lbgrouphashbase[ INP_PCBPORTHASH(inp->inp_lport, pcbinfo->ipi_lbgrouphashmask)];