git: 40fc36ff2c1d - main - rtwn: fix RTL8192EU power-down / power-up hanging

The branch main has been updated by adrian:

URL: https://cgit.FreeBSD.org/src/commit/?id=40fc36ff2c1d14f8ea7237e8f9487ab2f25de86b

commit 40fc36ff2c1d14f8ea7237e8f9487ab2f25de86b
Author:     Adrian Chadd <adrian@FreeBSD.org>
AuthorDate: 2025-01-11 14:55:28 +0000
Commit:     Adrian Chadd <adrian@FreeBSD.org>
CommitDate: 2025-01-22 21:46:57 +0000

    rtwn: fix RTL8192EU power-down / power-up hanging
    
    The RTL8192EU NIC (on older USB 2/USB 3 ports, not on newer
    USB 3 ports, that still needs to be fixed!) will attach, scan,
    associate fine.  However, restarting wpa_supplicant results in the
    NIC hanging until you disconnect it.
    
    It turns out early in the power_on sequence - BUT only after a
    power_off - the NIC would suddenly stop responding to any USB
    transfers.  It doesn't require the MCU to be available for USB
    transfers - the hardware itself does that - so something had to be
    going very sideways.
    
    I traced it down to these steps during the power_off sequence.
    They don't exist in the Linux rtl8xxxu driver, and there are commits
    earlier in their RTL8192EU bring-up that suggest the author was
    facing similar power sequencing / re-sequencing issues.
    
    This likely won't fix the actual channel programming /
    power sequencing / deafness issues on later USB-3 ports.
    There are other commits / fixes in the rtl8xxxu driver related to
    RTL8192EU bring-up that we don't have.
    
    Differential Revision:   https://reviews.freebsd.org/D48428
    Obtained from:  Linux rtl8xxxu driver
---
 sys/dev/rtwn/rtl8192e/r92e_init.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys/dev/rtwn/rtl8192e/r92e_init.c b/sys/dev/rtwn/rtl8192e/r92e_init.c
index 925221bdabb1..077c64626f8c 100644
--- a/sys/dev/rtwn/rtl8192e/r92e_init.c
+++ b/sys/dev/rtwn/rtl8192e/r92e_init.c
@@ -368,6 +368,7 @@ r92e_power_off(struct rtwn_softc *sc)
 		return;
 	}
 
+#if 0
 	/* SOP option to disable BG/MB. */
 	rtwn_setbits_1_shift(sc, R92C_APS_FSMCO, 0xff,
 	   R92C_APS_FSMCO_SOP_RCK, 3);
@@ -377,12 +378,15 @@ r92e_power_off(struct rtwn_softc *sc)
 
 	/* Disable small LDO. */
 	rtwn_setbits_1(sc, R92C_SPS0_CTRL, 0x1, 0);
+#endif
 
 	/* Enable WL suspend. */
 	rtwn_setbits_1_shift(sc, R92C_APS_FSMCO, R92C_APS_FSMCO_AFSM_PCIE,
 	    R92C_APS_FSMCO_AFSM_HSUS, 1);
 
+#if 0
 	/* Enable SW LPS. */
 	rtwn_setbits_1_shift(sc, R92C_APS_FSMCO, 0,
 	    R92C_APS_FSMCO_APFM_RSM, 1);
+#endif
 }