From nobody Wed Jan 22 21:28:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ydcdh0rXdz5l5SH; Wed, 22 Jan 2025 21:28:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ydcdg6RWkz3Nyk; Wed, 22 Jan 2025 21:28:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737581335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AAA2ZFnbwi0PDHgulbtZBIetRBhX3+YWfo81yK9TUKQ=; b=wOMsDu+dFxpsCuW8yMeQk04GvNsaDinTFkqtdY7rzjHy93Obs4lcg+uVOSb7ZgfsVi0jRD Ngs7yo4tJJYULiT9pQaTd2yVY8mjDJw12tRzGbVIPIN1G7jo4JGOpTyxMluH7LrGi7tX73 SL3hxY9feJ73zytR9RfWd2pUQCxwxoXbXzGrz7VmE6V3FVsI/HsiTaAQK7vZDj4A5Y8Wk+ QkWZF6xtEWcOtLHFLjrxjuHOl2zHtCbthwcwUY5XbvhMkwaea4bUsqofkBGAxMnZmn/gRq Ht50vmE6WkD1oxsqVdtMgA3Ib7TVTqv4ZrVdOae1KYeGeh+fyldrpDhjJY6NTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737581335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AAA2ZFnbwi0PDHgulbtZBIetRBhX3+YWfo81yK9TUKQ=; b=igF9b0G57dBmvCiBDhQZU4AKyTmvPLyizLEFROkZVCgdw9iPaXsVG8LyKEJNDY03cxtYjd 1jWB6S1l7naPB7jzg5kvT9VAdUrdKuxRlHbNQ4ga4SgnEpc+0snm5O1IOl7/6jUET08DE9 SRyt+iEBf+lo4rtc/N83WyRpLrt8GGEjP8lT9JTtLE2iVUxBYgLIV5IE1aXeU1YvB+8qrc Q2vQdS3HguzWOPg8vhrQ8blmuUPC2oKHaEjUF/aR9gLmZrdCFUI4GV69B84+VOZn6a9J6o Y4ofQTtzxw8yKKXcGM3Kkc6c874vnwjtgJp+cng74xIsQzDS8ORhtrcmmxaGVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737581335; a=rsa-sha256; cv=none; b=msynHhjHeeTNI1GBgVyg0FMTDucW+70woLfgTYuytCBnT00+lSowgvBPeB0tI8QFgi4LzP jWJR0hmIO6fbRX1os5+L3vpE6WefzlrmfVEsss2nbcvM7UiUy6e6A1/oPQQ9OVqtB/OEd+ rkEqwlS0TZ9VwK+2zN4SILLiKiJY6UXvBgMA/ZaLIoKGgEsjnD/mDkttHUYSF/N460FIFa tMZgPaagKIW9unjK4Dzed34jrWJROUaKNpJPhe45nEoyP0DKpYJnizSNahKU7UsNuOaJJM Yq0QNKPqJevVMS46pcGtV4kWDA5IACav4Bu+lj8uY/R09jVJOTJqI3pDs0iK8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ydcdg5qr5z18D8; Wed, 22 Jan 2025 21:28:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50MLStuZ071722; Wed, 22 Jan 2025 21:28:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50MLStYV071719; Wed, 22 Jan 2025 21:28:55 GMT (envelope-from git) Date: Wed, 22 Jan 2025 21:28:55 GMT Message-Id: <202501222128.50MLStYV071719@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Renato Botelho Subject: git: 4cdfa4e8db56 - stable/14 - fwget: Simplify logic List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: garga X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4cdfa4e8db56460bf5b51974019bd26fdab5a9b4 Auto-Submitted: auto-generated The branch stable/14 has been updated by garga: URL: https://cgit.FreeBSD.org/src/commit/?id=4cdfa4e8db56460bf5b51974019bd26fdab5a9b4 commit 4cdfa4e8db56460bf5b51974019bd26fdab5a9b4 Author: Renato Botelho AuthorDate: 2025-01-09 14:24:18 +0000 Commit: Renato Botelho CommitDate: 2025-01-22 21:28:45 +0000 fwget: Simplify logic Summary: Use log() to print messages that should be supressed when -q is in use. No functional changes intended. Differential Revision: https://reviews.freebsd.org/D48393 Reviewed By: manu Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit fb98fc4755def2cb8ca145751b0e54485d5e2f4a) --- usr.sbin/fwget/fwget.sh | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh index d87cd03aa139..138a2a26bfb1 100755 --- a/usr.sbin/fwget/fwget.sh +++ b/usr.sbin/fwget/fwget.sh @@ -120,16 +120,12 @@ done case "${packages}" in ""|^[[:space:]]*$) - if [ "${QUIET}" != "y" ]; then - echo "No firmware packages to install." - fi + log "No firmware packages to install." exit 0 ;; esac -if [ "${QUIET}" != "y" ]; then - echo "Needed firmware packages: '${packages}'" -fi +log "Needed firmware packages: '${packages}'" if [ "${DRY_RUN}" = "y" ]; then if [ "${QUIET}" = "y" ]; then for pkg in ${packages}; do