From nobody Tue Jan 21 22:05:06 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yd1Tv1TW2z5lfZB; Tue, 21 Jan 2025 22:05:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yd1Tv0ZFbz43df; Tue, 21 Jan 2025 22:05:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737497107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3fP2omkemoH+HkM1zeLt1WndhGxcpZHGbhJXSo6xjas=; b=RtUvYVzWvb7a5z1B6kf9GvVYhQ0/FCpOy0+25Ln5nlg4ctQpLMQqJPxdBqEEXfkJb4fqln INCyGrdlfge7KxNauao3FyikNgkETf/Quyxe6WW/vc/NZrW/aoWm8Z45tD4pvisrR508kL be0cuiIOo/debH9yPBzFogeXgwJv65BeNvis6os+iDFxr2KJjiJHwNbS5pYIdDnd7CGi44 2LfoZlku6qVJWaw/cCqmGJ/garPknoU6YWdACRuumcDZ1fZapqT6UFzyVmCd4vDPpZ3jpj sGEYHVaw8ITYzHRMw1QwTELnnN6MyDi2OFxBcykZozFJfNBfhuOZ4NIzFdA3Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737497107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3fP2omkemoH+HkM1zeLt1WndhGxcpZHGbhJXSo6xjas=; b=JZtEht6S+FL+cyrSB5FWeoNmY+z6OWSdivH4re6Mg5V5dTyxxyH1uF4G+Jhj4dAE7003jK U657Zi3GS2wkW/m+KJC6c+7C/Onezrd6oyW05rifuLl9OPWiuU0hoJfX0ZHlRR/cljn3wZ z+44pTTjyrfx6npdzjchQb/jkkNq8gP2h1auQrfMloeI77Sd0hrxIj94nVopLfqJ51PaAW C6t2eap7NkhlEJFFpZlesg1w/n8M6WOytq/ov5ilzmQl1sDHb2jsDMlhs5OyjIkxaQPeKG o0fXoWnZ+K8b7WTC+exl+GU/rljd/V4evgoWpQxw4lCpyKQ0dKmJqLgy/Ta94w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737497107; a=rsa-sha256; cv=none; b=m/gcsAaKg6FIyiOw/GKZ2cOpYjaYpiEMhla2aNeYEoY4GJXOyh28fe2hwqvuQ/RMtGdxLt GT6A07hj/wk3vvsS7WIhbU3iIfqZrEEJEU/kIVPBnHKUM5+8JAE9tKnY5OCia6bn3CCvP7 5H8FzkLQ3vH3sGsMvzA2kxak0aT3W/2L4N1xjCmP8tt+zy+uCtCmvjphD+Xha4I1sAzrai zWxj0T5fJuUXS00jLUGUoIlprRZgHA5ZEwDTd1AJKP55wP6OuFSBJpoXFO+3cmHVQ109kn 7noKfsbI+Eja9+iov6p8v1TfyBjPqIUDNY7Zy4gwv5rJSgTkEPhYDPlHIANDoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yd1Tv07skz8sB; Tue, 21 Jan 2025 22:05:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50LM56RC046769; Tue, 21 Jan 2025 22:05:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50LM56Kj046766; Tue, 21 Jan 2025 22:05:06 GMT (envelope-from git) Date: Tue, 21 Jan 2025 22:05:06 GMT Message-Id: <202501212205.50LM56Kj046766@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 6d48eafa334f - main - checkstyle9.pl: don't require Signed-off-by for committers List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6d48eafa334f102009dbca9d191c6bbf52855551 Auto-Submitted: auto-generated The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=6d48eafa334f102009dbca9d191c6bbf52855551 commit 6d48eafa334f102009dbca9d191c6bbf52855551 Author: Brooks Davis AuthorDate: 2025-01-21 20:47:29 +0000 Commit: Brooks Davis CommitDate: 2025-01-21 22:02:56 +0000 checkstyle9.pl: don't require Signed-off-by for committers Silence the warning about Signed-off-by: lines if the Author: is using a FreeBSD.org address. We don't require the lines in direct FreeBSD commits so the warning is just noise in this case. Reviwed by: imp, emaste Pull Request: https://github.com/freebsd/freebsd-src/pull/1577 --- tools/build/checkstyle9.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index 50ff1e9bd680..5854cf613e01 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1254,6 +1254,7 @@ sub process { my $in_header_lines = $file ? 0 : 1; my $in_commit_log = 0; #Scanning lines before patch my $has_sob = 0; + my $author_is_committer = 0; my $non_utf8_charset = 0; our @report = (); @@ -1454,6 +1455,10 @@ sub process { ERROR("Real email adress is needed\n" . $herecurr); } + if ($line =~ /^Author: .*[a-z-0-9]\@freebsd\.org/i) { + $author_is_committer = 1 + } + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report. @@ -2654,7 +2659,7 @@ sub process { } - if ($has_sob == 0) { + if ($has_sob == 0 && $author_is_committer == 0) { WARN("Missing Signed-off-by: line"); }