From nobody Mon Jan 20 16:36:06 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcGDl0mmcz5kLKc; Mon, 20 Jan 2025 16:36:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcGDl015yz3Tmt; Mon, 20 Jan 2025 16:36:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737390967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8zJ7hJSkfS8Xdf8UgwvjlNdwd6KmmmqgRuBZ1JPF600=; b=BwWgNCtBeP/1sw9d5YgIUJbOEMEyVaW3f7mWWyd9VPKC9lTJ/CdhU9Ijq/+ss+HkgWeoIe ZWF8X6EwWRVGbQTHPOzV36uew7J4EXqeQKkXbleZfCVv2Rcev0D8K1YNd/bUDqxptRqsJA 1FPpFMYSiVh359hmBg9oAvizXLgBwn7obvXzJW6QzBgIKoBDNJ9fLX2DMpUoN7DRWU1R6N H9EvhLZ3CAj90NWWb8Vj/8Oe+kHWm32WeEoJBW3VhBMl453BcFnFBGPiA7pBdX71kXRrPu hvGmh0odyySQv0eZ469ZQrbqzFjBRLuk9TMz72prMaQTSc20xlj2XqP9LOlWpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737390967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8zJ7hJSkfS8Xdf8UgwvjlNdwd6KmmmqgRuBZ1JPF600=; b=bNSbrWEXvZCGeBNg5Uali/bOcmPwar9hxwDpMrsMKHYeEdZS3RNgRDRq2lt6rpR7M+oUP/ LC7Q6dcW9wRWJgIRXbr/fucunThFlSqNQBBHUrPiQYS6xFpyirESH57e5p+hiq2egRKOEp xZIu9JD91sol1Uz3UPbVAumMUqsF3gSHBbqygIWDLu48ZIno9zARr8x5Vy/37B671NFGUj ERZ2k+5BVcwDf2bmT6uYtJFtg/sMmrTIAITz5vQ9J0gRAyoO/n3n7DPjsT/ynZpITV9ghP IedZ5XCK4ajFBj7gcTRARFt0ByMIX9juRxW9tH1JeWsloSBdIfDIKqdPIy4DKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737390967; a=rsa-sha256; cv=none; b=GV0gToCk0UpBBmndePlgrbJFxUPNeSVJL213esPEmdZnkWshsOWnAgRiSPnYr52CrBqg88 it0nLCm/wlqfVCKevu3VWLGXY3+R5juI44bYbT6G2jyxbXQL4maiSqd/NSw0J/ne5d2iOY KLZOOMn99qgja5YuztqWmNfGXiUvRzpVx3GSBlM5Vf5nLw1KU4Jv+8r07iv5PfuzM0qy91 Oy2i9YnG2wx1gdaZqC+78acseaCVNsVmDdmdwtKPyovnUe33+5NhvYoKBz11X2FFEh6OX9 lph3MaQnN/ZtLOHvgRKkYsc7aiHfhA54gNP8sGvisul2qXHrubM3ctOyS0h9YA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcGDk6X4dzCgb; Mon, 20 Jan 2025 16:36:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50KGa6lZ031002; Mon, 20 Jan 2025 16:36:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50KGa6IN030999; Mon, 20 Jan 2025 16:36:06 GMT (envelope-from git) Date: Mon, 20 Jan 2025 16:36:06 GMT Message-Id: <202501201636.50KGa6IN030999@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: b797d07560a7 - stable/14 - fusefs: FUSE_NOTIFY_INVAL_* must busy the mountpoint List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b797d07560a76d790c0256a70d65b2b684ab6ee7 Auto-Submitted: auto-generated The branch stable/14 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=b797d07560a76d790c0256a70d65b2b684ab6ee7 commit b797d07560a76d790c0256a70d65b2b684ab6ee7 Author: Alan Somers AuthorDate: 2024-12-13 14:00:20 +0000 Commit: Alan Somers CommitDate: 2025-01-20 16:36:02 +0000 fusefs: FUSE_NOTIFY_INVAL_* must busy the mountpoint Unusually, the FUSE_NOTIFY_INVAL_INODE and FUSE_NOTIFY_INVAL_ENTRY messages are fully asynchronous. The server sends them to the kernel unsolicited. That means that unlike every other fuse message coming from the server, these two arrive to a potentially unbusied mountpoint. So they must explicitly busy it. Otherwise a page fault could result if the mountpoint were being unmounted. Reported by: JSML4ThWwBID69YC@protonmail.com (cherry picked from commit 989998529387b4d98dfaa6c499ad88b006f78de8) --- sys/fs/fuse/fuse_device.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/fs/fuse/fuse_device.c b/sys/fs/fuse/fuse_device.c index 5df9be59ce36..2fd43bc742dc 100644 --- a/sys/fs/fuse/fuse_device.c +++ b/sys/fs/fuse/fuse_device.c @@ -440,7 +440,6 @@ fuse_device_write(struct cdev *dev, struct uio *uio, int ioflag) err = devfs_get_cdevpriv((void **)&data); if (err != 0) return (err); - mp = data->mp; if (uio->uio_resid < sizeof(struct fuse_out_header)) { SDT_PROBE2(fusefs, , device, trace, 1, @@ -543,6 +542,13 @@ fuse_device_write(struct cdev *dev, struct uio *uio, int ioflag) } else if (ohead.unique == 0){ /* unique == 0 means asynchronous notification */ SDT_PROBE1(fusefs, , device, fuse_device_write_notify, &ohead); + mp = data->mp; + vfs_ref(mp); + err = vfs_busy(mp, 0); + vfs_rel(mp); + if (err) + return (err); + switch (ohead.error) { case FUSE_NOTIFY_INVAL_ENTRY: err = fuse_internal_invalidate_entry(mp, uio); @@ -567,6 +573,7 @@ fuse_device_write(struct cdev *dev, struct uio *uio, int ioflag) /* Not implemented */ err = ENOSYS; } + vfs_unbusy(mp); } else { /* no callback at all! */ SDT_PROBE1(fusefs, , device, fuse_device_write_missing_ticket,