From nobody Mon Jan 20 14:29:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcCQF2C7zz5lQ0s; Mon, 20 Jan 2025 14:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcCQF1k9Fz4B7k; Mon, 20 Jan 2025 14:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737383349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jOaT/dUWZo1h66DLcHsjMQqmlmv3cVUXLjiw6U4XBZs=; b=ONE1BkJKKZnCzyr692ZEWcDiXC5TAX/8ATmuBh1Xe9i5LzMt6r19wafH0rN1zQiqIL+37e r2mVf1j/6gwJY8E5Y46sO9ETqnF+t6s3rdYxPTFMx4QIk3uxR20PwyQAhDRa5a8J/liTSo /sWCKqRvL+zDsjI6dWao/seSVyI4QzSWXCWg48X7r67zX6b7ZYVX7GJKUCUv/5XGMSZ+f2 96DDRdIkDf9laQHePKgjjB4JxqFs7OzwfwEzk+/F/hd4iT31VgP5X5ragN9aoVueNJSEAD QYiD2Nw/F/w5iXUOt55t1EnRVTG/XG44zoRgkfOs+LwsLq0LKWaYQ7jOwb63+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737383349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jOaT/dUWZo1h66DLcHsjMQqmlmv3cVUXLjiw6U4XBZs=; b=JcnzdmfKaeUJkrOSVQtZnX83cXor4ByUC/AE/MqEyNkulg1sr2AWZ/3k4kYWHLputjZvbP MZ1zIpPw4qHTbNerbesImyLVkgwN9bfKj+ejrhOH1iXO5l5p6flAnNjAyGTLh7ZrnTH8oq FkxFB0CT6qJFmxSbFF0dA6EI77MPc78Wqkh/Nob3fE2osN1g2vUT6KNAoShZiOr4Feh8cj +Y4oJkUzhHzm21o65E9jUhMholGxgYyf2OeVe4mcWyySAiYDEKVa5w8LxDjHmzI0LfA1qM 9KIpJfqa2XYHDvx6MG2VpK/alnHklYhzE/u1QD4KBAZ28TtiI27NQ9p5j6vO7w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737383349; a=rsa-sha256; cv=none; b=ToypiurD0Q4EqQFOSCdLGf/f2tInGdzkt4XoBykiA4gk4E7dshauIyeI/QQ14cF2l96Qmo T6oA1DSOoLNQSeUtrgywfJXD9mTnBroNHu6WWHcZSffl+j7IJimyf/aibKc4JEntFss81c hR35hwEs3xX53X15OXeFcXjzH4/6rB26DLgbUbvYEsLOpdmehsy3mrYkhcfsHlK4ef3/Q3 4pZkM8jXrZE3ZYCadI2SDPipK6B7QRmAs5QLqghFe4FqyaepNBvuPsSFEtGCr6BtybXJuS 5ISC6egH4NjfDn5l2T0vMFFghoBK6c2DU12krFLMkrMDg2woVWEcWHEGtkvScg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcCQF1Bfgz7sy; Mon, 20 Jan 2025 14:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50KET9tW088113; Mon, 20 Jan 2025 14:29:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50KET92p088110; Mon, 20 Jan 2025 14:29:09 GMT (envelope-from git) Date: Mon, 20 Jan 2025 14:29:09 GMT Message-Id: <202501201429.50KET92p088110@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: d6fbd34acbbc - stable/13 - libbsnmptools: avoid uninitialized snmptoolctx->passwd with empty password List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d6fbd34acbbc90ae106fc1fa08d83d5f25d59039 Auto-Submitted: auto-generated The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=d6fbd34acbbc90ae106fc1fa08d83d5f25d59039 commit d6fbd34acbbc90ae106fc1fa08d83d5f25d59039 Author: Gleb Smirnoff AuthorDate: 2025-01-11 05:08:02 +0000 Commit: Ed Maste CommitDate: 2025-01-20 14:28:54 +0000 libbsnmptools: avoid uninitialized snmptoolctx->passwd with empty password The removed check left snmptoolctx->passwd pointer to uninitialized memory. Always calling strlcpy(3) would guarantee that with empty password it will point to empty string. Submitted by: markj PR: 283909 (cherry picked from commit 3999a860d6e899de98b1025317d2d0ef1f83255f) (cherry picked from commit 0bfbd30663b68a851ebf24667d121c6891c86827) --- usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c index 373e91de06d3..e1339877e945 100644 --- a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c +++ b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c @@ -178,8 +178,7 @@ snmptool_init(struct snmp_toolinfo *snmptoolctx) warn("malloc() failed"); return (-1); } - if (slen > 0) - strlcpy(snmptoolctx->passwd, str, slen + 1); + strlcpy(snmptoolctx->passwd, str, slen + 1); } return (0);