From nobody Mon Jan 20 14:26:53 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcCMd5vJvz5lPTM; Mon, 20 Jan 2025 14:26:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcCMd5PlTz49g3; Mon, 20 Jan 2025 14:26:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737383213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TsFhbBtDxAy97mjIw2FhdHhVgp02lrEurO9NqlwnXY0=; b=o/evr0ZueMWdOrkaZHy4QCTGvfRJL5rjGwAkS0D7h+mAWzvXqcSnRCZamYBemi1KBL5NQC yNo0gqp/1scuGyYGFspJBWK8WTnDDtvKmU9lRFuDppSyei27xD2Lr2VXH8q9iw79RwcnUZ yUXhTj+BOZAHyVW8bLQI6lgUlvEgdS3VtB4ggbqPwmwQKmRfCnJuvCjFVjiFLID7ra3HRD PZA4QBVquOO1blsTsDw91gdGjkKGLsNfMlUdhDZbX+YTV2ZsoSDvB6gjtzQxZhVkZqvR4N 18EdGwSVm/4wjmG5tZ6/Zly2gtbR6CRYjcrEOWhDcMOmZinosYLaIoyyNENp0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737383213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TsFhbBtDxAy97mjIw2FhdHhVgp02lrEurO9NqlwnXY0=; b=bzMassnbruv2V6eOmzU6wXuIQszpWO9DU9wLkLwtMnIm7G9KuQd9d6lvKvVStaulJZL1jX EBP3cG4jiRXP5dNPDwX7sUt6HmKBunmsscPAsoufJhThl3nL/r0jtdu8naTNmdmNu6vwv5 cLZcvwETK1c7LIiGSnxdNe5dXfwL6/0chBgVObVnPz/CPF5Fwkq+mKRFmygNf+5bBKRjbo eceea5oavZFLEDuAtAtRotLQH7q57pBW/5TNS0eDJIgVeXu1+PH8beXSkMOHYdPP2mazus WyUbaqq9fds1HzQyiDurKkCWiThAXaMOTFuPI4Z1nsLbLnv7t+SXA2zfWU+xlQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737383213; a=rsa-sha256; cv=none; b=w39ApYWHKK4sL9CfForw8jkm3beUYK5feTfYbtkTWCpzf9b66kaFPkDYE8klYwgsZpD/gC VRNA2j3nJsbJvNm2N9KtCUn8SKZLiCzDMPmp7UW3Ag5+mxel1BdN6EI6iWGxyNYhk+CUPN j5rXGfc9cmOyqxiUIyQYtaVrh9d4Eyf4Dlk/IEcoBxvbWreZ8JuZ4kDHeMPisQJL/IyIrs jrqZlk8qC5R3ZD9jUOiWQ/OmTqxZrl18tRjUu9Nvvdib0qzZ0AMyApoVaqo6ja07NfIKh1 E+AAi1onUGmGbSu093ehCwWxzHBB2NjscurZffSS3GiOF17PDvwdfxJVWPaUdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcCMd4jCnz8Hr; Mon, 20 Jan 2025 14:26:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50KEQrdU087299; Mon, 20 Jan 2025 14:26:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50KEQrab087296; Mon, 20 Jan 2025 14:26:53 GMT (envelope-from git) Date: Mon, 20 Jan 2025 14:26:53 GMT Message-Id: <202501201426.50KEQrab087296@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 61c50909354a - stable/14 - munmap.2: Unaligned addresses do not return error List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 61c50909354ace6f07d0b2113f10965f4546e0ed Auto-Submitted: auto-generated The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=61c50909354ace6f07d0b2113f10965f4546e0ed commit 61c50909354ace6f07d0b2113f10965f4546e0ed Author: Ed Maste AuthorDate: 2025-01-15 16:52:58 +0000 Commit: Ed Maste CommitDate: 2025-01-20 14:25:14 +0000 munmap.2: Unaligned addresses do not return error We previously claimed that non-page-aligned addresses would return EINVAL, but the address is in fact rounded down to the page boundary. Reported by: Harald Eilertsen Reviewed by: brooks Sponsored by: The FreeBSD Foundation Fixes: dabee6fecc67 ("kern_descrip.c: add fdshare()/fdcopy()") Differential Revision: https://reviews.freebsd.org/D48465 (cherry picked from commit 9e36aaf0c24cf158e83c69c1d2312c000c3c36f3) --- lib/libc/sys/munmap.2 | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/libc/sys/munmap.2 b/lib/libc/sys/munmap.2 index 8f5cb0c02e2b..cf8d9ec22b1c 100644 --- a/lib/libc/sys/munmap.2 +++ b/lib/libc/sys/munmap.2 @@ -25,9 +25,8 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.\" @(#)munmap.2 8.3 (Berkeley) 5/27/94 +.Dd January 15, 2025 .\" -.Dd June 22, 2017 .Dt MUNMAP 2 .Os .Sh NAME @@ -56,8 +55,6 @@ will fail if: .Bl -tag -width Er .It Bq Er EINVAL The -.Fa addr -argument was not page aligned, the .Fa len argument was zero or negative, or some part of the region being unmapped is outside the