From nobody Mon Jan 20 14:26:25 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcCM53ztDz5lPKp; Mon, 20 Jan 2025 14:26:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcCM53FpWz4869; Mon, 20 Jan 2025 14:26:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737383185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BKW1DVsD3v5fnfy+XI1uscpY5akLQb/ME/jlLYRleC0=; b=lZensxFlzWSEXz+WaxTvG9911XKOiRMjkoUwk5f5L8/KIqLqFZAann3wsaP08EA8P13B6B cY8yQpIHgULsPl4TAlEtXHRhEroJvGJtEZtF0GtUpDbBRdUZ7bc/9AG9sJ0jT1jLXvDJaK HXD1mqeKn+UqtmuFO7nwxBKq2w+WPjK/fYz3YmQsfz5IWFym8O0jy/vGlBhaY1dtUG4X2r RqY/COU4y0pi91I9FLVNRwrO0VeKrjdIXN5Vr1Feye0kz8qPZ3qxtPZuq2oIRePd33KI4y VoGT0GlZUpMD0iSZAbyAZc2d9+6LAW/bBjvCRDVzmNrtItHKoxTgHYfdQ0Eo5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737383185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BKW1DVsD3v5fnfy+XI1uscpY5akLQb/ME/jlLYRleC0=; b=U76BU/0joCJsxxLVMg2HnnPBEy9B9UohK12H4hCAbka7K2jxh8337e0cNAwAhUE43QP/w6 JSKJ7h1x6AnO9PXrpdBEw/4yKyst+NBlFKUynF/zve4f7fmrB8dXWZzSmLs3/pBiVsvcp6 2rWqSDvVn+OFGUaomee65SY1AlJNfHKo22z3w6DU48CLXX7oclUJAInQDrreJhHQMwbePT 3EvZ287S43kjvfj8090on1hNDiFAVrUKGLKro6YtJBk/1ONzq2hg3d0GhQKy6SbXxregNV KH1qjBk0nKIImM2TbQxJUKnG+2/hv4ro+dpFcPJdzimPeRR6vPpknabiqEoU2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737383185; a=rsa-sha256; cv=none; b=Secavvy7aCv82ZJE2Wfx63BJU6nCNWABfvjEH9lDVn1+vYi69nty7mC13K80+tdNrmHPRC pgKr0GirdhHVrgesp2jxi84/XVOZMSANvmcpH+YEDYKiWclyLeb6aAx95j/qSJnWhXnFHm Qta/deOOrAEllmj8UTRnBPpW7peyS3Wb3TLuLp80eN9lcfe3NqWShrxbNK7P22a1QqCvVi TfCy0laXXo7KZsatCyt5jfcxtzVC3ZkmIbD1+VpytmZqPIP+sCYHnEuSBjzod3hHsqEDfd Orx0nQ4L5YbWjmZU4YZx+D29ue4VChNQC4NTCreuNngSSYgM95HOB5KfpTUW/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcCM52VH5z7Jw; Mon, 20 Jan 2025 14:26:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50KEQPAi086989; Mon, 20 Jan 2025 14:26:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50KEQPHj086986; Mon, 20 Jan 2025 14:26:25 GMT (envelope-from git) Date: Mon, 20 Jan 2025 14:26:25 GMT Message-Id: <202501201426.50KEQPHj086986@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: c4cae8cbc337 - stable/14 - libbsnmp: avoid division by zero with empty password List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c4cae8cbc337eaf824774fcba88018e42fa31efa Auto-Submitted: auto-generated The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=c4cae8cbc337eaf824774fcba88018e42fa31efa commit c4cae8cbc337eaf824774fcba88018e42fa31efa Author: Gleb Smirnoff AuthorDate: 2025-01-11 05:08:02 +0000 Commit: Ed Maste CommitDate: 2025-01-20 14:25:14 +0000 libbsnmp: avoid division by zero with empty password PR: 283909 (cherry picked from commit 4dc1820a16b9b6108e0ff8a0265c08c67fa34146) --- contrib/bsnmp/lib/snmpclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/bsnmp/lib/snmpclient.c b/contrib/bsnmp/lib/snmpclient.c index ab3ac2d18e64..b312a37ed3ed 100644 --- a/contrib/bsnmp/lib/snmpclient.c +++ b/contrib/bsnmp/lib/snmpclient.c @@ -1792,7 +1792,7 @@ snmp_discover_engine(char *passwd) if (snmp_client.user.auth_proto == SNMP_AUTH_NOAUTH) return (0); - if (passwd == NULL || + if (passwd == NULL || strlen(passwd) == 0 || snmp_passwd_to_keys(&snmp_client.user, passwd) != SNMP_CODE_OK || snmp_get_local_keys(&snmp_client.user, snmp_client.engine.engine_id, snmp_client.engine.engine_len) != SNMP_CODE_OK)