From nobody Fri Jan 17 18:47:12 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YZTHP1H1dz5lK2v; Fri, 17 Jan 2025 18:47:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YZTHN6FLzz3m9X; Fri, 17 Jan 2025 18:47:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737139632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1DxIA9LOsHvuux7pJEpExhqhGta4dcAlzQ2gWCQwIGs=; b=DdXazGw4jgr3P+pzCf0QdYgOqFIO3Wh+DCFqjwg+pCYyng3xSi52IbTW6JjdhK10fzhDnY G/jZITkPPSgZjg3GanxTAvfQ1b72R59cEZo5xX45LCjaPD/6cq1Ew+aYn113pPkOAM4sU5 qyNzXFpqlGVu9jnCoFnQ9hghUI+nPb71KLYX5ZpGr+bdC8hHtJIdDnUd4D/9lpE14w8DeO L2Msd30IuKFU/aBlqVbW+q6lJ9DXF/l1MKwQUn2QRj/Fw4D9QHGwV/iFBqJfb++OLRIzCm pxitdlymlR5o7bzn9ncyxmpl5x6vCx76whBHXKmSWg/J4ibFpTr8lHY44xbolA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737139632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1DxIA9LOsHvuux7pJEpExhqhGta4dcAlzQ2gWCQwIGs=; b=a8a8dYYtM+VYBIJH1itIH3uRjodAupCgB9VhLtYEqrC+zoTGtVvocsaFFNSF5EL+ey9Or1 BONSskhJX97vcG2RCGBNAAdNHqdDEzxrOzJnnyLqtrUmmguy/JEa82+tu2evE9RPzs1AoH G/4NBR8mcUN8o31zqLHl8eUp1wV3z+2xra6RSD1bGVg24k42S1fKwyavEN7fNkFHnohK8M IjfPWTmi+ug0MT2vAw8ZQlRa/9t/w7Rp0JIHPF/e/SigisrJINVqapOoPHlA/Y3tFHMJlh bJ0LAaVwS1wZZAwnlotOGI7XxQdFN7HeAF0z7njGKzf00C055ZBRD+z7IuHlbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737139632; a=rsa-sha256; cv=none; b=tr0209whkYObOYs0moPvThfrBL1JZdk7jhhp5qI5ZNaCZkBKrLFh0JZ0MFuPo0R3rupySk ALDLvjI8mbVeuE7D/NfG0c/F7zOiTwJ28kvQnUsWJ0dOVaHuxMgp4+PoICk2f6dKHs1/DO wXT8HZxgadz3lZ+GwIF/vIaqcNb8ggsd5R+0mHZjaMlwrMPtONex1JuWB2v+VQcggsntCF cmIkGe/QoEZzPx0KYEnrOcQmg9q19uvd7VKV6Z0VynLl7tt5/mW069kOqr39Msj2kY1C+4 Izz/BXCQp7Sh+faqzHtZ1a/E644rCl5HOah3NVgx+3dpfcM4VIGheEBXaOChSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YZTHN5rq5zVVj; Fri, 17 Jan 2025 18:47:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50HIlCq6061378; Fri, 17 Jan 2025 18:47:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50HIlCwC061375; Fri, 17 Jan 2025 18:47:12 GMT (envelope-from git) Date: Fri, 17 Jan 2025 18:47:12 GMT Message-Id: <202501171847.50HIlCwC061375@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 550dede8754a - stable/13 - Fix "vrefact: wrong use count 0" with DRM List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 550dede8754a1ddbf3e44894b20cb74c48111ccf Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=550dede8754a1ddbf3e44894b20cb74c48111ccf commit 550dede8754a1ddbf3e44894b20cb74c48111ccf Author: Edward Tomasz Napierala AuthorDate: 2024-11-13 10:00:38 +0000 Commit: Mark Johnston CommitDate: 2025-01-17 18:47:03 +0000 Fix "vrefact: wrong use count 0" with DRM Bump the vnode use count, not its hold count. This fixes a panic triggered by fstatat(..., AT_EMPTY_PATH) on DRM device nodes, which happens to be what glxinfo(1) from Ubuntu Jammy is doing. PR: kern/274538 Reviewed By: kib (earlier version), olce Differential Revision: https://reviews.freebsd.org/D47391 (cherry picked from commit fc595a6b76642dfdfdb8e6f9b9bbc734e95fb59c) --- sys/compat/linuxkpi/common/src/linux_compat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_compat.c b/sys/compat/linuxkpi/common/src/linux_compat.c index 81127bf364f9..2697f02c0dd7 100644 --- a/sys/compat/linuxkpi/common/src/linux_compat.c +++ b/sys/compat/linuxkpi/common/src/linux_compat.c @@ -948,7 +948,7 @@ linux_dev_fdopen(struct cdev *dev, int fflags, struct thread *td, } /* hold on to the vnode - used for fstat() */ - vhold(filp->f_vnode); + vref(filp->f_vnode); /* release the file from devfs */ finit(file, filp->f_mode, DTYPE_DEV, filp, &linuxfileops); @@ -1680,7 +1680,7 @@ linux_file_close(struct file *file, struct thread *td) error = -OPW(file, td, release(filp->f_vnode, filp)); funsetown(&filp->f_sigio); if (filp->f_vnode != NULL) - vdrop(filp->f_vnode); + vrele(filp->f_vnode); linux_drop_fop(ldev); ldev = filp->f_cdev; if (ldev != NULL)