From nobody Fri Jan 17 12:27:19 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YZJs35rbfz5kvjl; Fri, 17 Jan 2025 12:27:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YZJs33zvLz3Tp0; Fri, 17 Jan 2025 12:27:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737116839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pVXQHPSortiMipANORbhnC8WdUTvMWM/IXrKWrkj+Ew=; b=YlPGj1FUgAuRxpuhORN6CPNO6VV5n9NyC5wr7lxJLnMugEQbxEPuP4IQbK51wUj9egRqkN CyhWc3RV+NUPoO0uwh9s/A5mAmD1G/rMCtv2L/idu3FBuzWP27a3jTOvuduBd0jSNuskog Kv30U3FMfvFdkLyc1BdX2TVtjKgjgf33O3lPESiJO43LL/tn5Y6mTr8GZ0D4vGUactoO0Q 3GOuTjnfv/S8oF68m5nejHRiLa6pMqFIefuiL5iRI5HWeia6QhVWTbd8ATHI7HeptNLfYf ChdCZs6c/KVdQOcTFUaJfIZticvJ3rt89iaBMBgbQF3UrVXgOdHjPtwpEoad5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737116839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pVXQHPSortiMipANORbhnC8WdUTvMWM/IXrKWrkj+Ew=; b=DrcF6msRkAdEzb/DLfvzZmYNqz3iuOQgY6KGiTWVQWyK/ruuwFWC1/sxSkSyGvf0x6/U8d owN6bBWcegQVVUPGJ5hxciCCCM08Wh7ThRycKV36T2CRaXuuqiJuycM6rYoi59Ll+0M2KB Y9MQMZ8s+lzDb7dsH55btAvRUvTGqno3Ie2trjitgLSQvGM33tC7T+sf5NIA+f/CPIlOFk M1AjYAxP0q0mRjMLp6J37c4wry6lrMExewL4BdwJe1gvkNeF4m5KCs2a4KZi2k1Uymrxpi OWP28x0V9GewAsNdtxH8ULSXIdSeKLvUYi2yDnuJOiKjHIq848Mzm5oVh/og7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737116839; a=rsa-sha256; cv=none; b=dxBX7nDu8nTBg5V387PYBKl1tD7T8YSF2ewGdTgBHH+ftI5jYEJ7RoB5B9qN6MccE8Y8sl tF2CE6U86S1Cv6WVX2hfPoYZqpWg0/jJ06EJY+g62hZ9pRyaYgXTTkE21ktHiEgqc1a9Kq 4V+NKzcFRig1oNnJBWCpcQl8YWv6+XLm/2A51h8a0XzXDZJ048xetK5U7nzwpTFBuZuGpf Y8PgQw1rhvojoxWNSZBtCjuFeCMc35QmycylPfRPvfUiagKUEecHNeI7SkYhh5w/UqFrGM SpMNNjZcbyCWr7N/E1qXk+ylLTkvQLzlYveK1YEbw6gMgtiVkr7hdblHns3YIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YZJs33SgHz2rb; Fri, 17 Jan 2025 12:27:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50HCRJ8g052737; Fri, 17 Jan 2025 12:27:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50HCRJGO052734; Fri, 17 Jan 2025 12:27:19 GMT (envelope-from git) Date: Fri, 17 Jan 2025 12:27:19 GMT Message-Id: <202501171227.50HCRJGO052734@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 5c09fafd8398 - stable/13 - cred: proc_set_cred(): Remove obsolete comments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 5c09fafd8398181a149c0457d56c5b7c2518b370 Auto-Submitted: auto-generated The branch stable/13 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=5c09fafd8398181a149c0457d56c5b7c2518b370 commit 5c09fafd8398181a149c0457d56c5b7c2518b370 Author: Olivier Certner AuthorDate: 2024-08-01 10:19:52 +0000 Commit: Olivier Certner CommitDate: 2025-01-17 12:24:53 +0000 cred: proc_set_cred(): Remove obsolete comments These have been obsoleted since they were first written (in commit "cred: add proc_set_cred helper", daf63fd2f9a8d040, r280130) by some subsequent commits ("proc: refactor clearing credentials into proc_unset_cred", 5a90435ccfed8e1e, r361448; "cred: distribute reference count per thread", 1724c563e62fa800, r361993). No functional change. Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46922 (cherry picked from commit 07c9edac7bcd75095724ff3c91d0aeec792a4f26) --- sys/kern/kern_prot.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 5fe587bdc421..755bdca4fd73 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -2278,11 +2278,6 @@ cru2xt(struct thread *td, struct xucred *xcr) * Change process credentials. * Callers are responsible for providing the reference for passed credentials * and for freeing old ones. - * - * Process has to be locked except when it does not have credentials (as it - * should not be visible just yet) or when newcred is NULL (as this can be - * only used when the process is about to be freed, at which point it should - * not be visible anymore). */ void proc_set_cred(struct proc *p, struct ucred *newcred)