From nobody Fri Jan 17 12:27:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YZJs11qFnz5kvd4; Fri, 17 Jan 2025 12:27:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YZJs01Hw6z3Tkk; Fri, 17 Jan 2025 12:27:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737116836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ntAFb1vNsJtgeCw92CIIqmKVX3vl33ZGQwZ7iPMAyL8=; b=SQqEsP3F0cS1A5KyNKDQGHo8tEEZTOkr0c6uCI1U2Jhm3m6/i7di+PqwF8UyAxWBU8k50w TxmyzQqNww25cnuW7VjvfELn1SNb+QurZ5iNCjIi4ptjBGvGNDq9dm5BNnSMzv+WMlsZ0S B+o/nMnQiyzOoyYi/5fiOUgOLJTJ4D7AmGjIWOENQ1jbSRpyRW4K0gJMXRPsyiAWm8jFvQ njxSidM+0mziyYXcjHjrz5aGsAJLkv+V9kqW5UX9MfWqoiY3B+A0fR34O10CGC9Fi1YAgS E7K9i3NO2HEXY19uMklxZFCeL5pkMw6/qZVSq0pMNc+7CEzw3S4WTyd7HW/O7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737116836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ntAFb1vNsJtgeCw92CIIqmKVX3vl33ZGQwZ7iPMAyL8=; b=hCmARPdTupe/vShSO0OU1H3v6qI+WZdmD3m2bY3e0SSFRnY7tCTgGNkFUbK2yvJYjU3mk1 150Y4s3lCsx/nNRgbLtY+CJMBIq7lUv8wxA/L2YjUygTc+F98r3zqzKY11MgZF3Sar5bX3 gMEgImP8VBIZ8YqUyfxROtA3wh2YQv7GYn1lfbsvTH1YnHiEvmbseHWTjwTI6gCz0S9Uym jwLaN2+YnDJ1JXlvhIM27+2keaezq7VlXOxi05CkyVHIks2zhOgB/gDuS7r5EZwOYtHq0u mCiS2quGE2dMSFM1W8rUke4LRa1s3D5roE6aPDxdn2vmELLGI8zySdwTrtOVmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737116836; a=rsa-sha256; cv=none; b=ruR3abxHu+WuCVKZIVTYco4yitORXUZT/P3f1RzIdO+Zpe+TK9Y0mKOetarkm4aWdeSJAf MzJ6zSJHRFyrWG2YRyd4c6JJR8B5+7jwkTBr1z2lYLooeqAXWwDjllhRDk3oQkJJPGAzH1 CIWco45zj+UVEwCXyAzhLMNDdOrDMZOWK9vInp/SEdPQhG7axAKH7ebV7as0segoLr9Nju AYLuIgJX2j9k8BRoKVo3OfcvKr1dSuisrrsfjLOgblF6AAoM+EwlKql+METMRuk1vg4SgG 90Hg2/8/40a9z3/eb3oOBNjBsSIeb9nT6CHALBzzArc7NSPtcc+LfQtFERWh8g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YZJs00sJ3z3Bd; Fri, 17 Jan 2025 12:27:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50HCRGhd052591; Fri, 17 Jan 2025 12:27:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50HCRGkn052588; Fri, 17 Jan 2025 12:27:16 GMT (envelope-from git) Date: Fri, 17 Jan 2025 12:27:16 GMT Message-Id: <202501171227.50HCRGkn052588@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 111c7322f71e - stable/13 - mountd(8): parsecred(): Remove comment on non-existent bug List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 111c7322f71ec653447fd79382ae75c6b11605cd Auto-Submitted: auto-generated The branch stable/13 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=111c7322f71ec653447fd79382ae75c6b11605cd commit 111c7322f71ec653447fd79382ae75c6b11605cd Author: Olivier Certner AuthorDate: 2024-10-08 09:44:06 +0000 Commit: Olivier Certner CommitDate: 2025-01-17 12:24:52 +0000 mountd(8): parsecred(): Remove comment on non-existent bug 'name' can never be NULL, as it is equal to 'names' and 'namelist', which was passed by do_cred() only if the actual parameter wasn't NULL. Reviewed by: rmacklem Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D47014 (cherry picked from commit 0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef) --- usr.sbin/mountd/mountd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c index cdf42de2fcdb..8ddedbb16f24 100644 --- a/usr.sbin/mountd/mountd.c +++ b/usr.sbin/mountd/mountd.c @@ -3591,7 +3591,6 @@ parsecred(char *namelist, struct expcred *cr) */ names = namelist; name = strsep_quote(&names, ":"); - /* Bug? name could be NULL here */ name_ul = strtoul(name, &end, 10); if (*end != '\0' || end == name) pw = getpwnam(name);