From nobody Thu Jan 16 18:08:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YYrT704rXz5kkq5; Thu, 16 Jan 2025 18:08:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YYrT64nSmz3Rdd; Thu, 16 Jan 2025 18:08:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737050906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OHmadE6YVBYhbQZPak0ioc4haq/k6JYZ0AK0oYUxHBs=; b=mp0/ItfM2UtcbZry1pIKVpta90KKjwTKaqpiqVM86jvWEu+ekGTHvfVPL05BCJnDvwROfW W1mqYYIDaK/MQ34Z71/6Lym+qGBcYMgbwsZJZEaP0nxeJSZKS1P8nCeOPKB+iPhfmPALPK K2gz3pGZ6pvPYmbRPKTX5Y02xutCRRTCdLF++lMFiUY5GmHeIkwQfXNni7rfyjxa3U76sR qX+cTPJdAtwWpJVozp/nHfbYVF3hubNcGUK/Tl9iNLSVK7jdWlRzhDwHJU5j0+Qp5W3BZd 1uxmY17Bu5l0sN3/xfSazjxLM5IGoPZ/rqiXnzb1k9307fJ87/cvUYARTovf5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737050906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OHmadE6YVBYhbQZPak0ioc4haq/k6JYZ0AK0oYUxHBs=; b=KAr6QZ2DVsX+nxmOv7FuhPJTm/bWHo9q2JerQcau5WVd1SBY5dA0vLuR6hsYizQhQkeJML NxlQWlfBt8jBOOCwJNmNVgur87hrxfGgobHpEUn0EmZFovHFcFR7g1WpLWBICN026r4aVn SJedtUyBOFeR5ztAvwo5TthnGRjV2HwTHoaIEPkXBe3Asstjuee5vRx6ZqWmo74YhpPCVQ B58sMqZzK7/g1G82VjVr7fex744BV6nvfHNyqAsRwtvTvysLPBt7GZrGxTZirajwSYmE5N N3w0x0z1zgSvciQyzEzvrjX8dOksDInZvrTodL/n+O5hGkhziLVF+8FYUyx0Nw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737050906; a=rsa-sha256; cv=none; b=FlrJHlxD+DJwymuKDmDz39Wv1REGbOe6nUhK1DD9G4oIz8Siut4UgoKsCAmJc2Nz6DIc7q Y51RTX0FeBhJ84bjf+XJ+0uTup1Q1Htmxy7XKzJE6Qc17KNMHQvI28yT62ZojTtR+RqfjW ozXcDraNWrikqMh8HGOrCCjwihkIkjFNWX7w9Zq7BQIbnKbdFJY9EDgjHZMEi1hiK/3hVh H7uqCkHG5MwN7FK1EJLvDdMV6qMfh8qo57jgRmiwxnNZfz26m/hgTMzpaqUUgbQRLY68dO ooxdZ60zzah5k3/ab4codhDfK4yCfXBy32O4Wy/3P4b+q3CAVis6ARbKwrYYcA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YYrT6455xzjs1; Thu, 16 Jan 2025 18:08:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50GI8QMX092338; Thu, 16 Jan 2025 18:08:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50GI8QOY092335; Thu, 16 Jan 2025 18:08:26 GMT (envelope-from git) Date: Thu, 16 Jan 2025 18:08:26 GMT Message-Id: <202501161808.50GI8QOY092335@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 42a885e6907c - stable/14 - mountd(8): parsecred(): Remove comment on non-existent bug List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 42a885e6907c44afd0d848c6f5c37f58f108e029 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=42a885e6907c44afd0d848c6f5c37f58f108e029 commit 42a885e6907c44afd0d848c6f5c37f58f108e029 Author: Olivier Certner AuthorDate: 2024-10-08 09:44:06 +0000 Commit: Olivier Certner CommitDate: 2025-01-16 18:06:58 +0000 mountd(8): parsecred(): Remove comment on non-existent bug 'name' can never be NULL, as it is equal to 'names' and 'namelist', which was passed by do_cred() only if the actual parameter wasn't NULL. Reviewed by: rmacklem Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D47014 (cherry picked from commit 0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef) --- usr.sbin/mountd/mountd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c index 55db501332bf..efc6e0ef6730 100644 --- a/usr.sbin/mountd/mountd.c +++ b/usr.sbin/mountd/mountd.c @@ -3634,7 +3634,6 @@ parsecred(char *namelist, struct expcred *cr) */ names = namelist; name = strsep_quote(&names, ":"); - /* Bug? name could be NULL here */ name_ul = strtoul(name, &end, 10); if (*end != '\0' || end == name) pw = getpwnam(name);