From nobody Thu Jan 16 09:18:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YYcjS64s7z5lQTy; Thu, 16 Jan 2025 09:18:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YYcjS5WBnz3msp; Thu, 16 Jan 2025 09:18:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737019100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eWOyjuYWZW1+dm23UQi8oj2yWOdweTyi2NDmEd71EiQ=; b=wWNVvTlSwZ7wBXKhTiG+0Xg4cW48IoTtwh3Ik80M/VcH/GAcKPpQbx2EKu4bie69NCjz9P icAiLe5yPqXKks9ahjgOXTj4syYyl0zQl3bttbRQqlSRj0Li4qwPA65M97kRHevNd9mOpx PQEW2c0wU1aPYsaD19yN1BnfdpA3XIT9u/JsXNZ3wIWV8HWl7HBJM+G6Mn81o/cU2Ks9Fj ZsIE2rs+6j4ZLjSBYZNhr1W927UnBwQOkVZdt7rrdm+epnI8+ISo3teO/v2bwU3r9UogGa LnCv6B9OedB2f3N0VqMCG7bZ9P6zhuJKFO3EYVIGiiyv+XGr6AAgJT8zha7Rbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737019100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eWOyjuYWZW1+dm23UQi8oj2yWOdweTyi2NDmEd71EiQ=; b=NpkVH3bPwyE+TKz3W+aJGxAd3GajRx3emKvqnwt44X5IB61RDcY0vZLm+Iz33RJUxN6Zhd I/E2+na6gFNFS4qS2VN3DKIGS+VXkPOr0mJGWuGGUm5yCUDoj12YGibLRl2fBWnz/zpUqw c2VEVAROv4wrVrO5A88Z2koi9w70ULF+WZg4pdHfncKjTRV/yPjFdXCPUKC2hhRUXkqUyS zqVHbEK8wWtLoMz0frv5oA22xSL2S2IQQMkxcS1qkrjX+QpyVMw83Q6QZl+yf0crredCId AKDCKJoE4iHK1XDmozGdQH4ccx/5fWLDCLeOcKtI27+HTqazSMpFb3iEIJ6dCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737019100; a=rsa-sha256; cv=none; b=F6lGsp34Rqrlz+DCteslXCYeN3negtx0v4MfqOA6pBv0+nbWYRKBgWNc5Rd9jps9XDwUJR fsd3z6WwUFtab0V9FSponLzEmk+Qy+PILAhBBrNWQ/FP4/bflWOVXTTdMbr7EtViU//R76 9uXl+64OLNO9HG3D51JmP0SS4sAdaesTtLshWZvcE9Yv42dCxFjxiSa7Ej5JCUguh5qWTb VFYlMMuQLSILw6YsT3NIHqw4orkirYZDAQyOHtpqFGam9fzX1NFwxeH71y8sMFq/c127rP kGpTJ/ero6Z13wGLA9GcvzVezTeAP5VkEW9kMb2ZUNxLbc0xRg3lz+f4qzcSyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YYcjS538MzB7B; Thu, 16 Jan 2025 09:18:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50G9IKqA096020; Thu, 16 Jan 2025 09:18:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50G9IKdh096017; Thu, 16 Jan 2025 09:18:20 GMT (envelope-from git) Date: Thu, 16 Jan 2025 09:18:20 GMT Message-Id: <202501160918.50G9IKdh096017@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Baptiste Daroussin Subject: git: 16dee1cc652b - stable/14 - bintrans(1): qp switch to getopt_long List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 16dee1cc652b21bb4d03fc24cec259861647a8d5 Auto-Submitted: auto-generated The branch stable/14 has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=16dee1cc652b21bb4d03fc24cec259861647a8d5 commit 16dee1cc652b21bb4d03fc24cec259861647a8d5 Author: Baptiste Daroussin AuthorDate: 2025-01-08 11:13:54 +0000 Commit: Baptiste Daroussin CommitDate: 2025-01-16 09:18:14 +0000 bintrans(1): qp switch to getopt_long In preparation for more arguments, switch bintrans qp argument parsing to getopt_long, while here make the decodign argument being -d|--decode for compatibility with base64 encoding/decoding MFC After: 1 week Reviewed by: pstef Differential Revision: https://reviews.freebsd.org/D48380 (cherry picked from commit a8d9bd3fa5855fe7583ed05946296ab6b9937d69) --- usr.bin/bintrans/bintrans.1 | 4 +-- usr.bin/bintrans/qp.c | 61 +++++++++++++++++++++++++-------------------- 2 files changed, 36 insertions(+), 29 deletions(-) diff --git a/usr.bin/bintrans/bintrans.1 b/usr.bin/bintrans/bintrans.1 index 3376ecd332ed..4177a5c6b9eb 100644 --- a/usr.bin/bintrans/bintrans.1 +++ b/usr.bin/bintrans/bintrans.1 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd January 23, 2024 +.Dd January 8, 2025 .Dt BINTRANS 1 .Os .Sh NAME @@ -230,7 +230,7 @@ through a dedicated program: is a quoted-printable converter and accepts the following options: .Bl -tag -width indent -.It Fl u +.It Fl d Decode. .It Fl o Ar output_file Output to diff --git a/usr.bin/bintrans/qp.c b/usr.bin/bintrans/qp.c index c2c9dfa7a224..3bff47945acf 100644 --- a/usr.bin/bintrans/qp.c +++ b/usr.bin/bintrans/qp.c @@ -26,6 +26,7 @@ */ #include +#include #include #include #include @@ -151,44 +152,50 @@ static void usage(void) { fprintf(stderr, - "usage: bintrans qp [-u] [-o outputfile] [file name]\n"); + "usage: bintrans qp [-d] [-o outputfile] [file name]\n"); } int main_quotedprintable(int argc, char *argv[]) { - int i; + int ch; bool encode = true; FILE *fp = stdin; FILE *fpo = stdout; - for (i = 1; i < argc; ++i) { - if (argv[i][0] == '-') { - switch (argv[i][1]) { - case 'o': - if (++i >= argc) { - fprintf(stderr, "qp: -o requires a file name.\n"); - exit(EXIT_FAILURE); - } - fpo = fopen(argv[i], "w"); - if (fpo == NULL) { - perror(argv[i]); - exit(EXIT_FAILURE); - } - break; - case 'u': - encode = false; - break; - default: - usage(); - exit(EXIT_FAILURE); - } - } else { - fp = fopen(argv[i], "r"); - if (fp == NULL) { - perror(argv[i]); + static const struct option opts[] = + { + { "decode", no_argument, NULL, 'd'}, + { "output", required_argument, NULL, 'o'}, + {NULL, no_argument, NULL, 0} + }; + + while ((ch = getopt_long(argc, argv, "do:u", opts, NULL)) != -1) { + switch(ch) { + case 'o': + fpo = fopen(optarg, "w"); + if (fpo == NULL) { + perror(optarg); exit(EXIT_FAILURE); } + break; + case 'u': + /* FALLTHROUGH for backward compatibility */ + case 'd': + encode = false; + break; + default: + usage(); + exit(EXIT_FAILURE); + } + }; + argc -= optind; + argv += optind; + if (argc > 0) { + fp = fopen(argv[0], "r"); + if (fp == NULL) { + perror(argv[0]); + exit(EXIT_FAILURE); } } qp(fp, fpo, encode);