From nobody Thu Jan 16 07:30:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YYZJr47Fdz5lJv0; Thu, 16 Jan 2025 07:30:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YYZJr3VN5z3bmx; Thu, 16 Jan 2025 07:30:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737012620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qlK1G+6F1FNsv3RzKWSmKvSYKzyU6UFwmuSu+Wgoexc=; b=tCfYKDc1JRW436dWNVZ8KPlw2GnIN4jiZ31p9tzYNHuGG6HYO1/MNOFs9THQWDFxxJH9LT GIAFe5B7t3gEs3FhucaXh4SDXAAkIZPd9pfFK14fEFfRtB4Y2ZqwGshMS+GyxIAMgoDsvk baGQ4en2eOq8iCV+iHLgNdakdfl4xqe0ndc10h/rSbzHIVjnqzxDfaCXWkZcdCvU5wocuQ dckL17gLWvpAkGjWf0bolzok+5hx6dA7Fi/rxNk3hjUNzCb+NkXHz3dBsTGrJ+bkJhe15s UPdBYKkdgTkFiFvAKc9rcnZS7y1seghrI3kVaMu37TAy+zk3CKXAYX+7Crauyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737012620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qlK1G+6F1FNsv3RzKWSmKvSYKzyU6UFwmuSu+Wgoexc=; b=J2w9je+ZaOHR2p0+M1RDqUpzX/oMWNLam/x+rGyG/+18/lHqQXhjKIXN+yiHIEIIajOhLb AUFJPbK2d+ECZ1CNnlPCdsnDHWeDm2kpIQIuPkH9xAb6UBGZRjsuA4VhW9LSKybZI9ZSG5 vtGm9aJ1lqEzJxFZtBKrPe/rtYE+v6h5+3W8GDVH/BjOlhBRi6eqHMJDCG1ShkjygohiMW PPAGIH6WPwEwnpJh3R/wJaNS80PTGkJN+YFD99FuzDP0NMU2XfWQBIjDIt0eDan3Osmns6 fzHbHlPVJQSOtqhEDgVu+p6HGVtQbMBxa1qDMlj2RzkpO40sNWIaK4Y3nI6o+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737012620; a=rsa-sha256; cv=none; b=WKLdBR7MIyR9lcsWRrS2zLwdlZIFPKyMeNpij6amsGC0sJ6yC7Yqy+hria4xrujqFhhtsU /XxhcafnFBzbPhhXd8mfS8ekJhoZojThcUxKhNLFjZYBVIPuMVZvYVZA2qw9Zp7TkRAcSe oiViSnyKqspZjz4zzmDP+mXsRsTTdeJW6SuitwNxtKfYwn8veABJ3v7VZtWabMkgNLAPeI vNaBu6q+15KCWHaKcyO5JBsEubk9khwqvsxr1/4JKrzrp5VU9mM1nNQOB/Pad9eayyruTP VapjKp/GFCgJRcJogPYHg7WHgYV/1k1G5QrZEIvMYzbSLPmlDc0qpJZKKLqiRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YYZJr30fNz70Q; Thu, 16 Jan 2025 07:30:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50G7UKcG098632; Thu, 16 Jan 2025 07:30:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50G7UKLI098629; Thu, 16 Jan 2025 07:30:20 GMT (envelope-from git) Date: Thu, 16 Jan 2025 07:30:20 GMT Message-Id: <202501160730.50G7UKLI098629@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: c3df2fa9a755 - main - netlink: snl_create_msg_request() may fail due to ENOMEM List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c3df2fa9a7554e00f34f1cbcf8be6c8ccf9ccd8a Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c3df2fa9a7554e00f34f1cbcf8be6c8ccf9ccd8a commit c3df2fa9a7554e00f34f1cbcf8be6c8ccf9ccd8a Author: Gleb Smirnoff AuthorDate: 2025-01-16 02:50:29 +0000 Commit: Gleb Smirnoff CommitDate: 2025-01-16 07:21:58 +0000 netlink: snl_create_msg_request() may fail due to ENOMEM --- sys/netlink/netlink_snl.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/netlink/netlink_snl.h b/sys/netlink/netlink_snl.h index 2861ea93bafb..d10852ac7a36 100644 --- a/sys/netlink/netlink_snl.h +++ b/sys/netlink/netlink_snl.h @@ -1261,9 +1261,13 @@ snl_end_attr_nested(const struct snl_writer *nw, int off) static inline struct nlmsghdr * snl_create_msg_request(struct snl_writer *nw, int nlmsg_type) { + struct nlmsghdr *hdr; + assert(nw->hdr == NULL); - struct nlmsghdr *hdr = snl_reserve_msg_object(nw, struct nlmsghdr); + if (__predict_false((hdr = + snl_reserve_msg_object(nw, struct nlmsghdr)) == NULL)) + return (NULL); hdr->nlmsg_type = nlmsg_type; hdr->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; nw->hdr = hdr;