From nobody Tue Jan 14 22:12:06 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YXjzC0h6Lz5kVbj; Tue, 14 Jan 2025 22:12:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YXjzC02Ctz3H3c; Tue, 14 Jan 2025 22:12:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736892727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IDNesE/SXtE7wt1LjIPGK7XuEd25NBEgDkOWRSf3v/o=; b=bHnbAQr8YYrB1hxGIWXtu8G3G1O6H7kuE/aGJh0Vc+fm3yEcpzDpcekSUUu7NB/xW8oaSm 05GtNUGrNCVn0h/oct27ep1s6bm0OLVMhAF2IREDBHPgzsfUiNBYGb6XG+gTn+fYRV/ImH PY9PY5RMpYW0RqEc3QKXtLRUIKFi/XA5S+d3vnEdoMR2yGjw/D+a5M/t9CI6qO2TT0Eop/ Me3nSBDbWd7CYYeMjYS4DBbF5d5OW57B2S8CQ+DU/A3hedEoSzHRP/UMsUdamcZu4H8UCR gnNT6oJndI9Nw1MGhP7vAvuRv4D7hv7P4tWMb8+SOTwbp6ETpqoshZxkfsVydQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736892727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IDNesE/SXtE7wt1LjIPGK7XuEd25NBEgDkOWRSf3v/o=; b=WWZxpsQEP7Ni5//736w+UFrirlKxAFZ56MLzJVt992vOD69dnjCvhXX1jyGbcP8pKylcmA UE5RwQqPPeBu6SvUF9/YCoR1LA0wj2yHr3Od2sxp8qRO7WZgQLXIz7QZJ69cW8XSg7cAi3 apWjtlrkOE7xNZ5Aju+MAAVuePhNTI83D9584PvlKrO4LCPAExnDQ6mQje19ma29WL0jQ7 7EETzI/x3A/cgZxs+vwkcGi3evbNhRYkicNMdOMsFogCJ3dYTlrtqSXi5KPb7iChKtWJmM /i3N8Fiv45b3Yl+uD02OB7gjl5/U1blD8wb0iMLQQwRWKvYuokZ6LSNGLwWmFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736892727; a=rsa-sha256; cv=none; b=X5pk5PJp9qCSXh1wOK9dcIpP8PicFn8hKXfrm0DlsxqO6C0p/kgq71rw6QLhGGYwAi4OSi lMTLNYW5HrxMvVA1fJgCQSs+wgH8RXvi6/rsZhMn80T1JaNRsaYTCxa0izTo3AwzL9CExu d5+0jDgQSfi1aFRCsdvUuM1hcytH1584dlsrO7v85Gbso/BqsyWpIm74Yx2XByu9uKUkbT SIn/Sxgt6XZxsBIENToghIGgLIRx2ay/Rb9ECEhRRnLpwM5gRX9bdSBKWw3ceuI9vLXIjz e5im4Wqtg8p1bYF8XcvDjNmSjS3ahrkyu3Gl5ySXDOZsnZnRUaMIHAKYn7ynXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YXjzB6W88z4Lq; Tue, 14 Jan 2025 22:12:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50EMC6QN057760; Tue, 14 Jan 2025 22:12:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50EMC6n3057757; Tue, 14 Jan 2025 22:12:06 GMT (envelope-from git) Date: Tue, 14 Jan 2025 22:12:06 GMT Message-Id: <202501142212.50EMC6n3057757@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 1cd455f39d88 - main - fs: Add new VFCF_xxx flags for va_filerev List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1cd455f39d886f27c33f7726f79fc4cc566da7b3 Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=1cd455f39d886f27c33f7726f79fc4cc566da7b3 commit 1cd455f39d886f27c33f7726f79fc4cc566da7b3 Author: Rick Macklem AuthorDate: 2025-01-14 22:11:06 +0000 Commit: Rick Macklem CommitDate: 2025-01-14 22:11:06 +0000 fs: Add new VFCF_xxx flags for va_filerev Richard Kojedzinszky reported a problem via email, where the Linux NFSv4.2 client did not detect a change in a directory on a FreeBSD NFSv4.2 server. Adding support for the NFSv4.2 change_attr_type attribute seems to have fixed the problem. This requires that the server file system indicate if it increments va_filerev by one, since that file attribute is used for the NFSv4.2 change attribute. Fuse requires an indication that va_filerev is based on ctime. This patch adds VFCF_FILEREVINC and VFCF_FILEREVCT to indicate this. A future patch to the NFS server will use these flags. Reviewed by: asomers, kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D48436 --- sys/sys/mount.h | 2 ++ sys/ufs/ffs/ffs_vfsops.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/sys/mount.h b/sys/sys/mount.h index ac84c99ac74b..6715c55d7a6d 100644 --- a/sys/sys/mount.h +++ b/sys/sys/mount.h @@ -685,6 +685,8 @@ struct ovfsconf { #define VFCF_SBDRY 0x01000000 /* Stop at Boundary: defer stop requests to kernel->user (AST) transition */ #define VFCF_FILEMOUNT 0x02000000 /* allow mounting files */ +#define VFCF_FILEREVINC 0x04000000 /* va_filerev is incr. by one */ +#define VFCF_FILEREVCT 0x08000000 /* va_filerev is set to ctime */ typedef uint32_t fsctlop_t; diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c index 2bfee6a6145d..9e94d368d7c9 100644 --- a/sys/ufs/ffs/ffs_vfsops.c +++ b/sys/ufs/ffs/ffs_vfsops.c @@ -117,7 +117,7 @@ static struct vfsops ufs_vfsops = { .vfs_susp_clean = process_deferred_inactive, }; -VFS_SET(ufs_vfsops, ufs, 0); +VFS_SET(ufs_vfsops, ufs, VFCF_FILEREVINC); MODULE_VERSION(ufs, 1); static b_strategy_t ffs_geom_strategy;