From nobody Tue Jan 14 15:26:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YXXyx4MgSz5kp43; Tue, 14 Jan 2025 15:26:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YXXyx1cNMz3p3c; Tue, 14 Jan 2025 15:26:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736868377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ka2mYo5nFtQvAeUC1Mq9C3Ie5KJ7jac5XBu1Y894Fn0=; b=gQNAIL/20f5hiQ/jNTClId4j2EM+uvMNCqD/uGx+8XKm3jf3dHvk2GWg+koPqfu2hXuiI6 JQBfqbq/lF5ipUo+gwgiEO7WCsfVLIU1yjAgZHmzFudLKZAy+8dAkhestZ171JqaZdpyJw XW/JzbJIZDXSkGDy47ImteFKbC7g5Ht1deFuHO6HCDZU2opx49/tb3LUXLi9pMfn2+rJ2H F678OcCuQOpyencgiAaNDddrmAS2OnYFgD26g9CnwXtFlarcmQs9uKu/0H2DTLyKoKe32t RJWCJDheuSzx2jNkgbZQhJlPGFO2eAGvYVzBJcy3/G5lfMata0CGr7ZD82dX/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736868377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ka2mYo5nFtQvAeUC1Mq9C3Ie5KJ7jac5XBu1Y894Fn0=; b=LLcyGNWABR/INMu861gyspwByS3BEfY2PKGjkL6cX2HZrDcW41tbPqWS+zpFEJoD0IAQIn Yn3TADQ6StKMldwQPU+8J6yYyPrMzNkHqR7+uv2uNrHaLqowxNL1zt5x4ZvQhgInUEJ/qA GZllSZADYOUfczsLI0C86V5E7PjTki81DTuxE7EywzlnGd8LYt7jewO7CKcvBpMDUW1d26 d4D53wNyBo3in7BeTHz1JkwGNidzYc3D4y7Aw7FkGLOHIQXEX2RtRAW6BGVC6SXEbkW+CM a7w5GIcKWOkPeEA9H4BfRRJN2z2AN/CG/fJHud1XlBYH/HY46MtPba65YZ58hQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736868377; a=rsa-sha256; cv=none; b=i8jDktrzKxUIRsE+t84n6WhGodqEs6d0hp0kuE0OSHl21fOYWq/AuDYX2renE1HkKti5h6 areir+vl+8sY/UlfUL1LuQvccoYFrg77aJAbiwyFanPn9ChTpGr5gDdOKQ0dGueVelOM9C ZNIHZkfM16wyhm7Cl3n3SUlvAd+/NmmV4iXepETcrhSHtcpfQ0j4HwAvzmVedrxjzs9lBX Dxpr8Zf2RkOyHrNTW1hqfhQZTfDscAsQ0y6gxLenofcQ6lXAuqRKoLMjkExiEy+ZMTokMS cyJ6Op4RRE1G3JboH4+usShlQtDQ5F02hzMnYiZW3xyIwylfy3YnME+G8wIIyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YXXyx0TNgz1L8b; Tue, 14 Jan 2025 15:26:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50EFQGx0090713; Tue, 14 Jan 2025 15:26:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50EFQGbs090710; Tue, 14 Jan 2025 15:26:16 GMT (envelope-from git) Date: Tue, 14 Jan 2025 15:26:16 GMT Message-Id: <202501141526.50EFQGbs090710@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: f78fe930854c - main - audit: Fix short-circuiting in syscallenter() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f78fe930854cac6eed55859b45e0a7b5d87189d6 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f78fe930854cac6eed55859b45e0a7b5d87189d6 commit f78fe930854cac6eed55859b45e0a7b5d87189d6 Author: Mark Johnston AuthorDate: 2025-01-14 14:19:24 +0000 Commit: Mark Johnston CommitDate: 2025-01-14 14:19:28 +0000 audit: Fix short-circuiting in syscallenter() syscallenter() has a slow path to handle syscall auditing and dtrace syscall tracing. It uses AUDIT_SYSCALL_ENTER() to check whether to take the slow path, but this macro also has side effects: it writes the audit log entry. When systrace (dtrace syscall tracing) is enabled, this would get short-circuited, and we end up not writing audit log entries. Introduce a pure macro to check whether auditing is enabled, use it in syscallenter() instead of AUDIT_SYSCALL_ENTER(). Reviewed by: kib Reported by: Joe Duin Fixes: 2f7292437d0c ("Merge audit and systrace checks") MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D48448 --- sys/kern/subr_syscall.c | 8 +++++--- sys/security/audit/audit.h | 5 ++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sys/kern/subr_syscall.c b/sys/kern/subr_syscall.c index 22bc35774e70..16fa47c5605a 100644 --- a/sys/kern/subr_syscall.c +++ b/sys/kern/subr_syscall.c @@ -141,9 +141,8 @@ syscallenter(struct thread *td) sy_thr_static = (se->sy_thrcnt & SY_THR_STATIC) != 0; - if (__predict_false(SYSTRACE_ENABLED() || - AUDIT_SYSCALL_ENTER(sa->code, td) || - !sy_thr_static)) { + if (__predict_false(AUDIT_SYSCALL_ENABLED() || + SYSTRACE_ENABLED() || !sy_thr_static)) { if (!sy_thr_static) { error = syscall_thread_enter(td, &se); sy_thr_static = (se->sy_thrcnt & SY_THR_STATIC) != 0; @@ -158,6 +157,9 @@ syscallenter(struct thread *td) if (__predict_false(se->sy_entry != 0)) (*systrace_probe_func)(sa, SYSTRACE_ENTRY, 0); #endif + + AUDIT_SYSCALL_ENTER(sa->code, td); + error = (se->sy_call)(td, sa->args); /* Save the latest error return value. */ if (__predict_false((td->td_pflags & TDP_NERRNO) != 0)) diff --git a/sys/security/audit/audit.h b/sys/security/audit/audit.h index b87dd52e0773..28e84dce79f3 100644 --- a/sys/security/audit/audit.h +++ b/sys/security/audit/audit.h @@ -389,9 +389,11 @@ void audit_thread_free(struct thread *td); audit_arg_vnode2((vp)); \ } while (0) +#define AUDIT_SYSCALL_ENABLED() audit_syscalls_enabled + #define AUDIT_SYSCALL_ENTER(code, td) ({ \ bool _audit_entered = false; \ - if (__predict_false(audit_syscalls_enabled)) { \ + if (audit_syscalls_enabled) { \ audit_syscall_enter(code, td); \ _audit_entered = true; \ } \ @@ -468,6 +470,7 @@ void audit_thread_free(struct thread *td); #define AUDITING_TD(td) 0 +#define AUDIT_SYSCALL_ENABLED() 0 #define AUDIT_SYSCALL_ENTER(code, td) 0 #define AUDIT_SYSCALL_EXIT(error, td)