From nobody Sat Jan 11 02:49:03 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YVNJc2ml0z5l4pm; Sat, 11 Jan 2025 02:49:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YVNJb6FBnz4Hhr; Sat, 11 Jan 2025 02:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736563743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6vGo4uZGsEsAIzg+sRmEv8CVuBQzLIsx+41/4Hf5rOU=; b=AdiFSzbY3LwD5XvSISnCkHSINnM9Hodx0725I2b76jhfYseRZrj94FXtxZaSNR9Jm+yU49 ZMJRkbU11htBUi2NPCN1zVr+mQMpCR9jhJrNZZwyGtW9qs2mklUoeyMRRIs3aGsyPq0xfL PIzH9UXKn/00e0ooi8e8fxoOtMN+MwYmRvgZXsbOEWl2xRQSATRATFXu8DY5ypE529Vuqy rfeQF6TWDNGGpXZZ/76zWTPr8tzjkEkhY6BZQo0ursM/XcgUvAJ/uSjjmXxyOGrpVhI696 D8U/Rk7kGuCHlbv4eaEMtIaI/8FVW/eAG35r58KoZ3/NW3OdjUvWQ5w1t79FMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736563743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6vGo4uZGsEsAIzg+sRmEv8CVuBQzLIsx+41/4Hf5rOU=; b=xKC9uwNrv035VmS4IgQocnasrSOal+awN1N0nQuda3RHb9G7pb/0kwtEzUJb7mUYUwQMcU HnxMFo5pw0xSjwoV8mFezvVi7nA707uAl/A1lW7k+TJXog+yjq2n0eqhg2fNs7FX4gYK/5 eQbYyxc9UME/RPW+QuaUVCzyWxAcEKZd5ZpazMoKYUvZNpYReWTjbJVKFqcus+xFybfsiF z40x472mI4B2ExiM8L8G5vCvDGZMXlh/onBM6IU11E3PnQ/UsLBjf3uObzriIKuy7LqDr/ 6cTV0nKkuMXNOYy/p/WWZW+cGm68hSpa7+ckGWViqDDOmQz0NPEKwRP4Z137rQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736563743; a=rsa-sha256; cv=none; b=gwwSNfTWMW8TkMOBYWtU58nL5caCOI8pBzZNWqa5dxuM0l0Ww/u+at8UAb+FctOf7C8ZVx qEDHJ7VDdWezIqhomINK5LiIbDuJV6vJoUC19O02WPrw1jYp1s/1cxG2VPan4C2pfVC1jA cEeA0scmkosWOw3iV0+qhJ53J2RX9wdx8xB1chuYflh4HfOovQdb6kDFBsLnbA1vTZv8Ta ReasilfLWHWMh0kkYlbTBGo54E33jZCX+3WC0ML+NzcVYS+4bdkp/Khn8manfCB5Z5l6Kb +xTneTfcI5PCQ6Z3nzq06zvnyJorlEhFDjajN9l8t+aVK3EGUkD2S5Xl8BSfdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YVNJb5qsszg8m; Sat, 11 Jan 2025 02:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50B2n3WL066699; Sat, 11 Jan 2025 02:49:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50B2n31x066696; Sat, 11 Jan 2025 02:49:03 GMT (envelope-from git) Date: Sat, 11 Jan 2025 02:49:03 GMT Message-Id: <202501110249.50B2n31x066696@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: 082f3564f94d - stable/13 - pkg: abstract rsa out behind a pkgsign API List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 082f3564f94d85054aba8ef4d34fc375611e5387 Auto-Submitted: auto-generated The branch stable/13 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=082f3564f94d85054aba8ef4d34fc375611e5387 commit 082f3564f94d85054aba8ef4d34fc375611e5387 Author: Kyle Evans AuthorDate: 2025-01-01 21:10:27 +0000 Commit: Kyle Evans CommitDate: 2025-01-11 02:48:30 +0000 pkg: abstract rsa out behind a pkgsign API This mirrors a change we made in pkg(8), and will be used to next add another signer that does ECC. Reviewed by: bapt, emaste (cherry picked from commit 5862580ded35e23581291a2e1052f04428369ead) --- usr.sbin/pkg/pkg.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- usr.sbin/pkg/pkg.h | 22 ++++++++++++-- usr.sbin/pkg/rsa.c | 11 +++++-- 3 files changed, 110 insertions(+), 9 deletions(-) diff --git a/usr.sbin/pkg/pkg.c b/usr.sbin/pkg/pkg.c index 56bced7b9c5f..5cc9c3b8dbfe 100644 --- a/usr.sbin/pkg/pkg.c +++ b/usr.sbin/pkg/pkg.c @@ -35,6 +35,7 @@ #include #include +#include #include #include #include @@ -55,6 +56,16 @@ #include "config.h" #include "hash.h" +static const struct pkgsign_impl { + const char *pi_name; + const struct pkgsign_ops *pi_ops; +} pkgsign_builtins[] = { + { + .pi_name = "rsa", + .pi_ops = &pkgsign_rsa, + }, +}; + typedef enum { HASH_UNKNOWN, HASH_SHA256, @@ -75,6 +86,61 @@ static const char *bootstrap_names [] = { STAILQ_HEAD(fingerprint_list, fingerprint); +static int +pkgsign_new(const char *name, struct pkgsign_ctx **ctx) +{ + const struct pkgsign_impl *impl; + const struct pkgsign_ops *ops; + struct pkgsign_ctx *nctx; + size_t ctx_size; + int ret; + + assert(*ctx == NULL); + ops = NULL; + for (size_t i = 0; i < nitems(pkgsign_builtins); i++) { + impl = &pkgsign_builtins[i]; + + if (strcmp(name, impl->pi_name) == 0) { + ops = impl->pi_ops; + break; + } + } + + if (ops == NULL) + return (ENOENT); + + ctx_size = ops->pkgsign_ctx_size; + if (ctx_size == 0) + ctx_size = sizeof(*nctx); + assert(ctx_size >= sizeof(*nctx)); + + nctx = calloc(1, ctx_size); + if (nctx == NULL) + err(EXIT_FAILURE, "calloc"); + nctx->impl = impl; + + ret = 0; + if (ops->pkgsign_new != NULL) + ret = (*ops->pkgsign_new)(name, nctx); + + if (ret != 0) { + free(nctx); + return (ret); + } + + *ctx = nctx; + return (0); +} + +static bool +pkgsign_verify_cert(const struct pkgsign_ctx *ctx, int fd, const char *sigfile, + const unsigned char *key, int keylen, unsigned char *sig, int siglen) +{ + + return ((*ctx->impl->pi_ops->pkgsign_verify_cert)(ctx, fd, sigfile, + key, keylen, sig, siglen)); +} + static int extract_pkg_static(int fd, char *p, int sz) { @@ -507,10 +573,12 @@ verify_pubsignature(int fd_pkg, int fd_sig) { struct pubkey *pk; const char *pubkey; + struct pkgsign_ctx *sctx; bool ret; pk = NULL; pubkey = NULL; + sctx = NULL; ret = false; if (config_string(PUBKEY, &pubkey) != 0) { warnx("No CONFIG_PUBKEY defined"); @@ -522,9 +590,14 @@ verify_pubsignature(int fd_pkg, int fd_sig) goto cleanup; } + if (pkgsign_new("rsa", &sctx) != 0) { + warnx("Failed to fetch 'rsa' signer"); + goto cleanup; + } + /* Verify the signature. */ printf("Verifying signature with public key %s... ", pubkey); - if (rsa_verify_cert(fd_pkg, pubkey, NULL, 0, pk->sig, + if (pkgsign_verify_cert(sctx, fd_pkg, pubkey, NULL, 0, pk->sig, pk->siglen) == false) { fprintf(stderr, "Signature is not valid\n"); goto cleanup; @@ -547,6 +620,7 @@ verify_signature(int fd_pkg, int fd_sig) struct fingerprint_list *trusted, *revoked; struct fingerprint *fingerprint; struct sig_cert *sc; + struct pkgsign_ctx *sctx; bool ret; int trusted_count, revoked_count; const char *fingerprints; @@ -555,6 +629,7 @@ verify_signature(int fd_pkg, int fd_sig) hash = NULL; sc = NULL; + sctx = NULL; trusted = revoked = NULL; ret = false; @@ -618,10 +693,15 @@ verify_signature(int fd_pkg, int fd_sig) goto cleanup; } + if (pkgsign_new("rsa", &sctx) != 0) { + fprintf(stderr, "Failed to fetch 'rsa' signer\n"); + goto cleanup; + } + /* Verify the signature. */ printf("Verifying signature with trusted certificate %s... ", sc->name); - if (rsa_verify_cert(fd_pkg, NULL, sc->cert, sc->certlen, sc->sig, - sc->siglen) == false) { + if (pkgsign_verify_cert(sctx, fd_pkg, NULL, sc->cert, sc->certlen, + sc->sig, sc->siglen) == false) { fprintf(stderr, "Signature is not valid\n"); goto cleanup; } diff --git a/usr.sbin/pkg/pkg.h b/usr.sbin/pkg/pkg.h index faa2be6c8376..2d0dab96a20f 100644 --- a/usr.sbin/pkg/pkg.h +++ b/usr.sbin/pkg/pkg.h @@ -30,6 +30,25 @@ #ifndef _PKG_H #define _PKG_H +#include + +struct pkgsign_ctx { + const struct pkgsign_impl *impl; +}; + +/* Tentatively won't be needing to free any state, all allocated in the ctx. */ +typedef int pkgsign_new_cb(const char *, struct pkgsign_ctx *); +typedef bool pkgsign_verify_cert_cb(const struct pkgsign_ctx *, int, + const char *, const unsigned char *, int, unsigned char *, int); + +struct pkgsign_ops { + size_t pkgsign_ctx_size; + pkgsign_new_cb *pkgsign_new; + pkgsign_verify_cert_cb *pkgsign_verify_cert; +}; + +extern const struct pkgsign_ops pkgsign_rsa; + struct sig_cert { char *name; unsigned char *sig; @@ -44,9 +63,6 @@ struct pubkey { int siglen; }; -bool rsa_verify_cert(int, const char *, const unsigned char *, int, - unsigned char *, int); - char *pkg_read_fd(int fd, size_t *osz); #endif /* _PKG_H */ diff --git a/usr.sbin/pkg/rsa.c b/usr.sbin/pkg/rsa.c index afc446a6ad06..b6345cdcecb8 100644 --- a/usr.sbin/pkg/rsa.c +++ b/usr.sbin/pkg/rsa.c @@ -77,9 +77,10 @@ load_public_key_buf(const unsigned char *cert, int certlen) return (pkey); } -bool -rsa_verify_cert(int fd, const char *sigfile, const unsigned char *key, - int keylen, unsigned char *sig, int siglen) +static bool +rsa_verify_cert(const struct pkgsign_ctx *ctx __unused, int fd, + const char *sigfile, const unsigned char *key, int keylen, + unsigned char *sig, int siglen) { EVP_MD_CTX *mdctx; EVP_PKEY *pkey; @@ -153,3 +154,7 @@ cleanup: return (ret); } + +const struct pkgsign_ops pkgsign_rsa = { + .pkgsign_verify_cert = rsa_verify_cert, +};