From nobody Thu Jan 09 20:20:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YTblD1dlKz5jy56; Thu, 09 Jan 2025 20:20:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YTblD0vz0z4qJT; Thu, 9 Jan 2025 20:20:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736454056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hCHCGjtIi7Cf5yDPFKAGbh7MKMI8WJ05biNEcHTdk+4=; b=hT7VQouuAqsHQJavZ4TEioR1e0/n1MS8lWzd5k8FjR+4DGMir0LEBOBM5Fi2SHgsdr3Vpf p7yHF7bsnXpQmKxfQBPWBNleiVPwdBlIzX/0BzTUw/Duo1dTvqHc3PvPmqbM3Xh/3DwPLd TgAowKsoRuNqtkr5We3Ugq5FaftCdR7hQ8MTEZAoFIB1ULx0W1anZ9T5RszRa8OHBaMNHe crYRhS/fpcmWz1N2MA3uL96xtAgEALlUi1aBp/SPwjyIdkOnPUrCnz+XhV/HqdH+XW4v9s gz9VgpNaHhGesQg549nC1mxtV/eTb8/dXBtbNCSXLfD4fg1uzkT8gmtP0vQzjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736454056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hCHCGjtIi7Cf5yDPFKAGbh7MKMI8WJ05biNEcHTdk+4=; b=Phm3KjGUQzBushybqrSnMEtEj/ZH5tUcx+QQ5RvaBf6COXy8kdJTHH3P/My2eQ3G/RN4KT 0FIloxY0qfKH0GSHQWHFB9WNz80YiceoXWA3rRHc+/DWihcMcHm9m6HWMpIZrVZ+BnYlH/ RLab/nRvFgc5cDig8JAs7FiNRA7gGzWHi0EjVgPg9VmqLt8Yc5SlHuGFxisresdcUcl1Xq oxft9MvJ4pdFnYLy+XZbCm+1wcVJTd+67H4Ruc4FEWDBzM2xamIKRDwCw8sV2s5GJjlxYG qN75d7XtaK6HIi3J4iXiojNw4ijbivyMm5PBP/flgM/+u0D8zDdkVVmOo7oJNw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736454056; a=rsa-sha256; cv=none; b=rZDVLLVbAurPAfOyD95cOfCXjWlMRldAK0tcOOXhaWoC3ELIh1zMoRas1OxmI6i/HuJKti 6cloeyr3P5MKyKyjiBnqD/gTkRN8Dl+DcmSGFB6gG/hxNmCViR3YThBnLSQKPp6WAC3TeH YOZqLd2ZPe3Xp3Nj5mgxtlHUE+PnC9MrhcDQCVXxjAXCU0bWH4qzbyOlf0KhcuU8LO3RBl xXQQeukPRGfJ/BSv5svzxjWqKfHVD+mALp35HSFWgDi99UEwjrtC+mEcR617CY6l37pI/+ f7eYplXurP21m4Vkf+kgrdK3bebZHuVG+5QUs+lIOAaWr6HdXnixzAe94w250g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YTblD0Ndwzhnq; Thu, 09 Jan 2025 20:20:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 509KKtLU058879; Thu, 9 Jan 2025 20:20:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 509KKt1U058876; Thu, 9 Jan 2025 20:20:55 GMT (envelope-from git) Date: Thu, 9 Jan 2025 20:20:55 GMT Message-Id: <202501092020.509KKt1U058876@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: ccabc7c2e556 - main - DEVICE_IDENTIFY.9: Modernize description and use cases List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ccabc7c2e556ac0b14da9b682b706ccaf251c0fe Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ccabc7c2e556ac0b14da9b682b706ccaf251c0fe commit ccabc7c2e556ac0b14da9b682b706ccaf251c0fe Author: John Baldwin AuthorDate: 2025-01-09 20:20:16 +0000 Commit: John Baldwin CommitDate: 2025-01-09 20:20:16 +0000 DEVICE_IDENTIFY.9: Modernize description and use cases Mention adding devices based on firmware tables and software-only pseudo-devices as use cases for identify methods as those are more common than reading random I/O ports to identify a legacy ISA device. Describe how device_find_chid can be used to avoid duplicates. While here, explicitly note that devices added in identify methods typically use a fixed device name. Trim the cross-references a bit. Reviewed by: ziaee, imp Differential Revision: https://reviews.freebsd.org/D48367 --- share/man/man9/DEVICE_IDENTIFY.9 | 52 +++++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/share/man/man9/DEVICE_IDENTIFY.9 b/share/man/man9/DEVICE_IDENTIFY.9 index d75c1a91ce4a..b10d94143050 100644 --- a/share/man/man9/DEVICE_IDENTIFY.9 +++ b/share/man/man9/DEVICE_IDENTIFY.9 @@ -26,44 +26,46 @@ .\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF .\" THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. .\" -.Dd January 15, 2017 +.Dd January 9, 2025 .Dt DEVICE_IDENTIFY 9 .Os .Sh NAME .Nm DEVICE_IDENTIFY -.Nd identify a device, register it +.Nd identify new child devices and register them .Sh SYNOPSIS .In sys/param.h .In sys/bus.h .Ft void .Fn DEVICE_IDENTIFY "driver_t *driver" "device_t parent" .Sh DESCRIPTION -The identify function for a device is only needed for devices on buses -that cannot identify their children independently, e.g.\& the ISA bus. -It is used to recognize the device (usually done by accessing non-ambiguous -registers in the hardware) and to tell the kernel about it and thus -creating a new device instance. +The identify method of a device driver is used to add devices that cannot be +enumerated by the standard method on a bus device. +Devices can be enumerated in various ways including accessing non-ambiguous +device registers and parsing firmware tables. +Software-only pseudo devices are also often enumerated via identify methods. .Pp +For each newly identified device, +a new device instance should be created by invoking the .Xr BUS_ADD_CHILD 9 -is used to register the device as a child of the bus. -The device's resources (such as IRQ and I/O ports) are registered -with the kernel by calling -.Fn bus_set_resource -for each resource (refer to +method. +If the identify method is able to discover other properties about the new +device, those should also be set. +For example, device resources should be added to the device by calling .Xr bus_set_resource 9 -for more information). +for each resource. .Pp -Since the device tree and the device driver tree are disjoint, the -.Fn DEVICE_IDENTIFY -routine needs to take this into account. -If you load and unload your device driver that has the identify -routine, the child node has the potential for adding the same node -multiple times unless specific measure are taken to preclude that -possibility. +An identify method might be invoked multiple times. +If a device driver is unloaded and loaded, +the identify method will be called a second time after being reloaded. +As a result, the identify method should avoid duplicate devices. +Devices added by identify methods typically use a fixed device name +in which case +.Xr device_find_child 9 +can be used to detect existing devices. .Sh EXAMPLES The following pseudo-code shows an example of a function that probes for a piece of hardware and registers it and its resource -(an I/O port) with the kernel. +(an I/O port) with the parent bus device. .Bd -literal void foo_identify(driver_t *driver, device_t parent) @@ -72,7 +74,7 @@ foo_identify(driver_t *driver, device_t parent) retrieve_device_information; if (devices matches one of your supported devices && - not already in device tree) { + device_get_child(parent, "foo", DEVICE_UNIT_ANY) == NULL) { child = BUS_ADD_CHILD(parent, 0, "foo", DEVICE_UNIT_ANY); bus_set_resource(child, SYS_RES_IOPORT, 0, FOO_IOADDR, 1); } @@ -82,11 +84,7 @@ foo_identify(driver_t *driver, device_t parent) .Xr BUS_ADD_CHILD 9 , .Xr bus_set_resource 9 , .Xr device 9 , -.Xr device_add_child 9 , -.Xr DEVICE_ATTACH 9 , -.Xr DEVICE_DETACH 9 , -.Xr DEVICE_PROBE 9 , -.Xr DEVICE_SHUTDOWN 9 +.Xr device_find_child 9 .Sh AUTHORS This manual page was written by .An Alexander Langer Aq Mt alex@FreeBSD.org .