From nobody Tue Jan 07 18:14:11 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YSK1v5ltNz5kwph; Tue, 07 Jan 2025 18:14:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YSK1v51hsz4jyP; Tue, 7 Jan 2025 18:14:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736273651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oXIrgFTELl5VW9Lu5aB7k+FNP7EEZur3AxDfJdtPOS8=; b=x/auKPthV4zCtZDOk4enxAOWybA39z8gydrBrezSEiEF+0EjAyU+SD+9fUDp+QRrPqjbp5 Dk3xL8hN5V2dUn8JJnDnqF8IEu59ybpW1ZbtvMqqbGKNFMFUfJzcCR3bxqWvEI2uxuT5xE XKtTcd3XY6V9ONHps68J5qLcop1wFoIVnNheImhNgHNi+iqaYCohrVlIhglKHo5YHCwUaT DY000JDhByXHCfFljgh0mkQgrQfq2+t3a00Ob+VVEJs4klCxAaTY6ikGbDlMZtHbdF9Nt1 2SfA5fAUG19ZzAb4qN9uwcA1vYEJMr9zgMNlkNBhHom4eAt8grpVvJTe/9Pqew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736273651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oXIrgFTELl5VW9Lu5aB7k+FNP7EEZur3AxDfJdtPOS8=; b=G9N7dS0eyiAC3bP8GbQFDHY1h9NSrV9+mIXotJuuFCXwwCLwZmImYg6txcp3Ew6fng/stc kfkBqlSTd39aMbrHOue68agd6xhq/5GtG4eLhps+DMB0OZwhXeq5tR8C+uo9Q5dRbuYwzv dzoCImSP/t8szhKe2X3HNlR68LB762gEZtgBT4LNg2lULiQK/rxx4rw7H0hojQJ4bdMIs8 mAzQTPOgdPTLNEIanKfaHSnMHObTWNO+K7U9t+zGL9TkTv5DI8/+NtUCKmnjGUTBdUsqof MTr4Zk+SB09YYu7e72zLxf7huiCKa4+wHKqH3rws+VWnCAxXZFk14zc+t0NGtw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736273651; a=rsa-sha256; cv=none; b=iZVsw66q5Otrk+pVGnkEws1UEq6BifDuJVX3cvmp7DR5tG0wWyL4AP+RAy4jeYh/NNIYHo Oxzg/SKn4INU9Gzzwt530+Xq76HRrJzwpJNqfCnkGEY/gPrX5lgHQezc9Z29vG0x9p9xNE 4pR7DnwrGcnQ95bjh7E51umQo7QLITR7Rjy+Ic0VnSRL4sk8TkTceTA8N/bJ/BAB2+kmJx NQvm/tpuDbIshrQkmkwhOaleF0vHzJPhtH22dTu8Ovoz5rGnvP1pSzIndz3WT3JLDdffIa GW14xhWifPJ5UVVFzIUu+n9ED1Q3WI5rLPm0Hp1OjqnZfVDaqv+M0DCuQ2Pfgw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YSK1v4Mp1z5ls; Tue, 07 Jan 2025 18:14:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 507IEBo2029101; Tue, 7 Jan 2025 18:14:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 507IEBi1029098; Tue, 7 Jan 2025 18:14:11 GMT (envelope-from git) Date: Tue, 7 Jan 2025 18:14:11 GMT Message-Id: <202501071814.507IEBi1029098@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 254a2b767f9a - main - x86: Short-circuit ipi_all_but_self() on UP systems List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 254a2b767f9a39f1541e0a07a70bbe269e86ad70 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=254a2b767f9a39f1541e0a07a70bbe269e86ad70 commit 254a2b767f9a39f1541e0a07a70bbe269e86ad70 Author: Mark Johnston AuthorDate: 2025-01-07 17:58:58 +0000 Commit: Mark Johnston CommitDate: 2025-01-07 18:13:54 +0000 x86: Short-circuit ipi_all_but_self() on UP systems Apparently this is required on old intel hw, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275086#c3 PR: 275086 Reviewed by: mav, kib Fixes: 279cd05b7e4d ("Use APIC_IPI_DEST_OTHERS for bitmapped IPIs too.") MFC after: 1 week Diagnosed by: Ben Wilber Differential Revision: https://reviews.freebsd.org/D48361 --- sys/x86/x86/mp_x86.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/mp_x86.c b/sys/x86/x86/mp_x86.c index 493017e303e3..c0da41a4d222 100644 --- a/sys/x86/x86/mp_x86.c +++ b/sys/x86/x86/mp_x86.c @@ -1425,6 +1425,9 @@ ipi_all_but_self(u_int ipi) cpuset_t other_cpus; int cpu, c; + if (mp_ncpus == 1) + return; + /* * IPI_STOP_HARD maps to a NMI and the trap handler needs a bit * of help in order to understand what is the source.