git: 4bce1a19fcfa - main - TCP BBR: remove code which is not needed

From: Michael Tuexen <tuexen_at_FreeBSD.org>
Date: Sat, 04 Jan 2025 20:11:11 UTC
The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=4bce1a19fcfac0c9f22c11278daa510546ccd3f2

commit 4bce1a19fcfac0c9f22c11278daa510546ccd3f2
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-04 20:08:43 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-01-04 20:08:43 +0000

    TCP BBR: remove code which is not needed
    
    rc_bbr_substate is a 3-bit unsigned int, so it can't be larger than
    or equal to 8. The wrap around already happens.
    No functional change intended.
    
    Reviewed by:            rrs
    CID:                    1523795
    MFC after:              1 week
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48320
---
 sys/netinet/tcp_stacks/bbr.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c
index ed7e07861ebd..535766a0a1b0 100644
--- a/sys/netinet/tcp_stacks/bbr.c
+++ b/sys/netinet/tcp_stacks/bbr.c
@@ -10313,10 +10313,6 @@ bbr_substate_change(struct tcp_bbr *bbr, uint32_t cts, int32_t line, int dolog)
 			bbr->r_ctl.bbr_smallest_srtt_state2 = bbr->r_ctl.bbr_smallest_srtt_this_state;
 	}
 	bbr->rc_bbr_substate++;
-	if (bbr->rc_bbr_substate >= BBR_SUBSTATE_COUNT) {
-		/* Cycle back to first state-> gain */
-		bbr->rc_bbr_substate = 0;
-	}
 	if (bbr_state_val(bbr) == BBR_SUB_GAIN) {
 		/*
 		 * We enter the gain(5/4) cycle (possibly less if