From nobody Thu Jan 02 18:28:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YPFZh333zz5jn6W; Thu, 02 Jan 2025 18:28:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YPFZh0bgDz4ttq; Thu, 2 Jan 2025 18:28:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735842508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ijjhz9cMMu9A3L3ztcDqvHH5c8K7lOUYFYCVupogK/0=; b=VD45PwhsYAzH9WZaqDcirEFNCX2iOmDSJysBqCWmhq9dchk+UQPDnE1mgFvLfkub9byqy4 NgYwLTmewahIaqxj9wcevOuIG+5fkIcL6k1tpviBYat2Iv87hxpw9+KHn8yXLk2oBze4VO 5m4k8MN3fTTXNuY1GmJo7a/jD7tkvTNWyLKXR+bwCDPCmgrZwtTyVroh62U8syYALdmE6g QjBTb8/7rSGN/gXz0eeQ5nVB7IN52nFDNkGJoQ5K20RdZtTq4Y3+t7m06m6AQE4VJQKm+V 9DhV6FgUKuqk2ooAJ4RaeNOVSBriR6RLYnPX2QSgVk8c/GRkhPTlSFQp+nL6cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735842508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ijjhz9cMMu9A3L3ztcDqvHH5c8K7lOUYFYCVupogK/0=; b=B52ZduiFE8/p/zyVwYjOL3Fnekgg3CkuLYCYW62OCboXAnHl7MsNkjA385vQ4WxmT+SA40 uTTHMYD6y7t088NOLCBfnQ6skTmx5Jc04Wr4gAt5pcRh1chdbPOvd165ghtE67GJBmViKe u1m7Ag9kKV5Gr3Ar4ee92UU4IzrWlrgNx8HjDRmriUeNv02cxOvAlAHHJrtsi/l5v07Ukp MDXfwjaI6giEK/BnVOvtR7ZGOCmL3gmN7zBHvWJqVt3o77/M2eJXq6js830Ma5CodDz//G N2urPAYR5mnY1pn+ObaCb6AANVE0pWeG6pzBy6X4iuL/PKYpSrYczWgLFRLeOQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735842508; a=rsa-sha256; cv=none; b=ZimQ6/myWV6qodsJATpcD1cLoCFHmJmYFuC05IW3e4/eoOvOvev7nD2WZP43Y9nEBSnLc2 K0Gh814O2wSBXLgFkN/fMbFzAyEjebOPFMEnfgeyPVfOT5rodq5sVId/Pa8O9CNt1mCGrN VOqYJpos944NrAoLex73YqqZMSu0jOWXUh1wbeQjhSupju/meRPWxjh0GY7uyt9/Z2j4ES sARJwvsV2YiGE/7oNmwtANS0FST3Rr8J7eb+JsSLrAhUSt3j46qaMFL3hyq1GOUAuqqwWW +mbpD7I6NMHRHHnp8OxWPIZ7bD+qJ+WbqgTeTFSPpKVpS4v5m4xFP7BBtlUYMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YPFZh07tFzpJl; Thu, 02 Jan 2025 18:28:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 502ISRn1066526; Thu, 2 Jan 2025 18:28:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 502ISRtq066523; Thu, 2 Jan 2025 18:28:27 GMT (envelope-from git) Date: Thu, 2 Jan 2025 18:28:27 GMT Message-Id: <202501021828.502ISRtq066523@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 919f911ea452 - main - siba: Use device_delete_children in siba_add_children List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 919f911ea4523276b7863e32e89943f270d3a76b Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=919f911ea4523276b7863e32e89943f270d3a76b commit 919f911ea4523276b7863e32e89943f270d3a76b Author: John Baldwin AuthorDate: 2025-01-02 18:23:54 +0000 Commit: John Baldwin CommitDate: 2025-01-02 18:23:54 +0000 siba: Use device_delete_children in siba_add_children Differential Revision: https://reviews.freebsd.org/D47967 --- sys/dev/bhnd/siba/siba.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sys/dev/bhnd/siba/siba.c b/sys/dev/bhnd/siba/siba.c index e693481f0819..ec9f22ff22af 100644 --- a/sys/dev/bhnd/siba/siba.c +++ b/sys/dev/bhnd/siba/siba.c @@ -1373,12 +1373,7 @@ siba_add_children(device_t dev) return (0); failed: - for (u_int i = 0; i < cid->ncores; i++) { - if (children[i] == NULL) - continue; - - device_delete_child(dev, children[i]); - } + device_delete_children(dev); free(cores, M_BHND); free(children, M_BHND);