From nobody Thu Jan 02 16:39:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YPC8w4rCLz5jR0h; Thu, 02 Jan 2025 16:39:28 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YPC8w3xwTz4hB5; Thu, 2 Jan 2025 16:39:28 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735835968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+gfcshliEpHqC2UqIusanhQm5jbReDquXBHA6qDDQH4=; b=jibjKt163iyP2/bZYJm+9HFjuyU36b4zfZsmXcjgob3laETpQRgA3kD707Zdmu18ZfY64R Ha++eepRq7r1M1acwqnr+gRCKEKKurj84bh6FOhP3ffYssUBH2p9GhUVpRDcq8Z0qGFgE+ M43VFA1gt7wdde2bjioq8ATYGaopBaE8sSBG6LZkOTEWJdPvcLGFo+Wv53TKkG1KA+02/j DeIdlaKAZrLvRh0Bw5knWJQ7rc+x7DSN4T2VnEaagSg/XRpLTwkXcMjPa6o+fmJ/vSI2WL jZKMzah1a+UhLQsg9vEPNKhGOO/b/fsZzd+d2Kjio2kTZkM/cXML44ubE+2Tlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735835968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+gfcshliEpHqC2UqIusanhQm5jbReDquXBHA6qDDQH4=; b=eA+v1vWE2b5HKQy9cTIS5+/G2gdS86EWXTtws1ifkzkyeIuriwBWQ5uwy+MM8YGCMIqo16 IFRkxXjePHGfhE6BSe4MwxuKTVik3vwWBx2NieYKG3VtFEXmKU6RhBvlzZmnnG3ePh46Fj UhLw43IHLxOUE9hKw50a75ilIVZVsEBX9yuQp4K6B12Kj3t7xoBKnbIwwT/GbVrD2F4oIs ZZym2kcQCBjPodD9mURO/Xxm5inIRhuseBgW1VYKyj7N26TLpnJoBjRlFoQhcMtP4c3XKr Gr2avgozKvxHEB8k5lLwNJxJeFFk3Ui5AA+VCu6na2zB21IGNCnH9LLA7/nHlQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735835968; a=rsa-sha256; cv=none; b=dGCbThBgmJ76vVoJWY7jzNYU9fYXsEE1QbphXX8g4bo51x3/3c3udigPAMsV49Yiq0SULv 4NpLfGUq3HTlyLb/GC+wMkWhHuzD6GOF5tp9gu3duj9WJmvT+SAoS1YmpJLY0uJxCY44pU tXbsQvSmWFCq40sVHH8o0BKVEbuQDwOh19Cw3zcFuUk97JyWSb6g779VC83TNnDDcs6ksG PQHh0nIrGq6uZh9cUHrBw6TZgaoV4yrsZ5MF0IdETXidbgtrgM/BQ9k15A6mwYlha1kkbq 6UVUOa7PDYcXnMaJ27lwVD7Zok0ZKxSPm2xgQWm7z4f5q3lDqd+w8d0hmp115Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YPC8w0l5KzrWX; Thu, 02 Jan 2025 16:39:27 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <6ced2be5-a28d-4c7c-a9c7-bfb8a5336996@FreeBSD.org> Date: Thu, 2 Jan 2025 10:39:26 -0600 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 04160e000898 - main - arm64: add a driver for the Apple Interrupt Controller To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202412171425.4BHEPuSP010250@gitrepo.freebsd.org> <1a7f916d-ce0d-4ad2-ad8a-6ee75b747341@FreeBSD.org> Content-Language: en-US From: Kyle Evans In-Reply-To: <1a7f916d-ce0d-4ad2-ad8a-6ee75b747341@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/2/25 10:24, John Baldwin wrote: > On 12/17/24 09:25, Kyle Evans wrote: >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=04160e0008982fa0e03ebcc3747d81bcd547f751 >> >> commit 04160e0008982fa0e03ebcc3747d81bcd547f751 >> Author:     Kyle Evans >> AuthorDate: 2024-12-17 14:14:54 +0000 >> Commit:     Kyle Evans >> CommitDate: 2024-12-17 14:24:14 +0000 >> >>      arm64: add a driver for the Apple Interrupt Controller >>      Some limited support for later multi-die SoC is included, but not >> at all >>      tested and not expected to be functional yet.  kevans needs to >> finish >>      getting his serial boards constructed, as the beefiest AS machine >> that >>      actually has multiple die to support in his fleet is currently a >>      dedicated serial console. >>      Reviewed by:    andrew >>      Co-authored-by: Andrew Turner >>      Co-authored-by: Mike Karels >>      Differential Revision:  https://reviews.freebsd.org/D48079 > > This doesn't build without `options SMP` so breaks make universe due to the > sys/arm64/conf/GENERIC-UP kernel config. > > The first error is a simple fix in attach (local variable 'cpu' is unused), > but I wasn't quite sure what the right thing to do in the bus_setup_intr > method was for the AIC_TYPE_IRQ case where sc_cpuids is used > unconditionally. > Sigh, sorry... https://reviews.freebsd.org/D48289 Thanks, Kyle Evans