From nobody Thu Jan 02 15:21:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YP9Qp29sQz5jLHQ; Thu, 02 Jan 2025 15:21:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YP9Qp1c18z4SRm; Thu, 2 Jan 2025 15:21:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735831282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vJr2evXFCyu/LJUYAlEReZ3Dsq+n8CWGxMogh+BYtNQ=; b=aYx5ZdzzWRdZN5PZndQNM8NroEuhFGfM8DgyA+izZKvIipSISMcCVKIG3PqxwxsPBn3BQl h61whGZI5olKS3wsw/AGHbGHEw8UwaRJxdIY5psBkIKOgO6/EL7kFJUcx7AVk6p6on8+kq O65zpA/9/xPQl5B/gAluOblVHWd6juv2VB/TJcazGxADKThGVup5boW3H4tzFHihoMW0D3 UuROfI5vDOsnXDhTGkafAjuv9SPijCte5SYTVch2fgTws9WxMwj9INpqiNNNec6+TgyF6q qOiR/I+PfCgIUXHv/YWZOx6Dp23IlF+csTd6u4aegTR35cbo08Dd3pIRwnWnmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735831282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vJr2evXFCyu/LJUYAlEReZ3Dsq+n8CWGxMogh+BYtNQ=; b=LoOfZyuTUEZ9bbE1Qbv/e3wwlIG94JNRLSoRBEymgM1Dp/UoclFsnn0L3z7DfXN8gTv06S Y5LYTL2sWcTSlwNvir3xQkM5TsRV+SBLt06gtvWcpHjYDfB0aXt3Q1P6CKyeXirgw9bigt 7XvpVO5TVtiSdPTISPLLJzmhfaNnwYrTaBWxhu7sQBtgotjK5VrBmMSoEy/iJHerpn7rkw lQZNWv9a+A5kqQYNrDgJGGfPVjCcoX6Zw3MrbzEzBaZGcrxfhNwuvIPLIEnakDeIGkag4m TDhTrv0bpANxzTpsk8fagO4zVVUainvt1alt85ja5QElPWLfR+ccUmQWh5w3lw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735831282; a=rsa-sha256; cv=none; b=MhxlUSyao1zyabOgPaKAQAF00skCzmUyb4TbZLNfu2fvQH1kPvCV6TdO7B+IKDMTU+TElJ bclEEMUn7vu5UiC1FjgJpzAq/OXvWPNsqej84Lz39VHXX5bR/TimmLcc6TnN9U+TH74N2c 4Bd4iPTo5JpqlpjSHL+4bLPyr/3yfx9/bdHTkdsqkmeen4jVBFaPGCtE+/elfDKFzFfArc IG1oWAk2qfZJwdR6kn5Sc8Jat/qu7R4vYH8dPGjR/6A36G9tTChyYaEPZJ2Kz4MRlXmmBA 57vbfuRCRVKPAcjSw+TFsbmE+itbPjlPx28MnZjW0I3VehFSI/nwpXHCguNLgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YP9Qp10XmzjJh; Thu, 02 Jan 2025 15:21:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 502FLM7o019767; Thu, 2 Jan 2025 15:21:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 502FLMB8019764; Thu, 2 Jan 2025 15:21:22 GMT (envelope-from git) Date: Thu, 2 Jan 2025 15:21:22 GMT Message-Id: <202501021521.502FLMB8019764@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 8471791eb6ee - main - TCP RACK: simplify condition List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8471791eb6eeedaedd4d70e1076cfd143bf12fca Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=8471791eb6eeedaedd4d70e1076cfd143bf12fca commit 8471791eb6eeedaedd4d70e1076cfd143bf12fca Author: Michael Tuexen AuthorDate: 2025-01-02 15:19:30 +0000 Commit: Michael Tuexen CommitDate: 2025-01-02 15:19:30 +0000 TCP RACK: simplify condition It is already known that rsm != NULL, so no need to check for it. Reviewed by: rrs CID: 1523815 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48282 --- sys/netinet/tcp_stacks/rack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 00c373ef0790..233513548d72 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -18877,7 +18877,7 @@ rack_fast_rsm_output(struct tcpcb *tp, struct tcp_rack *rack, struct rack_sendma log.u_bbr.pkts_out = tp->t_maxseg; log.u_bbr.timeStamp = cts; log.u_bbr.inflight = ctf_flight_size(rack->rc_tp, rack->r_ctl.rc_sacked); - if (rsm && (rsm->r_rtr_cnt > 0)) { + if (rsm->r_rtr_cnt > 0) { /* * When we have a retransmit we want to log the * burst at send and flight at send from before.