From nobody Wed Jan 01 17:43:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YNcdS1JZRz5hycq; Wed, 01 Jan 2025 17:43:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YNcdS0ZwVz4SH3; Wed, 1 Jan 2025 17:43:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735753420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i6JsImf34GShJ1ulzAIg988GAQhNSnR5O0q46RBirXg=; b=wmYyrVHPAdwWmGtohwAmFUfoINfsu8FAr+YuZiqPTpQVuWyyKF1t+8NPyb5pegLWTkhu02 R73eQjaQT5ARhEWuc/DoUG9Ks9hLjc51Ibeu8KyPB+GFdKMBMahpmg7fpVQ0HRRx0hH2Am qMN9Ekjdl+KfdQJ2/f6uBmF6KgEUfHavPmnbBBUivjhSbF/92pLs5HxROoxkI3uIsb6i+z llaa2Das3xi6/dWwzpIww4GUlPcSCY0dowNCGRRujHBh8SLuRW9ajSYV1Tirl0hVtYbbPx amscD2c1zs+IeV/XPqyWus63fkb5to/9TH0sEG2fYcO79rMH7hFSV6ZKN7nLyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735753420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i6JsImf34GShJ1ulzAIg988GAQhNSnR5O0q46RBirXg=; b=YRqU9kIWfNJqWTS2uiamjPqOYTyRTGMKLnD/syWx5w8C1rJtRGiOUDeRjR7IBQZwMh9Pzl VB73O5shzHcHS4lTZjUplExPBzh1AI407kd+Age9enOcaOVATf5/n4+TCvTRs2QuXf2xnd VDZYUICV7tLwascJVqGmjyoutXha4btiJ/Wv9QRXbFmQT9luf++kFV5bRagYcuL8Zl0vSV Q6qWGBXzQdVYCb4q6YqoPS9cHjCDWaCASrHixdkqgRKv4WXFhOlAhfD4ZEZVgmBUlJXRCP yLUuAUxH3DdYReAPT1f92/LICtUoqMJD18xJvBXq+T2YcJu57T4EC6cjxDQUiA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735753420; a=rsa-sha256; cv=none; b=Nqbp2q7P1Xz5C8sLRLi21aBTtqkHQ23+HCWdgMpjdCbdWOFGQUtS+C/J2g+z7SrbKSIZVX EXFM2DWb1yBe8COP6DD5q3u6aFA3Vrrya2F5RoJj+G99b/nv1F1LzDEa0jPi/UfF3dPcZM 6jmd3d3OHCkKH9rQtWsZEH+ifhe6E7Llp3Rsb5BTyePjZwhvNrYHY8DDgebR6L5vhFTob1 Rz7MNkiCxVspCd/Yb+6oQDxHhI2ebFgpBj6Dv/3qLzQvWA5EH1G+RrL+43GKUl1HfCQX6o UlvD9CjhDEbk3uq5qdvR2z7IVAipQ+yNVZhSgvtQRMt6+OtAsHgZydsdKpT5cw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YNcdS0B8FzZHP; Wed, 1 Jan 2025 17:43:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 501HhdEc091096; Wed, 1 Jan 2025 17:43:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 501HhdMV091093; Wed, 1 Jan 2025 17:43:39 GMT (envelope-from git) Date: Wed, 1 Jan 2025 17:43:39 GMT Message-Id: <202501011743.501HhdMV091093@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 3b9da3dcd11f - main - TCP RACK: avoid using uninitialized tot_idle variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3b9da3dcd11f3d73281383c4ba383a4fcc4b9bbe Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=3b9da3dcd11f3d73281383c4ba383a4fcc4b9bbe commit 3b9da3dcd11f3d73281383c4ba383a4fcc4b9bbe Author: Michael Tuexen AuthorDate: 2025-01-01 17:42:00 +0000 Commit: Michael Tuexen CommitDate: 2025-01-01 17:42:00 +0000 TCP RACK: avoid using uninitialized tot_idle variable Reviewed by: rrs CID: 1540027 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48277 --- sys/netinet/tcp_stacks/rack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index acd622814916..00c373ef0790 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -19994,7 +19994,8 @@ rack_output(struct tcpcb *tp) rack_exit_probertt(rack, cts); } } - } + } else + tot_idle = 0; if (rack_use_fsb && (rack->r_ctl.fsb.tcp_ip_hdr) && (rack->r_fsb_inited == 0) &&