git: fe6e275dc6f7 - stable/13 - LinuxKPI 802.11 / rtw88: make packets flow again

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Thu, 06 Feb 2025 20:50:38 UTC
The branch stable/13 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=fe6e275dc6f7527961ceaf7ce2912a29cdbb00b3

commit fe6e275dc6f7527961ceaf7ce2912a29cdbb00b3
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2024-12-20 14:23:50 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2025-02-06 20:49:51 +0000

    LinuxKPI 802.11 / rtw88: make packets flow again
    
    In 886653492945f we added checks for packets to only go out if the
    station is known to the firmware (amongst others) as there are
    implications in drivers.
    Unfortunately rtw88 does not support the mac80211 (*sta_state)() KPI
    but only the fallback (*sta_add/remove)() in which case the station is
    only added to firmware when going from AUTH to ASSOC.  That means we
    had no chance to get authenticated anymore.
    
    PR:     283142, 274382
    Fixes:  886653492945f (make sure we can send DISASSOC or DEAUTH frames)
    Tested by:      imb protected-networks.net, oleg.nauman gmail.com
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D48161
    
    (cherry picked from commit 2372f8cc640c2f4ab82831e6ac0e27ab6c18321a)
---
 sys/compat/linuxkpi/common/src/linux_80211.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c
index ef742125dbac..71f53aed2dda 100644
--- a/sys/compat/linuxkpi/common/src/linux_80211.c
+++ b/sys/compat/linuxkpi/common/src/linux_80211.c
@@ -3692,7 +3692,16 @@ lkpi_ic_raw_xmit(struct ieee80211_node *ni, struct mbuf *m,
 
 	lsta = ni->ni_drv_data;
 	LKPI_80211_LSTA_TXQ_LOCK(lsta);
+#if 0
 	if (!lsta->added_to_drv || !lsta->txq_ready) {
+#else
+	/*
+	 * Backout this part of 886653492945f which breaks rtw88 or
+	 * in general drivers without (*sta_state)() but only the
+	 * legacy fallback to (*sta_add)().
+	 */
+	if (!lsta->txq_ready) {
+#endif
 		LKPI_80211_LSTA_TXQ_UNLOCK(lsta);
 		/*
 		 * Free the mbuf (do NOT release ni ref for the m_pkthdr.rcvif!
@@ -3940,7 +3949,16 @@ lkpi_80211_txq_task(void *ctx, int pending)
 	 * We also use txq_ready as a semaphore and will drain the txq manually
 	 * if needed on our way towards SCAN/INIT in the state machine.
 	 */
+#if 0
 	shall_tx = lsta->added_to_drv && lsta->txq_ready;
+#else
+	/*
+	 * Backout this part of 886653492945f which breaks rtw88 or
+	 * in general drivers without (*sta_state)() but only the
+	 * legacy fallback to (*sta_add)().
+	 */
+	shall_tx = lsta->txq_ready;
+#endif
 	if (__predict_true(shall_tx))
 		mbufq_concat(&mq, &lsta->txq);
 	/*