Re: git: ecccb638d494 - main - mountd: Promote missing netmask log to LOG_ERR

On Tue, Feb 4, 2025 at 9:21 AM Cy Schubert <Cy.Schubert@cschubert.com> wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@uoguelph.ca.
>
>
> In message <202502041658.514Gwo4I049201@gitrepo.freebsd.org>, Ed Maste
> writes:
> > The branch main has been updated by emaste:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=ecccb638d494f2642f1e2eae8ad932ba
> > 70567ccc
> >
> > commit ecccb638d494f2642f1e2eae8ad932ba70567ccc
> > Author:     Ed Maste <emaste@FreeBSD.org>
> > AuthorDate: 2025-02-01 13:16:47 +0000
> > Commit:     Ed Maste <emaste@FreeBSD.org>
> > CommitDate: 2025-02-04 16:58:41 +0000
> >
> >     mountd: Promote missing netmask log to LOG_ERR
> >
> >     Historical network classes are deprecated, but currently still supported
> >     in mountd with a LOG_WARNING-priority message added by Mike Karels in
> >     2021.  Upgrade the log to LOG_ERR well in advance of this becoming a
> >     fatal error.
> >
> >     Reviewed by:    rmacklem
> >     Sponsored by:   The FreeBSD Foundation
> >     Differential Revision: https://reviews.freebsd.org/D48795
> > ---
> >  usr.sbin/mountd/mountd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c
> > index 4457a925c2ed..19d76b72da10 100644
> > --- a/usr.sbin/mountd/mountd.c
> > +++ b/usr.sbin/mountd/mountd.c
> > @@ -1806,7 +1806,7 @@ get_exportlist_one(int passno)
> >                       len = endcp - cp;
> >               }
> >               if (opt_flags & OP_CLASSMASK)
> > -                     syslog(LOG_WARNING,
> > +                     syslog(LOG_ERR,
> >                           "WARNING: No mask specified for %s, "
>
> Should this be changed from WARNING to ERROR too?
I don't have a strong opinion, but I would say no.
An error in mountd indicates a failure and in this case the semantics
remain what they have always been and doesn't necessarily imply
a semantics failure.

rick

>
> >                           "using out-of-date default",
> >                           (&grp->gr_ptr.gt_net)->nt_name);
> >
>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
> NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>
>                         e^(i*pi)+1=0
>
>
>