From nobody Mon Sep 30 15:53:01 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XHQZk1Y38z5XHXL; Mon, 30 Sep 2024 15:53:02 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XHQZk12H1z4ZpR; Mon, 30 Sep 2024 15:53:02 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727711582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RzfaYgC32uB7Ls0sANtwQ6kcNIs4a+BeDMGeu3+ALpc=; b=Xc/bM0vWMfZ9cKyc6XozeZJV9a+kqBIsZ4/j9DwF5BxXmMvGoDylmte99WAxGOAaszhtXc PQAEFmSE3zEJyv7xPndnVMTkskUQoZz5SMMhnBZp98p+5gGMN9bd8nfdVKa9hkj/moK0sQ 7qbtUopbPoI/+nfc/D79N09uKUcnSUnGQjdOy3ztrA5/z0HQrTy/PttjZ0VCj8fWS1J93k zr4a8npy5Ov1WidDZB/vWDZVrS/viND8+xbM3XeM0+64HGUj8eoEE3MXm+a61jLx1y5A2s /fELZew/6jAKy2IFHrdrXvfjSRySsf3rL7wALHLKHjk1dGai/hyXE9j3YL32IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727711582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RzfaYgC32uB7Ls0sANtwQ6kcNIs4a+BeDMGeu3+ALpc=; b=ksQtcntZRAW0BuW+dYA/+0Y9kMTspWBzw9DinneMztSrqK2GaukblowOV69wBY9FMvAJDX JVy2xZNk054rIiF9pEZ+VD4vTLmjArExC5gJa7ntCZLciKYC+CIwxRyiTShTLId1Kula7k N094NICQCUR6MJcT+C01h7RyqKeOa75jP7FaHZzs8h3KDoCVjUin9YvsJd7AAJZ3OcSild u4uhOipslKmDkLbEhnhlqXccoifMVnmd9+CnKjS3lkM0OIsE00cOjzPiXC3b+sNWfU00kL gYL8bBldZPthnC73uUy14+Wft0PMw9pdx+efPFVexlP3XUhSjOMquznNB8yPug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727711582; a=rsa-sha256; cv=none; b=cRyio/17l93fY+sKhN3qC2NjlgQSq+gKHTkQ2uh3czBnLYuuB7/b0m2OSQDNaYs75GEGXC KWh9qJoZADNshKnuxBCXwBLVPxu5JFKpGeE4afyMlZaThihmHumiAKNzSu/pCPZbAI35dy l8sLAbvj5TOknsf6Hbs9VGjfB05a7vWwvUtnhIO87/L1o2aIG4/tWXt2WRX6gN4wilgyns ybdUgPaIBShsXbdrksiHKCbnImC5hFhU+X+L4c1n7VgYx2maHM3h6cG53M5OMQpXD7/kIn Sy8FGWO9kNsQcTXUk2ilI9u5wCAPGYQPQnSMXx+2yN4ze/J757L0EIE9xB12Nw== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XHQZk0MwTzNrs; Mon, 30 Sep 2024 15:53:02 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 5101D3C019B; Mon, 30 Sep 2024 15:53:01 +0000 (UTC) Date: Mon, 30 Sep 2024 15:53:01 +0000 From: Brooks Davis To: Antoine Brodin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1235d276b78a - main - lib{c,sys}: stop exposing errno symbol Message-ID: References: <202409271933.48RJX0dH066668@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Sep 30, 2024 at 08:33:18AM +0200, Antoine Brodin wrote: > On Fri, Sep 27, 2024 at 9:33???PM Brooks Davis wrote: > > > > The branch main has been updated by brooks: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1235d276b78a769bded01d51c9bf3cdc480db9fb > > > > commit 1235d276b78a769bded01d51c9bf3cdc480db9fb > > Author: Brooks Davis > > AuthorDate: 2024-09-27 19:27:46 +0000 > > Commit: Brooks Davis > > CommitDate: 2024-09-27 19:27:46 +0000 > > > > lib{c,sys}: stop exposing errno symbol > > > > Officially since C11 (and in reality FreeBSD since 3.0 with commit > > 1b46cb523df3) errno has been defined to be a macro. Rename the symbol > > to __libsys_errno and move it to FBSDprivate_1.0 and confine it entierly > > to libsys for use by libthr. Add a FBSD_1.0 compat symbol for existing > > binaries that were incorrectly linked to the errno symbol during > > libc.so.7's lifetime. > > > > This deliberately breaks linking software that directly links to errno. > > Such software is broken and will fail in surprising ways if it becomes > > threaded (e.g., if it triggers loading of a pam or nss module that > > uses threads.) > > > > Reviewed by: kib > > Differential Revision: https://reviews.freebsd.org/D46780 > > --- > > lib/libsys/Makefile | 2 ++ > > lib/libsys/Symbol.map | 1 + > > lib/libsys/Symbol.sys.map | 1 - > > lib/libsys/__error.c | 10 +++++----- > > lib/libthr/sys/thr_error.c | 5 ++--- > > lib/libthr/thread/thr_rtld.c | 7 +++---- > > 6 files changed, 13 insertions(+), 13 deletions(-) > > Hello, > > This breaks some ports: Thank you for the list (that's more than I expected). I'll work on updates. The fix is to replace extern int errno; with #include -- Brooks > > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/cdb-0.75.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/checkpassword-0.90.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/clockspeed-0.62_6.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/copytape-1.0_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/daemontools-0.76_19.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/dot-forward-0.71_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/faces-1.7.7_13.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/fastforward-0.51_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/gkermit-1.0_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/ja-edict-19990714_6.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/ja-mh-6.8.4.j3.05_7.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/mess822-0.58_3.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/mpeg_encode-1.5b.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/pbasic-2.1_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/qlogtools-3.1_4.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/qmail-contrib-0.1_3.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/qmail-dk-0.54_2.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/qmail-rblchk-2.4.1_2.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/qmailanalog-0.70_4.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/queue-fix-1.4_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/serialmail-0.75_4.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/sliderule-1.0_11.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/socket-1.2_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/viz-1.1.1_2.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/xml-format-0.2_1.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/xspread-3.1.1c_5.log > https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/2024-09-27_21h05m12s/logs/errors/xtrojka-1.2.3_4.log > > Cheers, > > Antoine >