From nobody Mon Sep 30 06:33:18 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XHB976Lqrz5XrJf; Mon, 30 Sep 2024 06:33:31 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XHB963mdXz4tJp; Mon, 30 Sep 2024 06:33:30 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of antoine.brodin.freebsd@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=antoine.brodin.freebsd@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-84e9edc17beso1010328241.0; Sun, 29 Sep 2024 23:33:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727678009; x=1728282809; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7EmrDi0gRYOCGnIoV4EuOpTZRk2lUjqai8qASGdp1CE=; b=faOaHN6bv9nipXc0z2rh166g8L81KEwQ1hnoT31Z/UoTVS5V2VshADDMybFRXN/YP3 bNCzslQX7OFxeMipOeFpygiL2EdgUXa4JT0D+x6h/B63lSbALXQN0aTK23qiift3iiE8 SY8NxvtbEmb071572GxPrJns33euIGM/qbTHsAHl3EGT/bpWefJ+30P1P2jtwM5iDg37 Y7mM5xBtrS3kAc3k1pjh5xKpbAkcubA7TomvECBlBCRriscR1jC+dT7gQRyktqDlT1FM 2NdheOizmEq9Xoq9jI+yN9tF/nUgrWfqWmKUDDe+l+mmvmriGuMZYpd9bYOWIn3cB8Tz 2Chg== X-Forwarded-Encrypted: i=1; AJvYcCW8Tk97rxKE53uKEHJGVh7IcJ17uidJP4mSOepMxvmbKcad6jfcgxQcySiJkuP1RCqCoItWrYQByZspdxjd40rCV0zGQC8=@freebsd.org, AJvYcCWUGGDciUh1mNmmx/aIHSugzqqmA2LvtasssNSbI8oU4bz9ovWZWx3LrpDtz30ImuVKy6mxmv3pbrtl1Dgtn0k7he9d@freebsd.org X-Gm-Message-State: AOJu0YxIwbuZCJRr4XkiCpUggZ7J1wkg/T37upPkNGaD1tEtvhf9ywC0 xDPeEXg0DUzn6D60PnFpYopzYO9TJ4aw/pQCh7Ffr3D5smMWz4zVj6MGTXNohK+Zxchqw472d3v ua2bCwQeTA7mCtYf8ATBjiZsKoA9oDPrp X-Google-Smtp-Source: AGHT+IFSQNwOwqsS8R1PM9GD4lAi04O2YUIE42amJQCP53rZcugxsngE2p08HXu5IsXQSLOSYmv+E8OH2bukfiZ3tLc= X-Received: by 2002:a05:6122:923:b0:4ed:185:258c with SMTP id 71dfb90a1353d-507816b475dmr5786432e0c.2.1727678009253; Sun, 29 Sep 2024 23:33:29 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202409271933.48RJX0dH066668@gitrepo.freebsd.org> In-Reply-To: <202409271933.48RJX0dH066668@gitrepo.freebsd.org> From: Antoine Brodin Date: Mon, 30 Sep 2024 08:33:18 +0200 Message-ID: Subject: Re: git: 1235d276b78a - main - lib{c,sys}: stop exposing errno symbol To: Brooks Davis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.77 / 15.00]; NEURAL_HAM_SHORT(-0.98)[-0.982]; NEURAL_HAM_LONG(-0.98)[-0.978]; NEURAL_HAM_MEDIUM(-0.91)[-0.909]; FORGED_SENDER(0.30)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; ARC_NA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.222.43:from]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.43:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4XHB963mdXz4tJp X-Spamd-Bar: -- On Fri, Sep 27, 2024 at 9:33=E2=80=AFPM Brooks Davis w= rote: > > The branch main has been updated by brooks: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D1235d276b78a769bded01d51c9= bf3cdc480db9fb > > commit 1235d276b78a769bded01d51c9bf3cdc480db9fb > Author: Brooks Davis > AuthorDate: 2024-09-27 19:27:46 +0000 > Commit: Brooks Davis > CommitDate: 2024-09-27 19:27:46 +0000 > > lib{c,sys}: stop exposing errno symbol > > Officially since C11 (and in reality FreeBSD since 3.0 with commit > 1b46cb523df3) errno has been defined to be a macro. Rename the symbo= l > to __libsys_errno and move it to FBSDprivate_1.0 and confine it entie= rly > to libsys for use by libthr. Add a FBSD_1.0 compat symbol for existi= ng > binaries that were incorrectly linked to the errno symbol during > libc.so.7's lifetime. > > This deliberately breaks linking software that directly links to errn= o. > Such software is broken and will fail in surprising ways if it become= s > threaded (e.g., if it triggers loading of a pam or nss module that > uses threads.) > > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D46780 > --- > lib/libsys/Makefile | 2 ++ > lib/libsys/Symbol.map | 1 + > lib/libsys/Symbol.sys.map | 1 - > lib/libsys/__error.c | 10 +++++----- > lib/libthr/sys/thr_error.c | 5 ++--- > lib/libthr/thread/thr_rtld.c | 7 +++---- > 6 files changed, 13 insertions(+), 13 deletions(-) Hello, This breaks some ports: https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/cdb-0.75.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/checkpassword-0.90.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/clockspeed-0.62_6.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/copytape-1.0_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/daemontools-0.76_19.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/dot-forward-0.71_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/faces-1.7.7_13.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/fastforward-0.51_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/gkermit-1.0_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/ja-edict-19990714_6.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/ja-mh-6.8.4.j3.05_7.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/mess822-0.58_3.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/mpeg_encode-1.5b.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/pbasic-2.1_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/qlogtools-3.1_4.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/qmail-contrib-0.1_3.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/qmail-dk-0.54_2.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/qmail-rblchk-2.4.1_2.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/qmailanalog-0.70_4.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/queue-fix-1.4_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/serialmail-0.75_4.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/sliderule-1.0_11.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/socket-1.2_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/viz-1.1.1_2.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/xml-format-0.2_1.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/xspread-3.1.1c_5.log https://pkg-status.freebsd.org/gohan05/data/maini386PR281667-default-foo/20= 24-09-27_21h05m12s/logs/errors/xtrojka-1.2.3_4.log Cheers, Antoine