From nobody Mon Sep 30 04:45:22 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XH7mM0zlXz5Xk2d; Mon, 30 Sep 2024 04:45:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XH7mL560Hz4F0d; Mon, 30 Sep 2024 04:45:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727671522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lMMStybdZi6WPZctxlo20/zwWy8eKcJGSjWmE4PlsNw=; b=vnbULDfcfLDlg6pW2HAzHl9OW5Fc487ojHZTOk/9dhNQGViMFpR0MpeHiypM3glCKOrFwq m/kbIzkufdFbe227vy64RXTZx4ZR/Oo5T8vhGTAw3Z6X9rv47WAN+NkAv2C6XmSj0qIDfz UDxapDtlh7c4rEVM2vqGtCP0hS3ImXfoDK4BQiLItySSyJe0kbDq/cta0nQl9jdIE7qv/o II4O20P8LV8L2lBm4pQhFnwUy7y98MkitwL1r6MEwXMyproapkry9OqougjLdt4ywuuO+z 7IIzvzAH5MXWArzretFrAJ0Mi3MF7YSetTi20+b18ZTa0+0YykgAmtMom8gH+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727671522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lMMStybdZi6WPZctxlo20/zwWy8eKcJGSjWmE4PlsNw=; b=XkEEiOda7BIR2mVnK092S2bODXWG7EsY4Zkxfxw0sMhUIreVD8LDVqQuMDPWkP3hZsrY1a Iz3fMF6ThY+lqxn+6sMFeGCf/7o2919lhidOB+Jxc/KxHv51xOcDBeh8nKMxyn7lcN2fHJ CgRstqSeRWGhKE+smkZa+RarMZ+qZjzLa3DJYkyNkat0WQsvFRzsMmb8tQdpWM54VNkgom DlYu2p1+7kNxd1oiTb72HSNUQFoaP3Sc9fd8C8HBD6yM9DfHmPXa5Tfwn/I+uKciDWfmI5 IFjRBpOkxZodj3AheoJcBc8qBFe+nZAkC4HPcGWv35Xvh7t+ewitXJAkYIK2eQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727671522; a=rsa-sha256; cv=none; b=jUh3AslLFUuCpW1biCkV4seujmudad4xyt+8tkTTZPHVeB0Qmm9RqAgZ5p9gHyJhUqS1fc YgIB952fUH747wj6/vOH/A5TQKdjOnv2TR0gqZN8w6vg6imaJ2ah9+CjoWeKGK2lksa73X pXDFUoKKsvGYiqDE4u6iD0ntI2r8DJHRzhNqucCh3BhzzZMnsAFVVzsxvfkgzGLgGeXPgB KAH7iQ8T6/EW0C2CnAj10GtumDlK35kkIXvKCDCUbvTFkYKJZuIn8dAGWHDGAa9fb43sBT ikkXuOdDd71QdD8HvtnWpVvkXpD7gCbMYEhMn8uS9tThUnJ3PmOxiHMpNnUygA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XH7mL4gC8zf2F; Mon, 30 Sep 2024 04:45:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48U4jMQS086821; Mon, 30 Sep 2024 04:45:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48U4jMSO086818; Mon, 30 Sep 2024 04:45:22 GMT (envelope-from git) Date: Mon, 30 Sep 2024 04:45:22 GMT Message-Id: <202409300445.48U4jMSO086818@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 74887e322101 - stable/14 - al_eth: Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 74887e322101cbc9e531e3acd08a6eb10dd2169e Auto-Submitted: auto-generated The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=74887e322101cbc9e531e3acd08a6eb10dd2169e commit 74887e322101cbc9e531e3acd08a6eb10dd2169e Author: Zhenlei Huang AuthorDate: 2024-09-03 10:25:23 +0000 Commit: Zhenlei Huang CommitDate: 2024-09-30 04:44:19 +0000 al_eth: Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D45852 (cherry picked from commit 00ae9c1be02e2db6ede1abd5b787bb9a3fbd76b0) --- sys/dev/al_eth/al_eth.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/sys/dev/al_eth/al_eth.c b/sys/dev/al_eth/al_eth.c index baf47ac1d378..b4fbf041660b 100644 --- a/sys/dev/al_eth/al_eth.c +++ b/sys/dev/al_eth/al_eth.c @@ -2005,14 +2005,6 @@ al_eth_enable_msix(struct al_eth_adapter *adapter) adapter->msix_entries = malloc(msix_vecs*sizeof(*adapter->msix_entries), M_IFAL, M_ZERO | M_WAITOK); - - if (adapter->msix_entries == NULL) { - device_printf_dbg(adapter->dev, "failed to allocate" - " msix_entries %d\n", msix_vecs); - rc = ENOMEM; - goto exit; - } - /* management vector (GROUP_A) @2*/ adapter->msix_entries[AL_ETH_MGMT_IRQ_IDX].entry = 2; adapter->msix_entries[AL_ETH_MGMT_IRQ_IDX].vector = 0; @@ -2300,9 +2292,6 @@ al_eth_setup_tx_resources(struct al_eth_adapter *adapter, int qid) size = sizeof(struct al_eth_tx_buffer) * tx_ring->sw_count; tx_ring->tx_buffer_info = malloc(size, M_IFAL, M_ZERO | M_WAITOK); - if (tx_ring->tx_buffer_info == NULL) - return (ENOMEM); - tx_ring->descs_size = tx_ring->hw_count * sizeof(union al_udma_desc); q_params->size = tx_ring->hw_count; @@ -2325,10 +2314,6 @@ al_eth_setup_tx_resources(struct al_eth_adapter *adapter, int qid) mtx_init(&tx_ring->br_mtx, "AlRingMtx", NULL, MTX_DEF); tx_ring->br = buf_ring_alloc(AL_BR_SIZE, M_DEVBUF, M_WAITOK, &tx_ring->br_mtx); - if (tx_ring->br == NULL) { - device_printf(dev, "Critical Failure setting up buf ring\n"); - return (ENOMEM); - } /* Allocate taskqueues */ TASK_INIT(&tx_ring->enqueue_task, 0, al_eth_start_xmit, tx_ring); @@ -2477,9 +2462,6 @@ al_eth_setup_rx_resources(struct al_eth_adapter *adapter, unsigned int qid) size += 1; rx_ring->rx_buffer_info = malloc(size, M_IFAL, M_ZERO | M_WAITOK); - if (rx_ring->rx_buffer_info == NULL) - return (ENOMEM); - rx_ring->descs_size = rx_ring->hw_count * sizeof(union al_udma_desc); q_params->size = rx_ring->hw_count;