From nobody Sun Sep 29 04:01:56 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGVrj2YGwz5YGsr; Sun, 29 Sep 2024 04:01:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGVrh61Xpz4cP3; Sun, 29 Sep 2024 04:01:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727582516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hFedaG3m5HGajs7GC2HQ04V2+jODvf1zV+MHpnGubxM=; b=Zqho8BTFRUR/U0vMs79ehciAGsYWXRGlAXyWdv7GfRQfHO1aoro4pOAMUr7Dp0H85V+qIn Yf5d3H94o5YAnF0Rjh+O5giRks3+l81O95Z4l1WnTEqpCD6AoArr65UBMWakgOgV9ZuWr2 VwWHU1Wvpmkp1oDVW19qIY5lIGUF/kuPQ3ebKOpKUFnqrlE/eHdvVGPEMeXx0gg6LU9Jt3 m9pIXlc6gLgZ2XXJYzf5t/aal350FcnY0XAT2ekN4vl6oE/LyDdJ55ugiE/4rP1cYl4RdH UGa6lO5OoYQZIDKIAYxbftypsyNzkjFZ8XDydDDl+g8d86v+Ava1FhbwGkdY2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727582516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hFedaG3m5HGajs7GC2HQ04V2+jODvf1zV+MHpnGubxM=; b=oJkvCJxMyuV3Ru6hI1AFUZmTjN6Gxki7RaBd41g383wUEJDrRmH7Txqa+XPOgb7b3IC38W Sr+0CqOuRFoTcD1uH0fzjQnB5e9Mys3FDDCyC9nSXNY4hpN52iGujbbmF+wKshAlLfxMZl C4evhAMncVua16wf0Rcf6+V0wqHgGfp4+FKoGer+m/QzRkqW5LMy9srTGTzxWSSpHcneaP AuCxSDTtcMufeISnLZM5wlz0IxY51F8cX+RpNlv4naPNim3o0cfxIyMhj6Y974vfOuSfZW MBRrQ3UVXu1dkDv19nlagUO/CYvioVIP36jAE8Psm2xgTN/nsp1amJq24axx2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727582516; a=rsa-sha256; cv=none; b=t1H5Kp+AncVXGMHIPHlrjv9qw4aRVuMU2WCvyzbvULUUw4iCnum5Ee1D6EqXo0V0x5xOB7 hCObSAfJQElCeUY0wzcdbBKKEvEefLnhKlCgARRidQGJzU7VazpwXj5t4DXNoa4LUjEmKp oMHvKZRdheFy/o3seOp3gDEAAtzlnmjGSN1ps37YooYfys0dc2xoUR6VYgQs/ZRbWtfApg RY87WjGsjrTYL/8SkFqE8ddlH/guY9fyFljiQYVC2rv7VxuOfg2yHS4S6G85ltbW/VZmLY c70D6QwRjbJz5oLwKCjBdeXfmRhUMKnJPuuR3z//pXU4ohi80t1TG3EgrN9tgg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XGVrh5MN1ztZm; Sun, 29 Sep 2024 04:01:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48T41u5P080437; Sun, 29 Sep 2024 04:01:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48T41uNm080434; Sun, 29 Sep 2024 04:01:56 GMT (envelope-from git) Date: Sun, 29 Sep 2024 04:01:56 GMT Message-Id: <202409290401.48T41uNm080434@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 288ad162e68c - stable/13 - qlnx: qlnxe: Fix kernel address leakage List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 288ad162e68cb239069b2886ee887e6ca0ac2b7a Auto-Submitted: auto-generated The branch stable/13 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=288ad162e68cb239069b2886ee887e6ca0ac2b7a commit 288ad162e68cb239069b2886ee887e6ca0ac2b7a Author: Fuqian Huang AuthorDate: 2024-05-28 05:45:52 +0000 Commit: Kevin Bowling CommitDate: 2024-09-29 03:59:36 +0000 qlnx: qlnxe: Fix kernel address leakage In function qlnx_rdma_deregister_if, the address of object rdma_if will be printed out. rdma_if is the address of a global variable qlnxr_drv, which is passed from dev/qlnx/qlnxr/qlnxr_os.c A kernel address leakage happens. Fix this by removing the printf statement. PR: 238646 (cherry picked from commit 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf) --- sys/dev/qlnx/qlnxe/qlnx_rdma.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_rdma.c b/sys/dev/qlnx/qlnxe/qlnx_rdma.c index 522ef74cf9ce..e5b7c1a62e01 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_rdma.c +++ b/sys/dev/qlnx/qlnxe/qlnx_rdma.c @@ -256,8 +256,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if) int ret = 0; qlnx_host_t *ha; - printf("%s: enter rdma_if = %p\n", __func__, rdma_if); - if (mtx_initialized(&qlnx_rdma_dev_lock)) { mtx_lock(&qlnx_rdma_dev_lock); @@ -288,7 +286,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if) mtx_unlock(&qlnx_rdma_dev_lock); } - printf("%s: exit rdma_if = %p\n", __func__, rdma_if); return (ret); }