From nobody Sun Sep 29 03:56:49 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGVkn5kPfz5YGdg; Sun, 29 Sep 2024 03:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGVkn2krxz4YR8; Sun, 29 Sep 2024 03:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727582209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J5OAFfqvY6emkLBsFXT/qeTKImhftC5+nwSB+cOwJaI=; b=WETeWoSBXZxMtsz4Lu5xv4zg/BsFiFnVdrL3TNq71/UeCQqp4nuQMV1t4njqLEf3vdp6We x9QycaErLKMsN9dHngjv4h3POzGqMdER4bRcUzNVhEfoRZnZRVD6fvm2sWPjKutTLnjdtO MqVJ5LVEsZDPc7OKu+oWs7AR1pSdYVeiz8ZUVAJzE3Rab+TjCNSEkcjtVbQy2+1lgDkMBK 8rTko7nhtxT7a4FqGkeMrVmCt7iX0HlPxgmF1o3PGO/P24STjjxzTTflY1c+ekV9xgoRCu OCSxPJdEQqgB+EiIXguHaAOeNz7lN4T9HUE8CvAggju0zC8ww8KwLeurshetfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727582209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J5OAFfqvY6emkLBsFXT/qeTKImhftC5+nwSB+cOwJaI=; b=Rsms8EV12f4IuiKBwGtLwcqBoK0TJE0g93Z8APtlgHWKM/Sh1fixKHg1iPeH+Gx7RR7DtD qYrrvfvuJv+uc387Mjo/aQITcqpxZaR+LuMapdhdP8aBiCFeeykP8ZqjCw0eOqoqd51t4f zP95OADkocLHKCbt9Z+/pY8K7s9Hrgxea7LzSW3oLuVQIpvnaiN/rICojRQ2q3o7uDEsUs j+5isPy3gQzkj3oM3Dhf8A0f2utGngVIwWcRHNhbJpSWjoYLtW/xpy0SthzDuo7DnwFqqa QJcTcPO0Kz7dpNglKpzWRArcw2w3645hw/B0VnfYRyi3kQWg9uPITNR7KE6Ejw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727582209; a=rsa-sha256; cv=none; b=ZlmV9qIpOXM+9Qad1KwXIrQfrqDfgaBSUjiSyxWSsKgOE3DhKYluRdrqN/KnLcdNNK8VdF 7iI0W3sMHluuWddDBoXF9C41wCRaPOIw7dkPD7YEWaEiOo4d2F4rEq4dJw0Zg4MtSIUSQF I84oL6fUDXz9i0+l8RXDfYHf/ZMP45oGDuEEmGqrAgqK2Tbhesl80Mm6nL2zT+J1xcvRuZ 1jBGWzg9OXsyt90tR+XbugBIUQcytAjeAZbh5FmF7WCF4kseuxlCG4ctUkyYbulV/gaMgg E2eDgtIE8vIz/O1dVTA7wY0VbhILG445vNbzjsN2QNq+dxbVl9LKmNlV89Et8g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XGVkn2498ztLX; Sun, 29 Sep 2024 03:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48T3unKX062415; Sun, 29 Sep 2024 03:56:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48T3uniG062412; Sun, 29 Sep 2024 03:56:49 GMT (envelope-from git) Date: Sun, 29 Sep 2024 03:56:49 GMT Message-Id: <202409290356.48T3uniG062412@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: c16093be8a1a - stable/14 - e1000: drop NEEDGIANT on em_sysctl_reg_handler uses List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c16093be8a1a777e8277e72fce3dfbe0cf13b38c Auto-Submitted: auto-generated The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c16093be8a1a777e8277e72fce3dfbe0cf13b38c commit c16093be8a1a777e8277e72fce3dfbe0cf13b38c Author: Kevin Bowling AuthorDate: 2024-09-22 04:04:38 +0000 Commit: Kevin Bowling CommitDate: 2024-09-29 03:56:34 +0000 e1000: drop NEEDGIANT on em_sysctl_reg_handler uses These are simple singular diagnostic register reads (cherry picked from commit c11a0649b97281699e39d0fc82818f235c1dfb87) --- sys/dev/e1000/if_em.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 768522a821bd..8d140979fbcd 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -4433,11 +4433,11 @@ em_add_hw_stats(struct e1000_softc *sc) CTLFLAG_RD, &sc->watchdog_events, "Watchdog timeouts"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "device_control", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_CTRL, em_sysctl_reg_handler, "IU", "Device Control Register"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "rx_control", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RCTL, em_sysctl_reg_handler, "IU", "Receiver Control Register"); SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "fc_high_water", @@ -4455,11 +4455,11 @@ em_add_hw_stats(struct e1000_softc *sc) queue_list = SYSCTL_CHILDREN(queue_node); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "txd_head", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_TDH(txr->me), em_sysctl_reg_handler, "IU", "Transmit Descriptor Head"); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "txd_tail", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_TDT(txr->me), em_sysctl_reg_handler, "IU", "Transmit Descriptor Tail"); SYSCTL_ADD_ULONG(ctx, queue_list, OID_AUTO, "tx_irq", @@ -4475,11 +4475,11 @@ em_add_hw_stats(struct e1000_softc *sc) queue_list = SYSCTL_CHILDREN(queue_node); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "rxd_head", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RDH(rxr->me), em_sysctl_reg_handler, "IU", "Receive Descriptor Head"); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "rxd_tail", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RDT(rxr->me), em_sysctl_reg_handler, "IU", "Receive Descriptor Tail"); SYSCTL_ADD_ULONG(ctx, queue_list, OID_AUTO, "rx_irq",