From nobody Sat Sep 28 03:36:11 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XFtKR3fXnz5Xg3y; Sat, 28 Sep 2024 03:36:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XFtKR2vQzz4Pv5; Sat, 28 Sep 2024 03:36:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727494571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OgHjJFVjbtK0SKakzFQXk4g+3ZRP9FoN5/X0wmGaZ0U=; b=UOkA+RbY+SghqCXoTvApWIK1LEyGqPVwOMVuDH5Kt49jQJyuVxG/qRBs1ucAPct1ZsdrJu QK00Id2PiZNMrxD0zvYNhXT45qy0N2VtMDAAPJAbvWe1Yb8tZsA8abv1yA5+Ey9NzKH0A+ tdB2aNyJo/lzgQ/XTVAC1wjIXhP6jbySzWHMm9jwQkVTlT5DTXkdrQsl+T/BEgEVm7uf2Q dddcfGMyTNsLMT2pEDIDcl9fVD/46Ac62lfylX74EUalh+oGQK0AJuWBbc7hJiofRxbCf8 9G0sg2Knff+vW5sz8W0BG4QHdmTjs5ecQ/V2FHDH+N514MkCbD1GJfjle4lvTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727494571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OgHjJFVjbtK0SKakzFQXk4g+3ZRP9FoN5/X0wmGaZ0U=; b=aOv857czi8g5kIwcdLcK5OCKjpLvQ5rH1XR9VKPDVmrban6ZpRXwb1DfxuDPS3QUzeYPSB U/qLVFoA/jiKH/tAawdoAzRvyN9G2vVy2Zvc1e8gonI95vmIYBdTC4JVf6HT3HnZjCGiPI A4mUXOUp4xnQB1i9eoGWD1jiFLDU2WSqpidm8oQziskk02nqZZV6omVmT45B4uZocO/jsq fEvIh7GpQPNnOGrdqwxZClRCBsUAI8THOui2cGJz9NEQZkyTC1FOmwg8RnJi9BeaMweByY vnjaBBKygDf/GkXCytTxG9XLmTcfeUuXWj4kT+DxLarIfAgicMQk4XYafdbC+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727494571; a=rsa-sha256; cv=none; b=GxGdQKj3aIpJzxuqnhWUrro70hXBTqA3aQ2lJURwi8i9VPJjBee9J6uL3reEhcq9jcMp77 bzljFFp1SR68A6/X6gUBXolYIgeEITtfVBJaK1O092gPNLT6aMVITA9ygJO9z0dZNmOOZo r1ESiCcPIU6rJGvI5q/JPnZb4FVi5rugg5n8WOzLalBqO7ENR7csSGwYp2keRoLf2qSWrd iM10he7zbAiqgA2frS+tVHqM0n85Ty8d4rXYuxxbeIVpoycUG8MN6WaMwQV3Zz1UZvfI1Q 8RamE04BCAqvioTHv28PR7gwGxe5+jb2hZPSX7ar4hf+Um2IEoZMZztZhVECWQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XFtKR2WWFz17F6; Sat, 28 Sep 2024 03:36:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48S3aBq3082238; Sat, 28 Sep 2024 03:36:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48S3aBJM082235; Sat, 28 Sep 2024 03:36:11 GMT (envelope-from git) Date: Sat, 28 Sep 2024 03:36:11 GMT Message-Id: <202409280336.48S3aBJM082235@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 26439b57877c - main - e1000: Remove redundant EITR shift from igb List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 26439b57877ccae7a2404f7d179afaa5ddb2f64d Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=26439b57877ccae7a2404f7d179afaa5ddb2f64d commit 26439b57877ccae7a2404f7d179afaa5ddb2f64d Author: Kevin Bowling AuthorDate: 2024-09-28 03:34:18 +0000 Commit: Kevin Bowling CommitDate: 2024-09-28 03:36:00 +0000 e1000: Remove redundant EITR shift from igb The E1000_EITR() macro is already multiplying by 0x4 which is the same as this shift, so we were shifting more than expected. MFC after: 6 days Sponsored by: BBOX.io --- sys/dev/e1000/if_em.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index 7219dc57c333..83a0d4e96fc6 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -251,8 +251,7 @@ #define IGB_ITR_DIVIDEND 1000000 #define IGB_ITR_SHIFT 2 #define IGB_QVECTOR_MASK 0x7FFC -#define IGB_INTS_TO_EITR(i) (((IGB_ITR_DIVIDEND/i) & IGB_QVECTOR_MASK) << \ - IGB_ITR_SHIFT) +#define IGB_INTS_TO_EITR(i) ((IGB_ITR_DIVIDEND/i) & IGB_QVECTOR_MASK) #define IGB_LINK_ITR 2000 #define I210_LINK_DELAY 1000