From nobody Wed Sep 25 14:02:22 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XDJMM0XSNz5XW7k; Wed, 25 Sep 2024 14:02:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XDJMM03tzz492g; Wed, 25 Sep 2024 14:02:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727272943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7rsCOFFpN1b+sP0l0FMmt653WWTb3CXduVFeboZNMWU=; b=xl7sUVqLMqcjC0qu1SRZtkKSCHcs6QobOrd0vc1B2ADlVTPKUO7A94+NxSTn3koPnjJrt9 zCvx1/DZ73lrd+qGRgfSEMtsc1OsQdU8YynGQQnq1WcHPRntgCbfoYj0UcHkEqZuSOpV67 50iLrNjAmF8KQQymCYStPC3uSLFDbkK9FBkuSDyqq3hga7MclP/Vy2dv2gZqu5qOJi6ZhX 2eW9kqSLPpmyQWdRw3r7dpbq9teGXC4aTTy9xvTAf4etG4B6cRuitZuF2O25D2jDxAgsl+ ZV/FI8L6YHYYnzCW69DjK9YZpA2P1zFSo+XPW6d4PBfIvTV+vMWLktz7ViwwEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727272943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7rsCOFFpN1b+sP0l0FMmt653WWTb3CXduVFeboZNMWU=; b=mZcijuwXnbh84Z0Hlf/PIe+/SlUzC3SkMj7FQJckamqHdIf0+y5Z8xVCtsQrSl/D+vLoVS OB2UTlx08ZU0hgWdBJEqdVOCvTupM3lztOL4uSk3wU7NLpr+a9CrQhx5fb0pdQ0bnaIQse +HApkcwCa27qmfEQmdwzNbHoURA4tVMuBUP7fcv7kvgvIyO6N97DsDdqF51ZsdjF2hL8yb 5+CV1+o0x7Q1MoXiu3DqfvKoLJxuYPAiG80mIo3vZPuoT94mxNk+rYheULy5Bep4Vzh69r 6mhKX3+7bMsMLA3Zd1f9yn81Zx8n5bxVlRUlUyaEDYDhj5U8LfGqA+rz06FjZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727272943; a=rsa-sha256; cv=none; b=BY/9Rv0WUrv/fTCXwoFA23wB+pDFAmNSUlhI7y70ZWRnVpnmkShz864BLaNi0hTGZogao4 LyuFNQQgTUqg6SNap/mECIUDv/pmtn2ZnIYDTkI+mreZJ29d6SHhIAX6nq6WYDNx8qdmnu i0T5OxoX0L/0pj7vya9Jo2/EnCuGXfCALx5Ujxt7HKBHdRP2mOfGjEMzk5UTkxmyf4XvHY VzKmDesvUE16UlnCBN3nfdEgObDiBv5sGgRRIysJ5XNDbnei7sHix8P8htJZUu0MsgCqfc g1nlEIQ6q8A28vyIOdhSvyT9PPYWWIg4IN/3vUT5taHfRwSy6DbngFoLZnr6Kw== Received: from [IPV6:2601:5c0:4200:b830:7d5c:2819:6552:855e] (unknown [IPv6:2601:5c0:4200:b830:7d5c:2819:6552:855e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XDJML5Dzmz13H2; Wed, 25 Sep 2024 14:02:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <88935da3-253c-4145-b958-f7137485ee31@FreeBSD.org> Date: Wed, 25 Sep 2024 10:02:22 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: a52b30ff98cd - main - sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf Content-Language: en-US To: Konstantin Belousov , =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> <867cb5z2c3.fsf@ltc.des.dev> <86y13lx7l5.fsf@ltc.des.dev> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/21/24 16:51, Konstantin Belousov wrote: > On Sat, Sep 21, 2024 at 07:03:18PM +0200, Dag-Erling Smørgrav wrote: >> Konstantin Belousov writes: >>> Dag-Erling Smørgrav writes: >>>> Konstantin Belousov writes: >>>>> commit a52b30ff98cdab82af140285fa7fcdf1036fef27 >>>>> >>>>> sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf >>>>> >>>>> Tested by: yasu >>>>> Sponsored by: The FreeBSD Foundation >>>> > MFC after: 1 week >>>> This appears to be the opposite of the patch which you posted on >>>> -current and which yasu@ tested [...] >>> Before committing anything, I did a self-review and remembered that I >>> have did a lot of considerations when implementing swap accounting and >>> decided that ruid is the right target for charge. >>> >>> Besides stating the obvious fact above, what do you expect me to answer/ >>> react to your mail? >> >> My point is that the commit message claims the patch was tested by yasu@ >> when in fact it wasn't. If you're convinced that this is the correct >> solution then that's fine, and it does appear to work, but don't claim >> that it's been tested by others when it hasn't. > > The main part of the patch was to ensure consistency in updates: it must > be either always uidinfo, or always ruidinfo. Which one specifically > would affect the limit's semantic, but not the buggy behavior you reported. In similar situations with reviews I've sometimes added a "(earlier version)" suffix after the annotation, e.g.: Reviewed by: foo (earlier version) Using a similar annotation here might have been clearer. -- John Baldwin