From nobody Tue Sep 24 21:48:05 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XCtlR0BdRz5W716 for ; Tue, 24 Sep 2024 21:48:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XCtlQ2nvJz49pJ for ; Tue, 24 Sep 2024 21:48:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-7db12af2f31so4979549a12.1 for ; Tue, 24 Sep 2024 14:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1727214497; x=1727819297; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W4XE3t3y8IBskp5t2KNEoJWC1nC9Hvd30JbhBuV7nfg=; b=FW48GBUYVxoZchT+34NPWrAsCTKAMUYyKzdFfMiYAwQ7wZ6wZAFU8Gv906JLRJIKTX HTqJxfwIAr4O7Gwhh4GJQ2EGv20AHTR+ky4g9mbYTn2A09Xz22zEjIJFLim+HfCR8UOr TRrMMNX8J7mGnikWV9RrBEGVBO/a3LLhQ9PhK3GzlktXNEOR/gH1KuFHJE7lkjs/Auho 2OhbrWYm6cvg4baqu07p+oLey176q1B0f4Ew6anwEdCxgHsqExTJMwnZ2IH6RGWnoUt/ vjpdQoVySL3tJD3AA5XdMT/3TkaIZ+eq9YCPRKjNyzkjE8eYIBpBc8FAviy+avErx9hC 5lAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727214497; x=1727819297; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W4XE3t3y8IBskp5t2KNEoJWC1nC9Hvd30JbhBuV7nfg=; b=r+rh0Ohtn5UKXXx0I3eR2hwSGea0DIxVxCYllZ4mVqw3qZ2TwhOrwoA16eI7Vx1ox6 MXv1/hc4t36J5xVcRaaXT8+vMA2m9uhHe1eytKxWt6t7QD/AuCriA1yXC+AKHbGu1zzN ly54TGlL2FpLLqEJ1bTmolkJi7hzhPtiyM1AQbAu8vdQfvqDlIYg8halkDxe+aTeHfJC RkWcrgCIzNz/4xmgDf+EkAgnuR+3O0nkZXd+sqvM/rPB98m9hOPgCWKwI5i6JLP27oQM eNhuP9VILGEZ8hvMBXa4VhtPmvpKQmqwagaE16RO2SgCILs22wDh4UH0ZpZOAlhLOzCs tC/Q== X-Forwarded-Encrypted: i=1; AJvYcCUFaNfn2j2/ba5LjgVeMM+ADOPbwOdeuovFn9izuWfd3bnm+SShgekqGmKDATylUjBbuaaJuWnWq3m3VD71jnWbki6C@freebsd.org X-Gm-Message-State: AOJu0Yw1NDwuFaOBQYOXAiZzU22iXVStemPi1T5UjozDuDjg15H6Ay89 IT6kE0pPPMhsQ2KmsncFdXpWZlF0fYJFVmywpfkv+G3e53W7011gfBaN8kpz663UkaCdUIXXLUb 8gt04EPlgcjvYWdPVdQkGyyxRL1VxuIjvkvI8TQ== X-Google-Smtp-Source: AGHT+IHnfQDRPQYDseDuSKxLQUqWSwhYHNhmK/lFAaUrzVVABxoPqbp4l//HmhR/Ca6y6aUW2uOiCP/Uf2ikHP5M92M= X-Received: by 2002:a17:90a:9382:b0:2d8:8d34:5b8 with SMTP id 98e67ed59e1d1-2e06ae5e28amr737110a91.10.1727214496821; Tue, 24 Sep 2024 14:48:16 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202409242119.48OLJOws002720@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 24 Sep 2024 15:48:05 -0600 Message-ID: Subject: Re: git: 413c5e9082a7 - main - Merge remote-tracking branch 'freebsd/vendor/Linux/ath-common' To: Jessica Clarke Cc: "Bjoern A. Zeeb" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="00000000000088d00a0622e4765b" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XCtlQ2nvJz49pJ X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --00000000000088d00a0622e4765b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 24, 2024 at 3:33=E2=80=AFPM Jessica Clarke = wrote: > On 24 Sep 2024, at 22:19, Bjoern A. Zeeb wrote: > > > > The branch main has been updated by bz: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D413c5e9082a7d1d25fd3a95f0e77a94= 9621f1433 > > > > commit 413c5e9082a7d1d25fd3a95f0e77a949621f1433 > > Merge: 604919c47fa4 9c6b6723ca84 > > Author: Bjoern A. Zeeb > > AuthorDate: 2024-09-24 21:06:19 +0000 > > Commit: Bjoern A. Zeeb > > CommitDate: 2024-09-24 21:06:19 +0000 > > > > Merge remote-tracking branch 'freebsd/vendor/Linux/ath-common' > > > > Sponsored by: The FreeBSD Foundation > > Hi Bjoern, > This slew of merge commits has zero context for what they=E2=80=99re actu= ally > importing beyond the branch name, which goes against the documentation > for how to do vendor imports: > > > Include details about the changes being merged in the merge commit > message. > -- > https://docs.freebsd.org/en/articles/committers-guide/#_updating_the_free= bsd_source_tree > > This is unhelpful for anyone wanting to understand what you=E2=80=99re do= ing. > Agreed. However, I looked at these commits. This is bootstrapping vendor branches for software that had been directly added to the tree before. I should have had Bjoern mention this in these merge commits, but it didn't occur to me until after the commit. Warner --00000000000088d00a0622e4765b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Sep 24, 2024 at 3:33=E2=80=AF= PM Jessica Clarke <jrtc27@freebsd.= org> wrote:
On 24 Sep 2024, at 22:19, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: >
> The branch main has been updated by bz:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D413c5e9082a7d1d25fd3a95f0e77a949621f1433<= /a>
>
> commit 413c5e9082a7d1d25fd3a95f0e77a949621f1433
> Merge: 604919c47fa4 9c6b6723ca84
> Author:=C2=A0 =C2=A0 =C2=A0Bjoern A. Zeeb <bz@FreeBSD.org>
> AuthorDate: 2024-09-24 21:06:19 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Bjoern A. Zeeb <bz@FreeBSD.org>
> CommitDate: 2024-09-24 21:06:19 +0000
>
>=C2=A0 =C2=A0 Merge remote-tracking branch 'freebsd/vendor/Linux/at= h-common'
>
>=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation

Hi Bjoern,
This slew of merge commits has zero context for what they=E2=80=99re actual= ly
importing beyond the branch name, which goes against the documentation
for how to do vendor imports:

> Include details about the changes being merged in the merge commit mes= sage.
-- https://d= ocs.freebsd.org/en/articles/committers-guide/#_updating_the_freebsd_source_= tree

This is unhelpful for anyone wanting to understand what you=E2=80=99re doin= g.

Agreed. However, I looked at these c= ommits. This is bootstrapping vendor branches for software
that h= ad been directly added to the tree before. I should have had Bjoern mention= this in these
merge commits, but it didn't occur to me until= after the commit.

Warner=C2=A0
--00000000000088d00a0622e4765b--