From nobody Sat Sep 21 17:03:18 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X9wZ10qRCz5XVLZ; Sat, 21 Sep 2024 17:03:21 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X9wZ05pb8z4pnx; Sat, 21 Sep 2024 17:03:20 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726938200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kiN2FyIFJYGKfqNz53IYBuvh+la2OtmN+CvYY6TRn58=; b=tIjWxOi0UOug4TyWB2+mISKHVt5lUEmwXq7LR9UhK+ZeKYFU2XQEGe0N1hrk8I5mJ4oxM/ FcVgJAuE9+dO8wHyY4BObwG/IidtvpABl94PpYP1LjEAcYKXtg2yiv7/AKz2Uzz89bjLd0 Fax8HhY46usWA50p/eMvYBT2a1IXc/WNPXaaVOpXCeiY4pbWlbP+XbyDqywAofgxdV/1xa gCj2Bhc4oM+gb68soTWF5s2oUPlmirf9/wKd+DxK6gSolKvN/Ut6u1th2wUNuQf7aFo97I +dTyHkiKy2kg7wx7RHxt9WEQK1XUXa1x63dgNmGCy0gom8Dkv0q6ghcNMWyX+w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726938200; a=rsa-sha256; cv=none; b=AXSIE+MFeIY/KdQjNcnAC4A+FiUP3wcJIECXgCxC720wU0K9S4R6CuOtE1tt24kH8EwcfJ 4FvwQR78WaRE+/BMLnwaOvgjY1brFDzs6wPXtVqtjUN3QCUZkJqkUxlub4DAGVeaft+zJJ TFCEBsFaiKk1THWBqVAgxD0Cq42Ao5cp+NIxn2tN9biS650SUN5dgJaqgNaYiI/OQFBkec lLyfU8zXR3kc368jfT5zX/+UvXGcpDyJ+xUin+OO1RaPTxIoOjF3P3mxt5xeTzoVSouxH4 0pEl59Wf8kp2Ao0OsDuYFa7rFajt4nB40VPKlWJJpEVJTu6sB1fxjEEog7jimg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726938200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kiN2FyIFJYGKfqNz53IYBuvh+la2OtmN+CvYY6TRn58=; b=nOlrM8E2/ZUEnAwiWL/23Y7P0//joo0RKD85oA/N0g1KdK8s56lOln8yDF3jLKM5M1mSrl lcxBc1g7/getewrUVLTsos4LGepEt0GkBrkpwY0kaJhsBRehkOiQSmtG8mP/FprbpS3n1l t82Sc3q1dAqo36ZTSitqI4A9EepGf8nFW6B3NpzMtT/88abYR8X+YlV+Put8VpKQpqXqRx pBWrjpcoHmLiNjswYaVUudyA7RsFwNzDfgO1kL0a8qQJF641GlO6IN9UJVnUzGZU4tc27u mEVtAXdUpLPH1AvtgrPK7w8+5J0WS1mlZRnjJKDESgFfLBR8rdrLbjnwzOQ0Bw== Received: from ltc.des.dev (unknown [91.174.26.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4X9wZ04XcCz15gZ; Sat, 21 Sep 2024 17:03:20 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id A6629BF117; Sat, 21 Sep 2024 19:03:18 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a52b30ff98cd - main - sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf In-Reply-To: (Konstantin Belousov's message of "Sat, 21 Sep 2024 15:49:53 +0300") References: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> <867cb5z2c3.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 21 Sep 2024 19:03:18 +0200 Message-ID: <86y13lx7l5.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Konstantin Belousov writes: > Dag-Erling Sm=C3=B8rgrav writes: > > Konstantin Belousov writes: > > > commit a52b30ff98cdab82af140285fa7fcdf1036fef27 > > > > > > sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf > > >=20=20=20=20=20 > > > Tested by: yasu > > > Sponsored by: The FreeBSD Foundation >> > MFC after: 1 week > > This appears to be the opposite of the patch which you posted on > > -current and which yasu@ tested [...] > Before committing anything, I did a self-review and remembered that I > have did a lot of considerations when implementing swap accounting and > decided that ruid is the right target for charge. > > Besides stating the obvious fact above, what do you expect me to answer/ > react to your mail? My point is that the commit message claims the patch was tested by yasu@ when in fact it wasn't. If you're convinced that this is the correct solution then that's fine, and it does appear to work, but don't claim that it's been tested by others when it hasn't. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org