From nobody Sat Sep 21 11:13:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X9mpk5qDlz5Vpmh; Sat, 21 Sep 2024 11:13:50 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X9mpk5JzQz4lSh; Sat, 21 Sep 2024 11:13:50 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726917230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHlSJV/ZT2zJpE+Wbdptyw9ULF9AUheBUFMrE+bd7WI=; b=eRwaxnrdthKLc88HVqLEp8J+WwYz+eO/BVq3SrzJxuRVyG9pcrO/x8Z5omGkad7SKG9fCA Ke7AU+3RBZGqrLpvbZ7ojsuTstPeWqT+wHsdYkznxDEE1ez9k2YbcpiJ4jiOmO7juhUJ4d oI/ruuI34/JelDhUUqSn9ON7prOGx+P7D5PVy+8Tb09fo1xkYLFbKQ2+zwo6RFF4WmXg4u eJS7dlarLa38d9rQrw+UVwMVeZWg8A2kiOTlkF2jvkXwgwEd8ZIbUCmKhxsPQ5N8W95Oax aZvAi/gXLeUvPrxUpPEtfRCU2kAj57W/YU9sF1sXYPvV48gyVN2NJO3KJL2qlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726917230; a=rsa-sha256; cv=none; b=StQsnXSu48kA02utvk6D4vAZNiftsynpUb012nhiucCfTEZqx1Wot/pmKhs9VLkdJjBGqh aXpcLoUxMMtGBisoEbNEG0pNIoCb1RYzQkoCW9uAhzPJef1O2ubUK2uIywrXqQfeAoepFe R0ikZ+yuxdtYjC9SZePsMfN7z93ArOeqFmwHF5imDDirNw0liL37VgLdoYstJ7vePdEJae P+bve9qLm4a48MVuAN9H2IRrOZ+1LVApP3VpBHysZZChO/VwtwlK83M/zik669Kn+AQ2fc j+iEp1M72Sd+dAMlAbIfnwj1tTcTeR9JjdHl+yT/PhJ01+2r/6kbG2hZa5mwcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726917230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHlSJV/ZT2zJpE+Wbdptyw9ULF9AUheBUFMrE+bd7WI=; b=fhRaSgPqyv6drQnY+sDyg3UGIhZn5v6fIbmPQ7v+qg1Q7W8/jBBhAnYfYth+CaQIA1itPK 4GkuQxgn8bO80usRT5GbtI16u3I6CfXuDuSMy44cyNwBylpbtC29Kcp2Pn9vhkkZV/iJOF tYFiGZpo/ENF1AMJdjcMdYoUlDt/K0JROfoBg32Ge9WvVc4zymDjgQhpetfvzOe2QpokBn mA1fyi3ZRNtF8Zp8ak1uhgEI09+z6y3yxg7yY7xpZEPNUrvEmyNnZKyLe/meFzhQKSly3/ z3AVRBPfRBaL+Nk8yxX875HbCaEQqCSQYzUETXakj7tgqJLa+xX/EMen3WwB7Q== Received: from ltc.des.dev (unknown [91.174.26.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4X9mpk4JrbzjZK; Sat, 21 Sep 2024 11:13:50 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id D6B4DBF3AB; Sat, 21 Sep 2024 13:13:48 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Konstantin Belousov Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a52b30ff98cd - main - sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf In-Reply-To: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> (Konstantin Belousov's message of "Fri, 20 Sep 2024 21:09:27 GMT") References: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 21 Sep 2024 13:13:48 +0200 Message-ID: <867cb5z2c3.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Konstantin Belousov writes: > commit a52b30ff98cdab82af140285fa7fcdf1036fef27 > Author: Konstantin Belousov > AuthorDate: 2024-09-20 18:48:19 +0000 > Commit: Konstantin Belousov > CommitDate: 2024-09-20 21:08:51 +0000 > > sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf >=20=20=20=20=20 > Tested by: yasu > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > --- > sys/kern/sys_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/kern/sys_pipe.c b/sys/kern/sys_pipe.c > index 2b81d08f7077..6a5d150423bc 100644 > --- a/sys/kern/sys_pipe.c > +++ b/sys/kern/sys_pipe.c > @@ -1677,7 +1677,7 @@ pipe_free_kmem(struct pipe *cpipe) >=20=20 > if (cpipe->pipe_buffer.buffer !=3D NULL) { > atomic_subtract_long(&amountpipekva, cpipe->pipe_buffer.size); > - chgpipecnt(cpipe->pipe_pair->pp_owner->cr_uidinfo, > + chgpipecnt(cpipe->pipe_pair->pp_owner->cr_ruidinfo, > -cpipe->pipe_buffer.size, 0); > vm_map_remove(pipe_map, > (vm_offset_t)cpipe->pipe_buffer.buffer, This appears to be the opposite of the patch which you posted on -current and which yasu@ tested (minus the bit that you committed as af96ccc6a508). That patch replaced cr_ruidinfo with cr_uidinfo in three places; this patch replaces cr_uidinfo with cr_ruidinfo somewhere else. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org