From nobody Fri Sep 20 08:00:42 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X94Zc3LdTz5XCFb for ; Fri, 20 Sep 2024 08:00:56 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X94Zb5l1nz458t for ; Fri, 20 Sep 2024 08:00:55 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3e04b7b3c6dso913218b6e.2 for ; Fri, 20 Sep 2024 01:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1726819254; x=1727424054; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4bONVrDtEJzNCZ0HfN4zoXrGtxdO+/I8PMU4Hetsm/A=; b=M7CPkryNniwL4koZA5+8MwheCKuUgMdTtZmnjqyryj3UbxDidB83IuMlK89Uo+LKw1 k6az1UIKiHm5gFFV3QzLUR6lnxCFT1MO8RJROT8Ka5aHbyO3edzv6vMxrY2zmjC8TgWJ A3ydlmFa+FXjPNcVOF2ZestaZSXi15ohGQMR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726819254; x=1727424054; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4bONVrDtEJzNCZ0HfN4zoXrGtxdO+/I8PMU4Hetsm/A=; b=JLTPg/S6lVaqj70dnfLU9o1CpscOMoQyzwXn/V2vot2t5Cu+2hiw8JcH/UZINR5Syd 3/ti3lUjlVcEjKpBC9p6LQ/Qm4HKQvLSdkRD7ofcAZ+GkY/rsXrKgw4fmHiulNkrj97a sAlC9k16A055bit7+mtY7QPZdd9CjkQEEiCusdVYc8b1FU14jnLh0QUYldzWrhq1jH9s 9bajSEb7tC3J7tgTJKgZEFvNquu38Tr6Ebz/M5K6oztFhZemGKOcjb9nhRPVh3qS/CFw knTsewidmiWRAtKLfwfGwkGFrxeqVIaFVLsI6L4oAGumeJ5an7+BTRR5ksyXK6FT4nhE k27g== X-Forwarded-Encrypted: i=1; AJvYcCWURZZnFk0Qs4TIJ+KSFjDES0PdPT0Wf9t4KYWEkdYdzvGdIKgAyoyz+yyIyKMJKnbprQ5qRTlShpBtc8eK9/b2k+eb@freebsd.org X-Gm-Message-State: AOJu0YzqB0Lb1HwOoMf6jh120n8RGhs5OwwXi0nh4FaQrwPFQxpug6rc W2JTNPCkmI4VyJqFbB+q9+/o0dNKBK+WL3IxVvrw2sT53d2z23/PLQxMXxMMqk32DSSJ0crl2Q7 HV5Ch3im6GW1fWyVF74oy+xQHckU2mYFnEUd6FuFkDOydNAo= X-Google-Smtp-Source: AGHT+IGCUmhP/Q7KPlesEfYn6QLjYiD4mWkH2QalLlrjC/3fTBQbh3hd0plv5/4zwk8F0lFNVsylAICQ7FTxOj4Gius= X-Received: by 2002:a05:6808:3986:b0:3d6:2da2:2b4e with SMTP id 5614622812f47-3e272941e41mr1196085b6e.14.1726819254578; Fri, 20 Sep 2024 01:00:54 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202409192103.48JL3ffi022099@gitrepo.freebsd.org> <084fa85b-7112-4dc5-bdb0-dbf727a28af0@freebsd.org> <20240920.154700.1207780392961840745.yasu@FreeBSD.org> In-Reply-To: From: Kevin Bowling Date: Fri, 20 Sep 2024 01:00:42 -0700 Message-ID: Subject: Re: git: 10746040820e - main - ixgbe: rename VF message type macros To: Doug Moore Cc: Yasuhiro Kimura , vishwin@freebsd.org, kbowling@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4X94Zb5l1nz458t X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Thu, Sep 19, 2024 at 11:49=E2=80=AFPM Doug Moore wr= ote: > > https://reviews.freebsd.org/D46708 Your fix is logically correct, thank you Doug. I committed it with your authorship as I would otherwise make the same change to fix the tree now. Pondering aloud, I am uncertain why this did not affect a modular build, I see if_sriov.c in the ix makefile. > > fixes compilation, if you want to copy it. > > On 9/20/24 01:47, Yasuhiro Kimura wrote: > > From: Charlie Li > > Subject: Re: git: 10746040820e - main - ixgbe: rename VF message type m= acros > > Date: Thu, 19 Sep 2024 23:59:47 -0400 > > > >> Build fails: > >> /usr/src/sys/dev/ixgbe/if_sriov.c:103:16: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 103 | sc->hw.mbx.ops.write(&sc->hw, &msg, 1, vf->pool); > >> | ~~~~~~~~~~~~~~^~~~~~ > >> /usr/src/sys/dev/ixgbe/if_sriov.c:377:13: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 377 | hw->mbx.ops.write(hw, resp, IXGBE_VF_PERMADDR_MSG_LEN, > >> vf->pool); > >> | ~~~~~~~~~~~^~~~~~ > >> /usr/src/sys/dev/ixgbe/if_sriov.c:568:13: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 568 | hw->mbx.ops.write(hw, resp, IXGBE_VF_GET_QUEUES_RESP_LEN, > >> vf->pool); > >> | ~~~~~~~~~~~^~~~~~ > >> /usr/src/sys/dev/ixgbe/if_sriov.c:585:21: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 585 | error =3D hw->mbx.ops.read(hw, msg, IXGBE_VFMAILBOX_SIZE, > >> vf->pool); > >> | ~~~~~~~~~~~^~~~~ > >> /usr/src/sys/dev/ixgbe/if_sriov.c:646:19: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 646 | if (hw->mbx.ops.check_for_rst(hw, vf->pool) =3D=3D 0) > >> | ~~~~~~~~~~~^~~~~~~~~~~~~~ > >> /usr/src/sys/dev/ixgbe/if_sriov.c:649:19: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 649 | if (hw->mbx.ops.check_for_msg(hw, vf->pool) =3D=3D 0) > >> | ~~~~~~~~~~~^~~~~~~~~~~~~~ > >> /usr/src/sys/dev/ixgbe/if_sriov.c:652:19: error: member reference base > >> type 'struct ixgbe_mbx_operations[64]' is not a structure or union > >> 652 | if (hw->mbx.ops.check_for_ack(hw, vf->pool) =3D=3D 0) > >> | ~~~~~~~~~~~^~~~~~~~~~~~~~ > >> 7 errors generated. > >> *** [if_sriov.o] Error code 1 > > Same here with: > > > > * Commit 420c9844702 > > * amd64 > > * Clean build from scratch > > > > --- > > Yasuhiro Kimura