From nobody Fri Sep 06 20:55:21 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X0pQn42z6z5VyGt; Fri, 06 Sep 2024 20:55:29 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4X0pQn0Stjz44Xl; Fri, 6 Sep 2024 20:55:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 486KtLwx014113; Fri, 6 Sep 2024 23:55:25 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 486KtLwx014113 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 486KtLI3014112; Fri, 6 Sep 2024 23:55:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 6 Sep 2024 23:55:21 +0300 From: Konstantin Belousov To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5d889e60c15c - main - amd64: move the right parenthesis to the right place Message-ID: References: <202409061835.486IZJxv011127@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202409061835.486IZJxv011127@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4X0pQn0Stjz44Xl On Fri, Sep 06, 2024 at 06:35:19PM +0000, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=5d889e60c15ce7856cb9a9bc258dab8aaeb94efe > > commit 5d889e60c15ce7856cb9a9bc258dab8aaeb94efe > Author: Wuyang Chung > AuthorDate: 2024-08-02 06:44:38 +0000 > Commit: Warner Losh > CommitDate: 2024-09-06 18:34:31 +0000 > > amd64: move the right parenthesis to the right place > > Reviewed by: imp, emaste > Pull Request: https://github.com/freebsd/freebsd-src/pull/1356 > --- > sys/amd64/amd64/machdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/amd64/amd64/machdep.c b/sys/amd64/amd64/machdep.c > index 025c3c365de5..f4b3b9702e00 100644 > --- a/sys/amd64/amd64/machdep.c > +++ b/sys/amd64/amd64/machdep.c > @@ -1382,7 +1382,7 @@ hammer_time(u_int64_t modulep, u_int64_t physfree) > */ > for (x = 0; x < NGDT; x++) { > if (x != GPROC0_SEL && x != (GPROC0_SEL + 1) && > - x != GUSERLDT_SEL && x != (GUSERLDT_SEL) + 1) > + x != GUSERLDT_SEL && x != (GUSERLDT_SEL + 1)) > ssdtosd(&gdt_segs[x], &gdt[x]); > } > gdt_segs[GPROC0_SEL].ssd_base = (uintptr_t)&pc->pc_common_tss; The moved parenthesis are not needed at all, and should be removed according to style. Same for the () in the previous line.