From nobody Thu Sep 05 15:35:14 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X03Mk537gz5WFdx; Thu, 05 Sep 2024 15:35:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X03Mk4B9rz4jPg; Thu, 5 Sep 2024 15:35:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725550514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+oALFUeF5rTmHsUpvnwMnkihbPJj8us5yHk/uTsYBxI=; b=JjDRXoTImsEm+NDe/3UZBvGXTLHcK2dEIqWbYULEayNqhthbAfh8IVu3ny/orDt5Z9DEg1 aCoFp7JR0p1IOBtM71u5nlQlADjTmfhDMmHDqR4gG8q1QIjh57JKoYGJeR0RZlQw9ZydpZ FLXXznZrI/oBXVdYLuADlf0Vz8DM9ToWdlKxT/Lh4hncIYvOm3yRFj9YbfxPpekQMSMt6Q DVubiTWbe30fSxazuj+RVpPQN5UyoWnl9x2psBTWYDDYlug+Tlt+orYJCXxoMGnLrYqzZa 48+P6H/x5XrLwcsAA1CVf/WxNJ49ntl9q5iSEoei1bezD0KvjrFuU+0CbVu0fw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725550514; a=rsa-sha256; cv=none; b=nRTKvjIXHk/1X9i2J5MnQd8W7TtE+YhCjAFAO0M5v3j8b1852P2lHPVH2qq7r/hHmeTOK1 1DaucGIE/Zy31KAsnc6ZIOg5/otNxOdPXQBXr5UyeEaQ4EYhGpYr4U4VqVymdacm/TrqY8 p4m1eC1bEA8UYs0QhXaWVK760G9zhzaLLiKEDpXZuxzN1tRzKrv7/6fAEc2uPdWqSpgoNu G9+mtEAGNP09zn4+rs2edzNQtfM+MBzjCZSeDH4aThPJc8RrSfRm1LUjELvTFKFrZhD/+M D7aq8wXc2PQNrtmPip5PxAQ9CJMhPlNDyCtYS8ZqE7Diz75vLo2hZDcexZMnaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725550514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+oALFUeF5rTmHsUpvnwMnkihbPJj8us5yHk/uTsYBxI=; b=CZf3d3OkAzxot21fg4K1WYCsf8STRJ5XU0d2npSbvw1Ld5Cx8jJLNbU19C4ys5JSZsuBbH /Nep3XzWaCH/ff/FxAfqFDbf9iBcI0a6vvrA0lA/PTeV2x7PA0Yus1GJF+dOXWPcUgueiZ VouXO+Zh0N9Ho/02idQL5MkdyholvVUSJNF+5HgvbegGnm7CsSGFdjk3iYsq5EKydrGPp1 4irDOpRdrbJrRvdwMjmEBUuUMIvLgwfUPFrFVgIXI+5xYiXp4Wczwqao7U9roRO94xla1d XZzn7B9b11yF/TtXF/xosT2iorVH/GyQ7JG0/XN20/NEfIdTozH2+gqr0xII+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X03Mk3gNyzDb9; Thu, 5 Sep 2024 15:35:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 485FZEhO052529; Thu, 5 Sep 2024 15:35:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 485FZE3I052526; Thu, 5 Sep 2024 15:35:14 GMT (envelope-from git) Date: Thu, 5 Sep 2024 15:35:14 GMT Message-Id: <202409051535.485FZE3I052526@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 5203dcce2527 - main - neta: improve TCP LRO List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5203dcce2527fd235648e2b855a13f62247eb2de Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=5203dcce2527fd235648e2b855a13f62247eb2de commit 5203dcce2527fd235648e2b855a13f62247eb2de Author: Michael Tuexen AuthorDate: 2024-09-05 15:31:31 +0000 Commit: Michael Tuexen CommitDate: 2024-09-05 15:31:31 +0000 neta: improve TCP LRO Use the appropriate function to flush correctly all entries. The old code does not remove the element from the hash table, only from the active queue. Reviewed by: Peter Lei, rscheff MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46433 --- sys/dev/neta/if_mvneta.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index e663306509a0..bc57b10b6d8e 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -3000,8 +3000,6 @@ mvneta_rx_queue(struct mvneta_softc *sc, int q, int npkt) struct mvneta_rx_desc *r; struct mvneta_buf *rxbuf; struct mbuf *m; - struct lro_ctrl *lro; - struct lro_entry *queued; void *pktbuf; int i, pktlen, processed, ndma; @@ -3115,11 +3113,7 @@ rx_lro: /* * Flush any outstanding LRO work */ - lro = &rx->lro; - while (__predict_false((queued = LIST_FIRST(&lro->lro_active)) != NULL)) { - LIST_REMOVE(LIST_FIRST((&lro->lro_active)), next); - tcp_lro_flush(lro, queued); - } + tcp_lro_flush_all(&rx->lro); } STATIC void