From nobody Wed Sep 04 20:54:21 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WzZVP6VYbz5VMtv; Wed, 04 Sep 2024 20:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WzZVP4PnDz4Q6S; Wed, 4 Sep 2024 20:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725483261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PAMkL9nCMXF8AqqKNPnqKXRaDLg6YfjDu4Gdo5dTwKU=; b=ALa+yY84J+suKYmbLUvLGN8kciFrtuwkfxdOgK9MfdfM/L29lwFzyMHc8EvyarSjuQtjIo Nk2a1AhkW1RzVPTo1h63wBI0Y0/M75/xAwh4aRtVoR/mZV0ZyQ2EH0hxsCuoiabfZxqdiL clINlpmoi6LIzC0Wi2WmQ1uC0+FO8rnEIOvwoo/I+UEVCpSpESmfPMOLu8Lgm0Q6gIKPzT M7+oykIZcyMxfqCG2ajCmmQQ14CRM2CVuSwKKSFxzXZT17bxCYBeh8KShV5K33yTGYd3FG 3Keqwq7j+mdDDqP+j5n2PrdkVytcwTB3VCzrzDhIilWZnpZnajJlvWx2sgdBPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725483261; a=rsa-sha256; cv=none; b=wiK04D+8dK7h+qVAtr3WqF/2KVQEA+Q6SHj1P/PK4zTuQREGgiZ8d1uqjgTi4jKHLQlQhd Un+CN+5BBjpF7pPzTZdQILTgmUR+3koBKagPha7y+Uvt2D27EtalVEUyeyFmQgg2sqLohj HasNttZaFLh6JDQ9qj91vEhkyF6L05rfoQBiwaWyBbc+NC/vbXMneQ99708rFpYiSRSQIr 3zfQjPfASkeBWWODD329cmrROlJpwFXBHgGUBkFsNPNkQjOnvZN1t3qgGty2FO40ThZrTR EJ0h5faRkZcaIUqXtzGCpCKfHumG3UCIl9EIdai85Rq2YsEskjvxe2JO118FdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725483261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PAMkL9nCMXF8AqqKNPnqKXRaDLg6YfjDu4Gdo5dTwKU=; b=BGt9K7tx4pf5YEUlcac0Fd16ZNuNxInRt5nx+51hu0HT4XrLoFwY0culB94B+5vlEnGH/Y mS+PH52k51aG4SxT4pm9gTEBpgTa1SKoAASwf33PzmTRMhIx/G3CVMM18/F+X1GPbUfumu 70kU/u0ChTqL6ZgIbJJrXQp5nU6Gy1AcP2ZLj8ooIGjhqE4XtzQJXcAnPjYJcyWwVtrGC7 hgVx0XGgINfniBp3au6HtEv4047zrmfVu7pYMBjVLwRYqNxPLldblA/k8P364X0r4ST+34 3owrlWcrWWiUs8Lr40LHIbcMFUJHHcdrTlgHwdXSBTrT/7xfFAZitwWsM5Q2xw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WzZVP3znCzgMr; Wed, 4 Sep 2024 20:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 484KsLom034088; Wed, 4 Sep 2024 20:54:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 484KsLpv034085; Wed, 4 Sep 2024 20:54:21 GMT (envelope-from git) Date: Wed, 4 Sep 2024 20:54:21 GMT Message-Id: <202409042054.484KsLpv034085@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: d868c5df69a8 - releng/14.0 - umtx: shm: Collapse USHMF_REG_LINKED and USHMF_OBJ_LINKED flags List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: d868c5df69a8cbf6ea3cf3ed4ce2b200eafc92c5 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=d868c5df69a8cbf6ea3cf3ed4ce2b200eafc92c5 commit d868c5df69a8cbf6ea3cf3ed4ce2b200eafc92c5 Author: Olivier Certner AuthorDate: 2024-09-04 14:38:12 +0000 Commit: Ed Maste CommitDate: 2024-09-04 20:54:03 +0000 umtx: shm: Collapse USHMF_REG_LINKED and USHMF_OBJ_LINKED flags ...into the only USHMF_LINKED, as they are always set or unset together. This is both to stop giving the impression that they can be set/unset independently, which they can't with the current code, and to make it clearer that an upcoming reference counting fix is correct. Reviewed by: kib Approved by: emaste (mentor) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46126 (cherry picked from commit dd83da532c36830a0c0aac624903849262ec6f68) (cherry picked from commit 2d4511bb81ed70d84ba6ed2ffb54e6a138653a63) Approved by: so --- sys/kern/kern_umtx.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/sys/kern/kern_umtx.c b/sys/kern/kern_umtx.c index ff9505b8e31d..afc3f705e231 100644 --- a/sys/kern/kern_umtx.c +++ b/sys/kern/kern_umtx.c @@ -4271,8 +4271,7 @@ __umtx_op_sem2_wake(struct thread *td, struct _umtx_op_args *uap, #define USHM_OBJ_UMTX(o) \ ((struct umtx_shm_obj_list *)(&(o)->umtx_data)) -#define USHMF_REG_LINKED 0x0001 -#define USHMF_OBJ_LINKED 0x0002 +#define USHMF_LINKED 0x0001 struct umtx_shm_reg { TAILQ_ENTRY(umtx_shm_reg) ushm_reg_link; LIST_ENTRY(umtx_shm_reg) ushm_obj_link; @@ -4332,7 +4331,7 @@ umtx_shm_find_reg_locked(const struct umtx_key *key) KASSERT(reg->ushm_key.type == TYPE_SHM, ("TYPE_USHM")); KASSERT(reg->ushm_refcnt > 0, ("reg %p refcnt 0 onlist", reg)); - KASSERT((reg->ushm_flags & USHMF_REG_LINKED) != 0, + KASSERT((reg->ushm_flags & USHMF_LINKED) != 0, ("reg %p not linked", reg)); reg->ushm_refcnt++; return (reg); @@ -4372,14 +4371,11 @@ umtx_shm_unref_reg_locked(struct umtx_shm_reg *reg, bool force) reg->ushm_refcnt--; res = reg->ushm_refcnt == 0; if (res || force) { - if ((reg->ushm_flags & USHMF_REG_LINKED) != 0) { + if ((reg->ushm_flags & USHMF_LINKED) != 0) { TAILQ_REMOVE(&umtx_shm_registry[reg->ushm_key.hash], reg, ushm_reg_link); - reg->ushm_flags &= ~USHMF_REG_LINKED; - } - if ((reg->ushm_flags & USHMF_OBJ_LINKED) != 0) { LIST_REMOVE(reg, ushm_obj_link); - reg->ushm_flags &= ~USHMF_OBJ_LINKED; + reg->ushm_flags &= ~USHMF_LINKED; } } return (res); @@ -4472,7 +4468,7 @@ umtx_shm_create_reg(struct thread *td, const struct umtx_key *key, TAILQ_INSERT_TAIL(&umtx_shm_registry[key->hash], reg, ushm_reg_link); LIST_INSERT_HEAD(USHM_OBJ_UMTX(key->info.shared.object), reg, ushm_obj_link); - reg->ushm_flags = USHMF_REG_LINKED | USHMF_OBJ_LINKED; + reg->ushm_flags = USHMF_LINKED; mtx_unlock(&umtx_shm_lock); *res = reg; return (0);