From nobody Wed Sep 04 14:53:58 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WzQVb1DdHz5V3Mm; Wed, 04 Sep 2024 14:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WzQVZ6D35z4JXM; Wed, 4 Sep 2024 14:53:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725461638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jHr+ye4STj+0PBoObvOWkloKIAcz3E7p/VdN5nVWofE=; b=upf8NOvrdeZ+jWBHK6dHsVR81uDC36E6AZhiVfYKNH0w//oyANj2NJVcA1kxr6rBWbV+XL VGVpc5xnfh3SPWDOIpreMUVu1TnhyhRI2vRN6vuToClwLXsEehAIAhweBu25DsgmrzjgnC qHsjOkRQ7qxJDemHg02++sJTSOrvCAPuOZPCPTIxxipKV8EG1WgvuzN/YroJYxg5AjzTvp 0cPvD04++A1j+t31Ys970QPHZlijVBdvzHhMg2VWozE2WUKG8Xx1gDlr4CUklVqP9zClNk AG0DSh45108yODyKvrwKtjSsctVMGeiU9LLj+fECpirg4FPogkWOi3xMu1Q7tQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725461638; a=rsa-sha256; cv=none; b=x0AIkQBh+4mRZ3sWG4PjBnsSex1Fhn8pLrOts8yBhAbcobQMRhbwBGl0Ns9FHX6u5ZaIqb aoDLhmdnIs6MRzVwYiWUk+339NYOn7uvd/i4FHdZ/ACF4JDCKPSJzFdKi3UfMEOFFYTG2c A5trfA9QgaLDmuLYn+LNEUGqowKWtcYMxZe7X5DowRc64MvA+9mJHQBzw4h29uCdmJ1MZQ HE10MwgCFi1Dbnz83eJdW7XUkDH8F3VqRiMXLCFvT5Ft/YyRPt9mamnNlhK09xoufU6n14 JWuaRNsTNxgj/u5XYlMw/H98CfpFTLw/qbqWF6F3jtYeQXX9GZQKMTSpndPdzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725461638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jHr+ye4STj+0PBoObvOWkloKIAcz3E7p/VdN5nVWofE=; b=eXN5fsStTJ2riJ0yDcMzOubyvoLYbrwLRS3ppEvFLrBp7OLhH+vj5ibYTbNWDbcMiECfX1 wJGBpqDwevxE+3FiBzEZPBzSjGcI2cI0BLJ1lh4ougktXBXlEoyYM51xORBh+U21J3NBsb 9K+GNOYatB0Ph1nDqaye7WlbiVCm+fmvp0vleg4nMMnTkacER2l4PZiWuFs/MctpmNf9IQ XFOJ89KNdMUpipgUDKoHMPDsEX4Us6+Q59qDw7W6lqpb3/61fKnGz5mcZxcNoggCgxx2Z9 sZd4ZLQSItV6TNVC+UwMCuf5RgV4abxiTHJ6Zz9H4CBaNbkL52vvniBbgUbtWA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WzQVZ5qT7zTGh; Wed, 4 Sep 2024 14:53:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 484Erw84017433; Wed, 4 Sep 2024 14:53:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 484ErwTx017430; Wed, 4 Sep 2024 14:53:58 GMT (envelope-from git) Date: Wed, 4 Sep 2024 14:53:58 GMT Message-Id: <202409041453.484ErwTx017430@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: c75a18905e30 - main - umtx: shm: 'ushm_refcnt > 0' => 'ushm_refcnt != 0' List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c75a18905e308f69b01f19c3d7d613883a008e79 Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=c75a18905e308f69b01f19c3d7d613883a008e79 commit c75a18905e308f69b01f19c3d7d613883a008e79 Author: Olivier Certner AuthorDate: 2024-09-04 14:38:12 +0000 Commit: Ed Maste CommitDate: 2024-09-04 14:38:12 +0000 umtx: shm: 'ushm_refcnt > 0' => 'ushm_refcnt != 0' 'ushm_refcnt' is unsigned. Don't leave the impression it isn't. No functional change (intended). Reviewed by: kib Approved by: emaste (mentor) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46126 --- sys/kern/kern_umtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_umtx.c b/sys/kern/kern_umtx.c index a6c160ab6283..705571930d7b 100644 --- a/sys/kern/kern_umtx.c +++ b/sys/kern/kern_umtx.c @@ -4360,7 +4360,7 @@ umtx_shm_find_reg_locked(const struct umtx_key *key, reg->ushm_key.info.shared.offset == key->info.shared.offset) { KASSERT(reg->ushm_key.type == TYPE_SHM, ("TYPE_USHM")); - KASSERT(reg->ushm_refcnt > 0, + KASSERT(reg->ushm_refcnt != 0, ("reg %p refcnt 0 onlist", reg)); KASSERT((reg->ushm_flags & USHMF_LINKED) != 0, ("reg %p not linked", reg)); @@ -4408,7 +4408,7 @@ static bool umtx_shm_unref_reg_locked(struct umtx_shm_reg *reg, bool linked_ref) { mtx_assert(&umtx_shm_lock, MA_OWNED); - KASSERT(reg->ushm_refcnt > 0, ("ushm_reg %p refcnt 0", reg)); + KASSERT(reg->ushm_refcnt != 0, ("ushm_reg %p refcnt 0", reg)); if (linked_ref) { if ((reg->ushm_flags & USHMF_LINKED) == 0)